[GitHub] [hbase] wchevreuil commented on a change in pull request #324: [HBASE-22606] : BucketCache improvement with additional tests

[GitBox <gi...@apache.org>]

wchevreuil commented on a change in pull request #324: [HBASE-22606] : BucketCache improvement with additional tests
URL: https://github.com/apache/hbase/pull/324#discussion_r295820794
 
 

 ##########
 File path: hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/bucket/TestBucketCache.java
 ##########
 @@ -315,13 +367,34 @@ public void testGetPartitionSize() throws IOException {
     conf.setFloat(BucketCache.MEMORY_FACTOR_CONFIG_NAME, 0.2f);
 
     BucketCache cache = new BucketCache(ioEngineName, capacitySize, constructedBlockSize,
-        constructedBlockSizes, writeThreads, writerQLen, persistencePath, 100, conf);
+        constructedBlockSizes, writeThreads, writerQLen, null, 100, conf);
 
     validateGetPartitionSize(cache, 0.1f, 0.5f);
     validateGetPartitionSize(cache, 0.7f, 0.5f);
     validateGetPartitionSize(cache, 0.2f, 0.5f);
   }
 
+  @Test
 
 Review comment:
   Should be _@Test (expected = IllegalArgumentException.class)_

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services