You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by "songwenyong (via GitHub)" <gi...@apache.org> on 2024/03/14 12:19:03 UTC
[I] [Improvement][api]DataSource And UdfFunc list query shold use Enum code not ordinal [dolphinscheduler]
songwenyong opened a new issue, #15713:
URL: https://github.com/apache/dolphinscheduler/issues/15713
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
When saving DataSource entities to the database, the DbType value is determined by the field annotated with @EnumValue, where it takes the value of 'code'. Similarly, when saving UdfFunc entities, the 'type' field operates in a similar manner. However, during list queries in the API module, the values are obtained using the ordinal method of the enums.
During the process of extending DbType in DolphinScheduler's secondary development, users have observed that if the codes are not incremented properly, bugs may occur.
### Are you willing to submit a PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Improvement][api]DataSource And UdfFunc list query shold use Enum code not ordinal [dolphinscheduler]
Posted by "songwenyong (via GitHub)" <gi...@apache.org>.
songwenyong commented on issue #15713:
URL: https://github.com/apache/dolphinscheduler/issues/15713#issuecomment-1999733953
This resolves #15714
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Improvement][api]DataSource And UdfFunc list query shold use Enum code not ordinal [dolphinscheduler]
Posted by "rickchengx (via GitHub)" <gi...@apache.org>.
rickchengx closed issue #15713: [Improvement][api]DataSource And UdfFunc list query shold use Enum code not ordinal
URL: https://github.com/apache/dolphinscheduler/issues/15713
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org