You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by clebertsuconic <gi...@git.apache.org> on 2018/08/01 22:03:16 UTC
[GitHub] activemq-artemis pull request #2209: ARTEMIS-856 Fixing MessageRedistributio...
GitHub user clebertsuconic opened a pull request:
https://github.com/apache/activemq-artemis/pull/2209
ARTEMIS-856 Fixing MessageRedistributionTest
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/clebertsuconic/activemq-artemis redistribution-fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/2209.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2209
----
commit ab254030faca2e2dcd98ef8165a74cbc235fe754
Author: Clebert Suconic <cl...@...>
Date: 2018-08-01T22:01:48Z
ARTEMIS-856 Fixing MessageRedistributionTest
----
---
[GitHub] activemq-artemis issue #2209: ARTEMIS-856 Fixing MessageRedistributionTest
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2209
@michaelandrepearce Can you look into ExclusiveTest::testExclusiveTopicSharedConsumerFailover
It's failing even without my changes.. and after my changes.. I couldn't figure out today.
---
[GitHub] activemq-artemis issue #2209: ARTEMIS-856 Test fixes
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2209
This is replaced by #2211
---
[GitHub] activemq-artemis pull request #2209: ARTEMIS-856 Test fixes
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic closed the pull request at:
https://github.com/apache/activemq-artemis/pull/2209
---
[GitHub] activemq-artemis pull request #2209: ARTEMIS-856 Test fixes
Posted by michaelandrepearce <gi...@git.apache.org>.
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2209#discussion_r207214263
--- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java ---
@@ -544,6 +560,7 @@ public boolean isExclusive() {
@Override
public synchronized void setExclusive(boolean exclusive) {
+ new Exception("exclusive set at " + exclusive).printStackTrace();
--- End diff --
Think this needs to be removed.
---
[GitHub] activemq-artemis issue #2209: ARTEMIS-856 Fixing MessageRedistributionTest
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2209
@michaelandrepearce I need you to take a look into this please.
MessageRedistributionFix is broken, up to the point I can't complete a whole testsuite on my internal CI.
My idea was the emulate the previous collection where redistributor would be an item, while still checking if redistributor is the only allowed item to be used on the loop.
I'm not sure how else we would change this without making substantial refactoring to your previous commit.
Can you look into this PR please?
---
[GitHub] activemq-artemis pull request #2209: ARTEMIS-856 Test fixes
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2209#discussion_r207215079
--- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java ---
@@ -544,6 +560,7 @@ public boolean isExclusive() {
@Override
public synchronized void setExclusive(boolean exclusive) {
+ new Exception("exclusive set at " + exclusive).printStackTrace();
--- End diff --
Thanks. That’s debug I forgot :p
---
[GitHub] activemq-artemis issue #2209: ARTEMIS-856 Fixing MessageRedistributionTest
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2209
@michaelandrepearce : But please don't merge it yet.. I'm running a whole testsuite on the CI before we can merge this... just let me know what you think first.
---
[GitHub] activemq-artemis issue #2209: ARTEMIS-856 Test fixes
Posted by michaelandrepearce <gi...@git.apache.org>.
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/2209
@clebertsuconic, looks good, there we some bits with consumer lists with the redistributor i heavily want to avoid, im working an alternative option, but if to fix master happy to merge this, and i can supply my alternative later (have raised a pr so you can see, but still not complete)
---