You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Zameer Manji <zm...@apache.org> on 2016/04/16 01:27:50 UTC
Review Request 46289: Make MyBatis connection pool size configurable.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46289/
-----------------------------------------------------------
Review request for Aurora and Maxim Khutornenko.
Repository: aurora
Description
-------
This adds two arguments which enables operators to configure the internal MyBatis connection pool size. Increasing the size will allow for greater concurrency in larger clusters.
Diffs
-----
src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java 743993cef43f028ff0d53d93adacb86f5ed79a5c
Diff: https://reviews.apache.org/r/46289/diff/
Testing
-------
Thanks,
Zameer Manji
Re: Review Request 46289: Make MyBatis connection pool size
configurable.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46289/#review129213
-----------------------------------------------------------
Master (81f52e4) is red with this patch.
./build-support/jenkins/build.sh
:commons:generateThriftResources
:commons:processResources
:commons:classes
:commons:jar
:compileJava/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java:74: Note: Wrote forwarder org.apache.aurora.scheduler.storage.log.WriteAheadStorageForwarder
@Forward({
^
Note: Writing file:/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/classes/main/org/apache/aurora/common/args/apt/cmdline.arg.info.txt.2
Note: Writing file:/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/classes/main/META-INF/compiler/resource-mappings/org.apache.aurora.common.args.apt.CmdLineProcessor
:generateBuildProperties
:processResources
:classes
:jar
:startScripts
:distTar
:distZip
:assemble
:compileJmhJavaNote: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/jmh/java/org/apache/aurora/benchmark/fakes/FakeSchedulerDriver.java uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
:processJmhResources UP-TO-DATE
:jmhClasses
:checkstyleJmh
:jsHint
:checkstyleMain[ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java:280: error: File contains a sequence of empty lines.
FAILED
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':checkstyleMain'.
> Checkstyle rule violations were found. See the report at: file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/checkstyle/main.html
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
BUILD FAILED
Total time: 1 mins 38.734 secs
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On April 15, 2016, 11:27 p.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46289/
> -----------------------------------------------------------
>
> (Updated April 15, 2016, 11:27 p.m.)
>
>
> Review request for Aurora and Maxim Khutornenko.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This adds two arguments which enables operators to configure the internal MyBatis connection pool size. Increasing the size will allow for greater concurrency in larger clusters.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java 743993cef43f028ff0d53d93adacb86f5ed79a5c
>
> Diff: https://reviews.apache.org/r/46289/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zameer Manji
>
>
Re: Review Request 46289: Make MyBatis connection pool size
configurable.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46289/#review129217
-----------------------------------------------------------
Master (81f52e4) is red with this patch.
./build-support/jenkins/build.sh
Test coverage missing for org/apache/aurora/scheduler/cron/quartz/AuroraCronJobFactory
Test coverage missing for org/apache/aurora/scheduler/cron/quartz/AuroraCronJob$Config
Test coverage missing for org/apache/aurora/scheduler/cron/quartz/CronJobManagerImpl
Test coverage missing for org/apache/aurora/scheduler/storage/mem/MemCronJobStore
Test coverage missing for org/apache/aurora/scheduler/storage/mem/MemTaskStore$1
Test coverage missing for org/apache/aurora/scheduler/storage/mem/MemTaskStore$SecondaryIndex$2
Test coverage missing for org/apache/aurora/scheduler/storage/mem/MemTaskStore$SecondaryIndex$1
Test coverage missing for org/apache/aurora/scheduler/storage/mem/MemTaskStore$SecondaryIndex
Test coverage missing for org/apache/aurora/scheduler/storage/mem/MemTaskStore
Test coverage missing for org/apache/aurora/scheduler/preemptor/PreemptorModule$PreemptorService
Test coverage missing for org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl
Test coverage missing for org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl$8
Test coverage missing for org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl$7
Test coverage missing for org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl$4
Test coverage missing for org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl$3
Test coverage missing for org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl$6
Test coverage missing for org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl$5
Test coverage missing for org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl$2
Test coverage missing for org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl$1
Test coverage missing for org/apache/aurora/scheduler/storage/log/LogStorage$Settings
Test coverage missing for org/apache/aurora/scheduler/storage/log/LogStorage$ScheduledExecutorSchedulingService
Test coverage missing for org/apache/aurora/scheduler/storage/backup/TemporaryStorage$TemporaryStorageFactory$1
Test coverage missing for org/apache/aurora/scheduler/storage/backup/TemporaryStorage$TemporaryStorageFactory
Test coverage missing for org/apache/aurora/scheduler/storage/backup/Recovery$RecoveryImpl$PendingRecovery
Test coverage missing for org/apache/aurora/scheduler/SchedulerLifecycle$DefaultDelayedActions
Test coverage missing for org/apache/aurora/scheduler/TaskIdGenerator$TaskIdGeneratorImpl
Test coverage missing for org/apache/aurora/scheduler/storage/db/typehandlers/ScheduleStatusTypeHandler
Test coverage missing for org/apache/aurora/scheduler/storage/db/typehandlers/JobUpdateStatusTypeHandler
Test coverage missing for org/apache/aurora/scheduler/storage/db/typehandlers/MaintenanceModeTypeHandler
Test coverage missing for org/apache/aurora/scheduler/storage/db/typehandlers/CronCollisionPolicyTypeHandler
Test coverage missing for org/apache/aurora/scheduler/storage/db/typehandlers/AbstractTEnumTypeHandler
Test coverage missing for org/apache/aurora/scheduler/storage/db/typehandlers/JobUpdateActionTypeHandler
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
==============================================================================
BUILD FAILED
Total time: 4 mins 18.598 secs
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On April 15, 2016, 11:37 p.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46289/
> -----------------------------------------------------------
>
> (Updated April 15, 2016, 11:37 p.m.)
>
>
> Review request for Aurora and Maxim Khutornenko.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This adds two arguments which enables operators to configure the internal MyBatis connection pool size. Increasing the size will allow for greater concurrency in larger clusters.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java 743993cef43f028ff0d53d93adacb86f5ed79a5c
>
> Diff: https://reviews.apache.org/r/46289/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zameer Manji
>
>
Re: Review Request 46289: Make MyBatis connection pool size
configurable.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46289/#review129237
-----------------------------------------------------------
Master (81f52e4) is green with this patch.
./build-support/jenkins/build.sh
However, it appears that it might lack test coverage.
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On April 16, 2016, 2:10 a.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46289/
> -----------------------------------------------------------
>
> (Updated April 16, 2016, 2:10 a.m.)
>
>
> Review request for Aurora and Maxim Khutornenko.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This adds two arguments which enables operators to configure the internal MyBatis connection pool size. Increasing the size will allow for greater concurrency in larger clusters.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java 743993cef43f028ff0d53d93adacb86f5ed79a5c
>
> Diff: https://reviews.apache.org/r/46289/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zameer Manji
>
>
Re: Review Request 46289: Make MyBatis connection pool size
configurable.
Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46289/
-----------------------------------------------------------
(Updated April 15, 2016, 7:10 p.m.)
Review request for Aurora and Maxim Khutornenko.
Repository: aurora
Description
-------
This adds two arguments which enables operators to configure the internal MyBatis connection pool size. Increasing the size will allow for greater concurrency in larger clusters.
Diffs (updated)
-----
src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java 743993cef43f028ff0d53d93adacb86f5ed79a5c
Diff: https://reviews.apache.org/r/46289/diff/
Testing
-------
Thanks,
Zameer Manji
Re: Review Request 46289: Make MyBatis connection pool size
configurable.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46289/#review129220
-----------------------------------------------------------
Ship it!
src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java (line 91)
<https://reviews.apache.org/r/46289/#comment192672>
@Positive here and below.
- Maxim Khutornenko
On April 15, 2016, 11:37 p.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46289/
> -----------------------------------------------------------
>
> (Updated April 15, 2016, 11:37 p.m.)
>
>
> Review request for Aurora and Maxim Khutornenko.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This adds two arguments which enables operators to configure the internal MyBatis connection pool size. Increasing the size will allow for greater concurrency in larger clusters.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java 743993cef43f028ff0d53d93adacb86f5ed79a5c
>
> Diff: https://reviews.apache.org/r/46289/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zameer Manji
>
>
Re: Review Request 46289: Make MyBatis connection pool size
configurable.
Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46289/
-----------------------------------------------------------
(Updated April 15, 2016, 4:37 p.m.)
Review request for Aurora and Maxim Khutornenko.
Changes
-------
Fix style issue.
Repository: aurora
Description
-------
This adds two arguments which enables operators to configure the internal MyBatis connection pool size. Increasing the size will allow for greater concurrency in larger clusters.
Diffs (updated)
-----
src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java 743993cef43f028ff0d53d93adacb86f5ed79a5c
Diff: https://reviews.apache.org/r/46289/diff/
Testing
-------
Thanks,
Zameer Manji