You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@knox.apache.org by GitBox <gi...@apache.org> on 2020/02/25 16:13:05 UTC

[GitHub] [knox] lmccay commented on a change in pull request #263: KNOX-2226 - Add home page to Knox

lmccay commented on a change in pull request #263: KNOX-2226 - Add home page to Knox
URL: https://github.com/apache/knox/pull/263#discussion_r383981952
 
 

 ##########
 File path: gateway-release/home/conf/topologies/metadata.xml
 ##########
 @@ -0,0 +1,64 @@
+<?xml version="1.0" encoding="utf-8"?>
 
 Review comment:
   I see that the metadata.xml topology is aligned with other existing topologies like admin.xml for instance. I think that we need to consider moving these to descriptors that point to the default-providers.json shared provider config. This way the authentication can be changed in one place. Admin will require an authorization provider but since it is for the admin service and not others that should be okay. Let's not block this PR and follow up with another to move to descriptors. Just wanted to mention it here.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services