You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Santiago García Pimentel (Jira)" <ji...@apache.org> on 2021/01/27 09:49:00 UTC
[jira] [Commented] (SLING-10096) Allow the SlingHttpServletRequest
in the IncludeGenerator or Sling dynamic includes
[ https://issues.apache.org/jira/browse/SLING-10096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17272719#comment-17272719 ]
Santiago García Pimentel commented on SLING-10096:
--------------------------------------------------
I've made a preliminar PR in [https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/19#issuecomment-768130982] but Im happy to discuss a better approach.
> Allow the SlingHttpServletRequest in the IncludeGenerator or Sling dynamic includes
> -----------------------------------------------------------------------------------
>
> Key: SLING-10096
> URL: https://issues.apache.org/jira/browse/SLING-10096
> Project: Sling
> Issue Type: Improvement
> Reporter: Santiago García Pimentel
> Priority: Major
>
> The current interface of the IncludeGenerator of Sling Dynamic Includes only pass the String with the original URL.
> It would be great to allow to pass it also the Request to allow clients to implement more robust/complex implementations.
> For example, allow to create SDI that use the information of the user making the request
--
This message was sent by Atlassian Jira
(v8.3.4#803005)