You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@felix.apache.org by vv...@apache.org on 2010/06/04 10:52:54 UTC

svn commit: r951329 - /felix/trunk/webconsole/src/main/java/org/apache/felix/webconsole/internal/compendium/ConfigManager.java

Author: vvalchev
Date: Fri Jun  4 08:52:54 2010
New Revision: 951329

URL: http://svn.apache.org/viewvc?rev=951329&view=rev
Log:
Fixed FELIX-2390 /WebConsole Config Manager problem/
https://issues.apache.org/jira/browse/FELIX-2390

Modified:
    felix/trunk/webconsole/src/main/java/org/apache/felix/webconsole/internal/compendium/ConfigManager.java

Modified: felix/trunk/webconsole/src/main/java/org/apache/felix/webconsole/internal/compendium/ConfigManager.java
URL: http://svn.apache.org/viewvc/felix/trunk/webconsole/src/main/java/org/apache/felix/webconsole/internal/compendium/ConfigManager.java?rev=951329&r1=951328&r2=951329&view=diff
==============================================================================
--- felix/trunk/webconsole/src/main/java/org/apache/felix/webconsole/internal/compendium/ConfigManager.java (original)
+++ felix/trunk/webconsole/src/main/java/org/apache/felix/webconsole/internal/compendium/ConfigManager.java Fri Jun  4 08:52:54 2010
@@ -396,18 +396,23 @@ public class ConfigManager extends Confi
                 }
 
                 // insert and entry for the PID
-                ObjectClassDefinition ocd = this.getObjectClassDefinition(cfgs[i], locale);
-                String name;
-                if (ocd != null)
+                ObjectClassDefinition ocd = null;
+                try
                 {
-                    name = ocd.getName();
+                    ocd = this.getObjectClassDefinition(cfgs[i], locale);
                 }
-                else
+                catch (IllegalArgumentException t)
                 {
-                    name = pid;
+                    // MetaTypeProvider.getObjectClassDefinition might throw illegal 
+                    // argument exception. So we must catch it here, otherwise the
+                    // other configurations will not be shown
+                    // See https://issues.apache.org/jira/browse/FELIX-2390
                 }
 
-                optionsPlain.put(pid, name);
+                if (ocd != null)
+                {
+                    optionsPlain.put(pid, ocd.getName());
+                }
             }
 
             for (Iterator i = optionsPlain.keySet().iterator(); i.hasNext();)