You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@giraph.apache.org by "Jakob Homan (Created) (JIRA)" <ji...@apache.org> on 2012/04/07 22:58:15 UTC

[jira] [Created] (GIRAPH-179) BspServiceMaster's PathFilter can be simplified

BspServiceMaster's PathFilter can be simplified
-----------------------------------------------

                 Key: GIRAPH-179
                 URL: https://issues.apache.org/jira/browse/GIRAPH-179
             Project: Giraph
          Issue Type: Improvement
            Reporter: Jakob Homan
            Priority: Trivial


{code}  /**
   * Only get the finalized checkpoint files
   */
  public static class FinalizedCheckpointPathFilter implements PathFilter {
    @Override
    public boolean accept(Path path) {
      if (path.getName().endsWith(
          BspService.CHECKPOINT_FINALIZED_POSTFIX)) {
        return true;
      }
      return false;
    }
  }{code}
we can simplify this, eliminating the if statement and just returning the result of {{endsWith()}}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (GIRAPH-179) BspServiceMaster's PathFilter can be simplified

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/GIRAPH-179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13251940#comment-13251940 ] 

Hudson commented on GIRAPH-179:
-------------------------------

Integrated in Giraph-trunk-Commit #101 (See [https://builds.apache.org/job/Giraph-trunk-Commit/101/])
    GIRAPH-179: BspServiceMaster's PathFilter can be simplified. Contributed by Devaraj K. (Revision 1324991)

     Result = SUCCESS
jghoman : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1324991
Files : 
* /incubator/giraph/trunk/CHANGELOG
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/BspServiceMaster.java

                
> BspServiceMaster's PathFilter can be simplified
> -----------------------------------------------
>
>                 Key: GIRAPH-179
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-179
>             Project: Giraph
>          Issue Type: Improvement
>    Affects Versions: 0.2.0
>            Reporter: Jakob Homan
>            Assignee: Devaraj K
>            Priority: Trivial
>              Labels: newbie
>             Fix For: 0.2.0
>
>         Attachments: GIRAPH-179.patch
>
>
> {code}  /**
>    * Only get the finalized checkpoint files
>    */
>   public static class FinalizedCheckpointPathFilter implements PathFilter {
>     @Override
>     public boolean accept(Path path) {
>       if (path.getName().endsWith(
>           BspService.CHECKPOINT_FINALIZED_POSTFIX)) {
>         return true;
>       }
>       return false;
>     }
>   }{code}
> we can simplify this, eliminating the if statement and just returning the result of {{endsWith()}}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (GIRAPH-179) BspServiceMaster's PathFilter can be simplified

Posted by "Devaraj K (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/GIRAPH-179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Devaraj K updated GIRAPH-179:
-----------------------------

    Attachment: GIRAPH-179.patch
    
> BspServiceMaster's PathFilter can be simplified
> -----------------------------------------------
>
>                 Key: GIRAPH-179
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-179
>             Project: Giraph
>          Issue Type: Improvement
>    Affects Versions: 0.2.0
>            Reporter: Jakob Homan
>            Priority: Trivial
>              Labels: newbie
>         Attachments: GIRAPH-179.patch
>
>
> {code}  /**
>    * Only get the finalized checkpoint files
>    */
>   public static class FinalizedCheckpointPathFilter implements PathFilter {
>     @Override
>     public boolean accept(Path path) {
>       if (path.getName().endsWith(
>           BspService.CHECKPOINT_FINALIZED_POSTFIX)) {
>         return true;
>       }
>       return false;
>     }
>   }{code}
> we can simplify this, eliminating the if statement and just returning the result of {{endsWith()}}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira