You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@storm.apache.org by srdo <gi...@git.apache.org> on 2016/03/22 02:09:32 UTC

[GitHub] storm pull request: Made StormTimer join task thread on close

GitHub user srdo opened a pull request:

    https://github.com/apache/storm/pull/1244

    Made StormTimer join task thread on close

    Most tests creating a cluster can be flaky because the supervisor threads can terminate out of order. The StormTimer's close should block until the thread is dead.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/srdo/storm fix-timer-shutdown-race

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/1244.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1244
    
----
commit d93b2f272a6eea942702ab26c813c6a6d4d2af3f
Author: Stig Rohde Døssing <st...@gmail.com>
Date:   2016-03-22T01:04:53Z

    Made StormTimer join task thread on close

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: Make StormTimer join task thread on close

Posted by hustfxj <gi...@git.apache.org>.

Github user hustfxj commented on the pull request:

    https://github.com/apache/storm/pull/1244#issuecomment-200175487
  
    good, +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: Make StormTimer join task thread on close

Posted by knusbaum <gi...@git.apache.org>.

Github user knusbaum commented on the pull request:

    https://github.com/apache/storm/pull/1244#issuecomment-201009813
  
    +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: Make StormTimer join task thread on close

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/storm/pull/1244


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---