You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by ma...@apache.org on 2008/04/07 08:28:50 UTC

svn commit: r645395 - /httpd/httpd/trunk/server/request.c

Author: martin
Date: Sun Apr  6 23:28:50 2008
New Revision: 645395

URL: http://svn.apache.org/viewvc?rev=645395&view=rev
Log:
Make it compile on pre-C99 compilers (Move decls to beginning of func)

Modified:
    httpd/httpd/trunk/server/request.c

Modified: httpd/httpd/trunk/server/request.c
URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/server/request.c?rev=645395&r1=645394&r2=645395&view=diff
==============================================================================
--- httpd/httpd/trunk/server/request.c (original)
+++ httpd/httpd/trunk/server/request.c Sun Apr  6 23:28:50 2008
@@ -653,8 +653,6 @@
         char *buf;
         unsigned int seg, startseg;
 
-        cached &= auth_internal_per_conf;
-
         /* Invariant: from the first time filename_len is set until
          * it goes out of scope, filename_len==strlen(r->filename)
          */
@@ -662,6 +660,8 @@
 #ifdef CASE_BLIND_FILESYSTEM
         apr_size_t canonical_len;
 #endif
+
+        cached &= auth_internal_per_conf;
 
         /*
          * We must play our own mini-merge game here, for the few



Re: svn commit: r645395 - /httpd/httpd/trunk/server/request.c

Posted by Chris Darroch <ch...@pearsoncmg.com>.
martin@apache.org wrote:

> Make it compile on pre-C99 compilers (Move decls to beginning of func)

Joe Orton wrote:

> The ap_clear_auth_internal() definition doesn't match the way it's 
> called.

   Thanks, both.  Joe's checks in the past have taught me to use -Wall
religiously but apparently this time I did my final post-debugging tests
on a machine with an insufficiently recent gcc (but not sufficiently
old to catch the pre-C99 error).  Sorry about that; thanks again,

Chris.

-- 
GPG Key ID: 366A375B
GPG Key Fingerprint: 485E 5041 17E1 E2BB C263  E4DE C8E3 FA36 366A 375B


Re: svn commit: r645395 - /httpd/httpd/trunk/server/request.c

Posted by Chris Darroch <ch...@pearsoncmg.com>.
martin@apache.org wrote:

> Make it compile on pre-C99 compilers (Move decls to beginning of func)

Joe Orton wrote:

> The ap_clear_auth_internal() definition doesn't match the way it's 
> called.

   Thanks, both.  Joe's checks in the past have taught me to use -Wall
religiously but apparently this time I did my final post-debugging tests
on a machine with an insufficiently recent gcc (but not sufficiently
old to catch the pre-C99 error).  Sorry about that; thanks again,

Chris.

-- 
GPG Key ID: 366A375B
GPG Key Fingerprint: 485E 5041 17E1 E2BB C263  E4DE C8E3 FA36 366A 375B