You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Yurii Shylov <yu...@gmail.com> on 2014/11/05 20:15:45 UTC
Review Request 27635: Repository Version Management - Create API and
BE support for creating/retrieving repo versions
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27635/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate Cole.
Bugs: AMBARI-8164
https://issues.apache.org/jira/browse/AMBARI-8164
Repository: ambari
Description
-------
Create API and BE support for creating/retrieving repository versions
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/api/resources/RepositoryVersionResourceDefinition.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java c611191
ambari-server/src/main/java/org/apache/ambari/server/api/services/RepositoryVersionService.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 4f69dbb
ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java 52b0ba6
ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java a5f5b05
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java cb6c271
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java fe4729e
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RepositoryVersionDAO.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryVersionEntity.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog200.java 14c385d
ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 9054b3f
ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql abe8b39
ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 0bea067
ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql ebc8f5c
ambari-server/src/main/resources/META-INF/persistence.xml 2d8fedb
ambari-server/src/main/resources/key_properties.json c1a6636
ambari-server/src/main/resources/properties.json 36cff96
Diff: https://reviews.apache.org/r/27635/diff/
Testing
-------
Results :
Tests run: 2200, Failures: 0, Errors: 0, Skipped: 14
...
Total run: 684
Total errors:0
Total failures:0
Thanks,
Yurii Shylov
Re: Review Request 27635: Repository Version Management - Create API
and BE support for creating/retrieving repo versions
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
> On Nov. 5, 2014, 7:42 p.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java, lines 114-116
> > <https://reviews.apache.org/r/27635/diff/1/?file=750580#file750580line114>
> >
> > Not knowing how people will name repos, is it possible the same name can be used between stacks? What if they name it simply "2.3"?
FYI: some repos like HDP-UTILS seem to be shared between upgrade versions.
- Dmitro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27635/#review60003
-----------------------------------------------------------
On Nov. 5, 2014, 7:15 p.m., Yurii Shylov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27635/
> -----------------------------------------------------------
>
> (Updated Nov. 5, 2014, 7:15 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate Cole.
>
>
> Bugs: AMBARI-8164
> https://issues.apache.org/jira/browse/AMBARI-8164
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Create API and BE support for creating/retrieving repository versions
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/RepositoryVersionResourceDefinition.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java c611191
> ambari-server/src/main/java/org/apache/ambari/server/api/services/RepositoryVersionService.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 4f69dbb
> ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java 52b0ba6
> ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java a5f5b05
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java cb6c271
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java fe4729e
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RepositoryVersionDAO.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryVersionEntity.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog200.java 14c385d
> ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 9054b3f
> ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql abe8b39
> ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 0bea067
> ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql ebc8f5c
> ambari-server/src/main/resources/META-INF/persistence.xml 2d8fedb
> ambari-server/src/main/resources/key_properties.json c1a6636
> ambari-server/src/main/resources/properties.json 36cff96
>
> Diff: https://reviews.apache.org/r/27635/diff/
>
>
> Testing
> -------
>
> Results :
>
> Tests run: 2200, Failures: 0, Errors: 0, Skipped: 14
>
> ...
>
> Total run: 684
> Total errors:0
> Total failures:0
>
>
> Thanks,
>
> Yurii Shylov
>
>
Re: Review Request 27635: Repository Version Management - Create API
and BE support for creating/retrieving repo versions
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
> On Nov. 5, 2014, 7:42 p.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java, lines 114-116
> > <https://reviews.apache.org/r/27635/diff/1/?file=750580#file750580line114>
> >
> > Not knowing how people will name repos, is it possible the same name can be used between stacks? What if they name it simply "2.3"?
>
> Dmitro Lisnichenko wrote:
> FYI: some repos like HDP-UTILS seem to be shared between upgrade versions.
>
> Yurii Shylov wrote:
> We should encourage people to give meaningful names for repositories. Its name is the first thing they'll look at in UI, and if we allow duplicates for names, it will rize the probability to make a mistake.
> In this context display_name is the name of the whole repositories set, so it doesn't matter that HDP-UTILS will be the same.
Makes sense,
thanks
- Dmitro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27635/#review60003
-----------------------------------------------------------
On Nov. 6, 2014, 12:59 p.m., Yurii Shylov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27635/
> -----------------------------------------------------------
>
> (Updated Nov. 6, 2014, 12:59 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate Cole.
>
>
> Bugs: AMBARI-8164
> https://issues.apache.org/jira/browse/AMBARI-8164
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Create API and BE support for creating/retrieving repository versions
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/RepositoryVersionResourceDefinition.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java c611191
> ambari-server/src/main/java/org/apache/ambari/server/api/services/RepositoryVersionService.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java 52b0ba6
> ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java a5f5b05
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java cb6c271
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java fe4729e
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RepositoryVersionDAO.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryVersionEntity.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog200.java 14c385d
> ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 9054b3f
> ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql abe8b39
> ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 0bea067
> ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql ebc8f5c
> ambari-server/src/main/resources/META-INF/persistence.xml 2d8fedb
>
> Diff: https://reviews.apache.org/r/27635/diff/
>
>
> Testing
> -------
>
> Results :
>
> Tests run: 2200, Failures: 0, Errors: 0, Skipped: 14
>
> ...
>
> Total run: 684
> Total errors:0
> Total failures:0
>
>
> Thanks,
>
> Yurii Shylov
>
>
Re: Review Request 27635: Repository Version Management - Create API
and BE support for creating/retrieving repo versions
Posted by Yurii Shylov <yu...@gmail.com>.
> On Ноя. 5, 2014, 7:42 п.п., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java, lines 114-116
> > <https://reviews.apache.org/r/27635/diff/1/?file=750580#file750580line114>
> >
> > Not knowing how people will name repos, is it possible the same name can be used between stacks? What if they name it simply "2.3"?
>
> Dmitro Lisnichenko wrote:
> FYI: some repos like HDP-UTILS seem to be shared between upgrade versions.
We should encourage people to give meaningful names for repositories. Its name is the first thing they'll look at in UI, and if we allow duplicates for names, it will rize the probability to make a mistake.
In this context display_name is the name of the whole repositories set, so it doesn't matter that HDP-UTILS will be the same.
> On Ноя. 5, 2014, 7:42 п.п., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RepositoryVersionDAO.java, lines 56-60
> > <https://reviews.apache.org/r/27635/diff/1/?file=750582#file750582line56>
> >
> > Use daoUtils here - there's a convenience method that handles this for us
Fixed.
> On Ноя. 5, 2014, 7:42 п.п., Nate Cole wrote:
> > ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql, line 82
> > <https://reviews.apache.org/r/27635/diff/1/?file=750585#file750585line82>
> >
> > We'd like to stop one-lining definitions. See how the alert tables were defined.
Fixed.
> On Ноя. 5, 2014, 7:42 п.п., Nate Cole wrote:
> > ambari-server/src/main/resources/META-INF/persistence.xml, line 72
> > <https://reviews.apache.org/r/27635/diff/1/?file=750589#file750589line72>
> >
> > Keep these in alphabetic order
They were not sorted. Anyway, fixed, now they are.
> On Ноя. 5, 2014, 7:42 п.п., Nate Cole wrote:
> > ambari-server/src/main/resources/key_properties.json, lines 164-166
> > <https://reviews.apache.org/r/27635/diff/1/?file=750590#file750590line164>
> >
> > Do this in code instead. This file's use is no longer necessary.
Fixed.
> On Ноя. 5, 2014, 7:42 п.п., Nate Cole wrote:
> > ambari-server/src/main/resources/properties.json, lines 458-467
> > <https://reviews.apache.org/r/27635/diff/1/?file=750591#file750591line458>
> >
> > Do this in code instead. This file's use is no longer necessary.
Fixed.
- Yurii
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27635/#review60003
-----------------------------------------------------------
On Ноя. 6, 2014, 12:59 п.п., Yurii Shylov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27635/
> -----------------------------------------------------------
>
> (Updated Ноя. 6, 2014, 12:59 п.п.)
>
>
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate Cole.
>
>
> Bugs: AMBARI-8164
> https://issues.apache.org/jira/browse/AMBARI-8164
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Create API and BE support for creating/retrieving repository versions
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/RepositoryVersionResourceDefinition.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java c611191
> ambari-server/src/main/java/org/apache/ambari/server/api/services/RepositoryVersionService.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java 52b0ba6
> ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java a5f5b05
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java cb6c271
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java fe4729e
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RepositoryVersionDAO.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryVersionEntity.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog200.java 14c385d
> ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 9054b3f
> ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql abe8b39
> ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 0bea067
> ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql ebc8f5c
> ambari-server/src/main/resources/META-INF/persistence.xml 2d8fedb
>
> Diff: https://reviews.apache.org/r/27635/diff/
>
>
> Testing
> -------
>
> Results :
>
> Tests run: 2200, Failures: 0, Errors: 0, Skipped: 14
>
> ...
>
> Total run: 684
> Total errors:0
> Total failures:0
>
>
> Thanks,
>
> Yurii Shylov
>
>
Re: Review Request 27635: Repository Version Management - Create API
and BE support for creating/retrieving repo versions
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27635/#review60003
-----------------------------------------------------------
Looking good! Just some minor comments below.
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java
<https://reviews.apache.org/r/27635/#comment101341>
Not knowing how people will name repos, is it possible the same name can be used between stacks? What if they name it simply "2.3"?
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RepositoryVersionDAO.java
<https://reviews.apache.org/r/27635/#comment101343>
Use daoUtils here - there's a convenience method that handles this for us
ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql
<https://reviews.apache.org/r/27635/#comment101347>
We'd like to stop one-lining definitions. See how the alert tables were defined.
ambari-server/src/main/resources/META-INF/persistence.xml
<https://reviews.apache.org/r/27635/#comment101351>
Keep these in alphabetic order
ambari-server/src/main/resources/key_properties.json
<https://reviews.apache.org/r/27635/#comment101349>
Do this in code instead. This file's use is no longer necessary.
ambari-server/src/main/resources/properties.json
<https://reviews.apache.org/r/27635/#comment101350>
Do this in code instead. This file's use is no longer necessary.
- Nate Cole
On Nov. 5, 2014, 2:15 p.m., Yurii Shylov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27635/
> -----------------------------------------------------------
>
> (Updated Nov. 5, 2014, 2:15 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate Cole.
>
>
> Bugs: AMBARI-8164
> https://issues.apache.org/jira/browse/AMBARI-8164
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Create API and BE support for creating/retrieving repository versions
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/RepositoryVersionResourceDefinition.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java c611191
> ambari-server/src/main/java/org/apache/ambari/server/api/services/RepositoryVersionService.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 4f69dbb
> ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java 52b0ba6
> ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java a5f5b05
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java cb6c271
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java fe4729e
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RepositoryVersionDAO.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryVersionEntity.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog200.java 14c385d
> ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 9054b3f
> ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql abe8b39
> ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 0bea067
> ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql ebc8f5c
> ambari-server/src/main/resources/META-INF/persistence.xml 2d8fedb
> ambari-server/src/main/resources/key_properties.json c1a6636
> ambari-server/src/main/resources/properties.json 36cff96
>
> Diff: https://reviews.apache.org/r/27635/diff/
>
>
> Testing
> -------
>
> Results :
>
> Tests run: 2200, Failures: 0, Errors: 0, Skipped: 14
>
> ...
>
> Total run: 684
> Total errors:0
> Total failures:0
>
>
> Thanks,
>
> Yurii Shylov
>
>
Re: Review Request 27635: Repository Version Management - Create API
and BE support for creating/retrieving repo versions
Posted by Yurii Shylov <yu...@gmail.com>.
> On Ноя. 6, 2014, 1:10 п.п., Nate Cole wrote:
> > Please add unit tests as much as possible.
Fixed.
> On Ноя. 6, 2014, 1:10 п.п., Nate Cole wrote:
> > ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql, lines 82-85
> > <https://reviews.apache.org/r/27635/diff/2/?file=751554#file751554line82>
> >
> > Use _ for table name readability: repo_version. We're trying to make things a bit more readable.
Fixed.
- Yurii
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27635/#review60154
-----------------------------------------------------------
On Ноя. 6, 2014, 4:14 п.п., Yurii Shylov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27635/
> -----------------------------------------------------------
>
> (Updated Ноя. 6, 2014, 4:14 п.п.)
>
>
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate Cole.
>
>
> Bugs: AMBARI-8164
> https://issues.apache.org/jira/browse/AMBARI-8164
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Create API and BE support for creating/retrieving repository versions
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/RepositoryVersionResourceDefinition.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java c611191
> ambari-server/src/main/java/org/apache/ambari/server/api/services/RepositoryVersionService.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java 52b0ba6
> ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java a5f5b05
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java cb6c271
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java fe4729e
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RepositoryVersionDAO.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryVersionEntity.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog200.java 14c385d
> ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 9054b3f
> ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql abe8b39
> ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 0bea067
> ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql ebc8f5c
> ambari-server/src/main/resources/META-INF/persistence.xml 2d8fedb
> ambari-server/src/test/java/org/apache/ambari/server/api/resources/RepositoryVersionResourceDefinitionTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/api/services/RepositoryVersionServiceTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProviderTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/RepositoryVersionDAOTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/27635/diff/
>
>
> Testing
> -------
>
> Results :
>
> Tests run: 2200, Failures: 0, Errors: 0, Skipped: 14
>
> ...
>
> Total run: 684
> Total errors:0
> Total failures:0
>
>
> Thanks,
>
> Yurii Shylov
>
>
Re: Review Request 27635: Repository Version Management - Create API
and BE support for creating/retrieving repo versions
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27635/#review60154
-----------------------------------------------------------
Please add unit tests as much as possible.
ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql
<https://reviews.apache.org/r/27635/#comment101498>
Use _ for table name readability: repo_version. We're trying to make things a bit more readable.
- Nate Cole
On Nov. 6, 2014, 7:59 a.m., Yurii Shylov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27635/
> -----------------------------------------------------------
>
> (Updated Nov. 6, 2014, 7:59 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate Cole.
>
>
> Bugs: AMBARI-8164
> https://issues.apache.org/jira/browse/AMBARI-8164
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Create API and BE support for creating/retrieving repository versions
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/RepositoryVersionResourceDefinition.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java c611191
> ambari-server/src/main/java/org/apache/ambari/server/api/services/RepositoryVersionService.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java 52b0ba6
> ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java a5f5b05
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java cb6c271
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java fe4729e
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RepositoryVersionDAO.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryVersionEntity.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog200.java 14c385d
> ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 9054b3f
> ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql abe8b39
> ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 0bea067
> ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql ebc8f5c
> ambari-server/src/main/resources/META-INF/persistence.xml 2d8fedb
>
> Diff: https://reviews.apache.org/r/27635/diff/
>
>
> Testing
> -------
>
> Results :
>
> Tests run: 2200, Failures: 0, Errors: 0, Skipped: 14
>
> ...
>
> Total run: 684
> Total errors:0
> Total failures:0
>
>
> Thanks,
>
> Yurii Shylov
>
>
Re: Review Request 27635: Repository Version Management - Create API
and BE support for creating/retrieving repo versions
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27635/#review60175
-----------------------------------------------------------
Ship it!
Ship It!
- Nate Cole
On Nov. 6, 2014, 11:14 a.m., Yurii Shylov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27635/
> -----------------------------------------------------------
>
> (Updated Nov. 6, 2014, 11:14 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate Cole.
>
>
> Bugs: AMBARI-8164
> https://issues.apache.org/jira/browse/AMBARI-8164
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Create API and BE support for creating/retrieving repository versions
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/RepositoryVersionResourceDefinition.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java c611191
> ambari-server/src/main/java/org/apache/ambari/server/api/services/RepositoryVersionService.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java 52b0ba6
> ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java a5f5b05
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java cb6c271
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java fe4729e
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RepositoryVersionDAO.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryVersionEntity.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog200.java 14c385d
> ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 9054b3f
> ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql abe8b39
> ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 0bea067
> ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql ebc8f5c
> ambari-server/src/main/resources/META-INF/persistence.xml 2d8fedb
> ambari-server/src/test/java/org/apache/ambari/server/api/resources/RepositoryVersionResourceDefinitionTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/api/services/RepositoryVersionServiceTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProviderTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/RepositoryVersionDAOTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/27635/diff/
>
>
> Testing
> -------
>
> Results :
>
> Tests run: 2200, Failures: 0, Errors: 0, Skipped: 14
>
> ...
>
> Total run: 684
> Total errors:0
> Total failures:0
>
>
> Thanks,
>
> Yurii Shylov
>
>
Re: Review Request 27635: Repository Version Management - Create API
and BE support for creating/retrieving repo versions
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27635/#review60181
-----------------------------------------------------------
Ship it!
Ship It!
- Dmitro Lisnichenko
On Nov. 6, 2014, 4:14 p.m., Yurii Shylov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27635/
> -----------------------------------------------------------
>
> (Updated Nov. 6, 2014, 4:14 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate Cole.
>
>
> Bugs: AMBARI-8164
> https://issues.apache.org/jira/browse/AMBARI-8164
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Create API and BE support for creating/retrieving repository versions
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/RepositoryVersionResourceDefinition.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java c611191
> ambari-server/src/main/java/org/apache/ambari/server/api/services/RepositoryVersionService.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java 52b0ba6
> ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java a5f5b05
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java cb6c271
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java fe4729e
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RepositoryVersionDAO.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryVersionEntity.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog200.java 14c385d
> ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 9054b3f
> ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql abe8b39
> ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 0bea067
> ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql ebc8f5c
> ambari-server/src/main/resources/META-INF/persistence.xml 2d8fedb
> ambari-server/src/test/java/org/apache/ambari/server/api/resources/RepositoryVersionResourceDefinitionTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/api/services/RepositoryVersionServiceTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProviderTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/RepositoryVersionDAOTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/27635/diff/
>
>
> Testing
> -------
>
> Results :
>
> Tests run: 2200, Failures: 0, Errors: 0, Skipped: 14
>
> ...
>
> Total run: 684
> Total errors:0
> Total failures:0
>
>
> Thanks,
>
> Yurii Shylov
>
>
Re: Review Request 27635: Repository Version Management - Create API
and BE support for creating/retrieving repo versions
Posted by Yurii Shylov <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27635/
-----------------------------------------------------------
(Updated Ноя. 6, 2014, 4:14 п.п.)
Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate Cole.
Changes
-------
Add unit tests
Bugs: AMBARI-8164
https://issues.apache.org/jira/browse/AMBARI-8164
Repository: ambari
Description
-------
Create API and BE support for creating/retrieving repository versions
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/api/resources/RepositoryVersionResourceDefinition.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java c611191
ambari-server/src/main/java/org/apache/ambari/server/api/services/RepositoryVersionService.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java 52b0ba6
ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java a5f5b05
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java cb6c271
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java fe4729e
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RepositoryVersionDAO.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryVersionEntity.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog200.java 14c385d
ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 9054b3f
ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql abe8b39
ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 0bea067
ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql ebc8f5c
ambari-server/src/main/resources/META-INF/persistence.xml 2d8fedb
ambari-server/src/test/java/org/apache/ambari/server/api/resources/RepositoryVersionResourceDefinitionTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/api/services/RepositoryVersionServiceTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProviderTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/orm/dao/RepositoryVersionDAOTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/27635/diff/
Testing
-------
Results :
Tests run: 2200, Failures: 0, Errors: 0, Skipped: 14
...
Total run: 684
Total errors:0
Total failures:0
Thanks,
Yurii Shylov
Re: Review Request 27635: Repository Version Management - Create API
and BE support for creating/retrieving repo versions
Posted by Yurii Shylov <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27635/
-----------------------------------------------------------
(Updated Ноя. 6, 2014, 12:59 п.п.)
Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate Cole.
Changes
-------
Fixed reported issues
Bugs: AMBARI-8164
https://issues.apache.org/jira/browse/AMBARI-8164
Repository: ambari
Description
-------
Create API and BE support for creating/retrieving repository versions
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/api/resources/RepositoryVersionResourceDefinition.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java c611191
ambari-server/src/main/java/org/apache/ambari/server/api/services/RepositoryVersionService.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java 52b0ba6
ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java a5f5b05
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java cb6c271
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java fe4729e
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RepositoryVersionDAO.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryVersionEntity.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog200.java 14c385d
ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 9054b3f
ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql abe8b39
ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 0bea067
ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql ebc8f5c
ambari-server/src/main/resources/META-INF/persistence.xml 2d8fedb
Diff: https://reviews.apache.org/r/27635/diff/
Testing
-------
Results :
Tests run: 2200, Failures: 0, Errors: 0, Skipped: 14
...
Total run: 684
Total errors:0
Total failures:0
Thanks,
Yurii Shylov
Re: Review Request 27635: Repository Version Management - Create API
and BE support for creating/retrieving repo versions
Posted by Yurii Shylov <yu...@gmail.com>.
> On Ноя. 5, 2014, 9:40 п.п., Alejandro Fernandez wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java, line 121
> > <https://reviews.apache.org/r/27635/diff/1/?file=750580#file750580line121>
> >
> > Why return null?
Command is designed to return something in any case, it's pretty common across application to make it Void and return null.
> On Ноя. 5, 2014, 9:40 п.п., Alejandro Fernandez wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java, line 125
> > <https://reviews.apache.org/r/27635/diff/1/?file=750580#file750580line125>
> >
> > Should notifyCreate be called only if at least one property was found (which also implies all required properties exist)?
Right, fixed.
- Yurii
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27635/#review60039
-----------------------------------------------------------
On Ноя. 6, 2014, 12:59 п.п., Yurii Shylov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27635/
> -----------------------------------------------------------
>
> (Updated Ноя. 6, 2014, 12:59 п.п.)
>
>
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate Cole.
>
>
> Bugs: AMBARI-8164
> https://issues.apache.org/jira/browse/AMBARI-8164
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Create API and BE support for creating/retrieving repository versions
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/RepositoryVersionResourceDefinition.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java c611191
> ambari-server/src/main/java/org/apache/ambari/server/api/services/RepositoryVersionService.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java 52b0ba6
> ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java a5f5b05
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java cb6c271
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java fe4729e
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RepositoryVersionDAO.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryVersionEntity.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog200.java 14c385d
> ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 9054b3f
> ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql abe8b39
> ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 0bea067
> ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql ebc8f5c
> ambari-server/src/main/resources/META-INF/persistence.xml 2d8fedb
>
> Diff: https://reviews.apache.org/r/27635/diff/
>
>
> Testing
> -------
>
> Results :
>
> Tests run: 2200, Failures: 0, Errors: 0, Skipped: 14
>
> ...
>
> Total run: 684
> Total errors:0
> Total failures:0
>
>
> Thanks,
>
> Yurii Shylov
>
>
Re: Review Request 27635: Repository Version Management - Create API
and BE support for creating/retrieving repo versions
Posted by Yurii Shylov <yu...@gmail.com>.
> On Ноя. 5, 2014, 9:40 п.п., Alejandro Fernandez wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java, line 83
> > <https://reviews.apache.org/r/27635/diff/1/?file=750580#file750580line83>
> >
> > Please add javadoc wherever possible.
In this particular place there is no need for javadoc as it is overridden method. I've added javadocs in other places where it is applicable.
- Yurii
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27635/#review60039
-----------------------------------------------------------
On Ноя. 6, 2014, 12:59 п.п., Yurii Shylov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27635/
> -----------------------------------------------------------
>
> (Updated Ноя. 6, 2014, 12:59 п.п.)
>
>
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate Cole.
>
>
> Bugs: AMBARI-8164
> https://issues.apache.org/jira/browse/AMBARI-8164
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Create API and BE support for creating/retrieving repository versions
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/RepositoryVersionResourceDefinition.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java c611191
> ambari-server/src/main/java/org/apache/ambari/server/api/services/RepositoryVersionService.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java 52b0ba6
> ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java a5f5b05
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java cb6c271
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java fe4729e
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RepositoryVersionDAO.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryVersionEntity.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog200.java 14c385d
> ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 9054b3f
> ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql abe8b39
> ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 0bea067
> ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql ebc8f5c
> ambari-server/src/main/resources/META-INF/persistence.xml 2d8fedb
>
> Diff: https://reviews.apache.org/r/27635/diff/
>
>
> Testing
> -------
>
> Results :
>
> Tests run: 2200, Failures: 0, Errors: 0, Skipped: 14
>
> ...
>
> Total run: 684
> Total errors:0
> Total failures:0
>
>
> Thanks,
>
> Yurii Shylov
>
>
Re: Review Request 27635: Repository Version Management - Create API
and BE support for creating/retrieving repo versions
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27635/#review60039
-----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java
<https://reviews.apache.org/r/27635/#comment101379>
Please add javadoc wherever possible.
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java
<https://reviews.apache.org/r/27635/#comment101377>
Why return null?
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java
<https://reviews.apache.org/r/27635/#comment101376>
Should notifyCreate be called only if at least one property was found (which also implies all required properties exist)?
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog200.java
<https://reviews.apache.org/r/27635/#comment101387>
Should repoversion_id be a Long?
ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql
<https://reviews.apache.org/r/27635/#comment101388>
We should use VARCHAR2 for Oracle
- Alejandro Fernandez
On Nov. 5, 2014, 7:15 p.m., Yurii Shylov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27635/
> -----------------------------------------------------------
>
> (Updated Nov. 5, 2014, 7:15 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate Cole.
>
>
> Bugs: AMBARI-8164
> https://issues.apache.org/jira/browse/AMBARI-8164
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Create API and BE support for creating/retrieving repository versions
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/RepositoryVersionResourceDefinition.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java c611191
> ambari-server/src/main/java/org/apache/ambari/server/api/services/RepositoryVersionService.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 4f69dbb
> ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java 52b0ba6
> ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java a5f5b05
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java cb6c271
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java fe4729e
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RepositoryVersionDAO.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryVersionEntity.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog200.java 14c385d
> ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 9054b3f
> ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql abe8b39
> ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 0bea067
> ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql ebc8f5c
> ambari-server/src/main/resources/META-INF/persistence.xml 2d8fedb
> ambari-server/src/main/resources/key_properties.json c1a6636
> ambari-server/src/main/resources/properties.json 36cff96
>
> Diff: https://reviews.apache.org/r/27635/diff/
>
>
> Testing
> -------
>
> Results :
>
> Tests run: 2200, Failures: 0, Errors: 0, Skipped: 14
>
> ...
>
> Total run: 684
> Total errors:0
> Total failures:0
>
>
> Thanks,
>
> Yurii Shylov
>
>