You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/03/08 07:38:40 UTC

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #35751: [SPARK-38433][BUILD] Add shell code style check Actions

dongjoon-hyun commented on a change in pull request #35751:
URL: https://github.com/apache/spark/pull/35751#discussion_r821394294



##########
File path: sbin/spark-config.sh
##########
@@ -1,3 +1,5 @@
+#!/usr/bin/env bash

Review comment:
       Is this a safe change, @stczwd ? This looks like that we need to handle in a separate PR, not in this SPARK-38433, to give a proper visibility.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org