You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/02/08 08:33:01 UTC

[GitHub] [spark] LuciferYang opened a new pull request #35435: [MINOR][SQL] Remove redundant array creation in UnsafeRow

LuciferYang opened a new pull request #35435:
URL: https://github.com/apache/spark/pull/35435


   ### What changes were proposed in this pull request?
   `j.u.Arrays.asList` is a varargs method, this pr remove the redundant array creation to simplify the code.
   
   
   ### Why are the changes needed?
   Code simplification.
   
   
   ### Does this PR introduce _any_ user-facing change?
   No
   
   
   ### How was this patch tested?
   Pass GA


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] sarutak closed pull request #35435: [MINOR][SQL] Remove redundant array creation in UnsafeRow

Posted by GitBox <gi...@apache.org>.
sarutak closed pull request #35435:
URL: https://github.com/apache/spark/pull/35435


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] LuciferYang commented on pull request #35435: [MINOR][SQL] Remove redundant array creation in UnsafeRow

Posted by GitBox <gi...@apache.org>.
LuciferYang commented on pull request #35435:
URL: https://github.com/apache/spark/pull/35435#issuecomment-1032357054


   Only one place, so I didn't create new jira
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] sarutak commented on pull request #35435: [MINOR][SQL] Remove redundant array creation in UnsafeRow

Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #35435:
URL: https://github.com/apache/spark/pull/35435#issuecomment-1032806307


   Merged to `master`. Thanks all !


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org