You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "nkeywal (Created) (JIRA)" <ji...@apache.org> on 2011/12/05 19:12:39 UTC

[jira] [Created] (HBASE-4955) Use the official versions of surefire & junit

Use the official versions of surefire & junit
---------------------------------------------

                 Key: HBASE-4955
                 URL: https://issues.apache.org/jira/browse/HBASE-4955
             Project: HBase
          Issue Type: Improvement
          Components: test
    Affects Versions: 0.94.0
         Environment: all
            Reporter: nkeywal
            Assignee: nkeywal
            Priority: Minor


We currently use private versions for Surefire & JUnit since HBASE-4763.

This JIRA traks what we need to move to official versions.

Surefire 2.11 is just out, but, after some tests, it does not contain all what we need.

JUnit. Could be for JUnit 4.11. Issue to monitor:
https://github.com/KentBeck/junit/issues/359: fixed in our version, no feedback for an integration on trunk

Surefire: Could be for Surefire 2.12. Issues to monitor are:
329 (category support): fixed, we use the official implementation from the trunk
786 (@Category with forkMode=always): fixed, we use the official implementation from the trunk
791 (incorrect elapsed time on test failure): fixed, we use the official implementation from the trunk
793 (incorrect time in the XML report): Not fixed (reopen) on trunk, fixed on our version.
760 (does not take into account the test method): fixed in trunk, not fixed in our version
798 (print immediately the test class name): not fixed in trunk, not fixed in our version
799 (Allow test parallelization when forkMode=always): not fixed in trunk, not fixed in our version
800 (redirectTestOutputToFile not taken into account): not yet fix on trunk, fixed on our version

800 & 793 are the more important to monitor, it's the only ones that are fixed in our version but not on trunk.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-4955) Use the official versions of surefire & junit

Posted by "nkeywal (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13477031#comment-13477031 ] 

nkeywal commented on HBASE-4955:
--------------------------------

>From JUnit mailing list (15th oct) ??I am happy to announce the release of JUnit 4.11-beta-1. There have been a lot of contributions by a full cast of contributors.?? So we will have the release this quarter with some luck.
Surefire: Still waiting for #800. May be it will make it to the 2.13. No date.
                
> Use the official versions of surefire & junit
> ---------------------------------------------
>
>                 Key: HBASE-4955
>                 URL: https://issues.apache.org/jira/browse/HBASE-4955
>             Project: HBase
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 0.94.0
>         Environment: all
>            Reporter: nkeywal
>            Assignee: nkeywal
>            Priority: Minor
>
> We currently use private versions for Surefire & JUnit since HBASE-4763.
> This JIRA traks what we need to move to official versions.
> Surefire 2.11 is just out, but, after some tests, it does not contain all what we need.
> JUnit. Could be for JUnit 4.11. Issue to monitor:
> https://github.com/KentBeck/junit/issues/359: fixed in our version, no feedback for an integration on trunk
> Surefire: Could be for Surefire 2.12. Issues to monitor are:
> 329 (category support): fixed, we use the official implementation from the trunk
> 786 (@Category with forkMode=always): fixed, we use the official implementation from the trunk
> 791 (incorrect elapsed time on test failure): fixed, we use the official implementation from the trunk
> 793 (incorrect time in the XML report): Not fixed (reopen) on trunk, fixed on our version.
> 760 (does not take into account the test method): fixed in trunk, not fixed in our version
> 798 (print immediately the test class name): not fixed in trunk, not fixed in our version
> 799 (Allow test parallelization when forkMode=always): not fixed in trunk, not fixed in our version
> 800 (redirectTestOutputToFile not taken into account): not yet fix on trunk, fixed on our version
> 800 & 793 are the more important to monitor, it's the only ones that are fixed in our version but not on trunk.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-4955) Use the official versions of surefire & junit

Posted by "stack (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13440495#comment-13440495 ] 

stack commented on HBASE-4955:
------------------------------

Thanks for update.  I'd say if 2.13 works even though we have to move a good few tests to medium, lets use it so we can undo our dependency on custom surefire.  Good on you N.
                
> Use the official versions of surefire & junit
> ---------------------------------------------
>
>                 Key: HBASE-4955
>                 URL: https://issues.apache.org/jira/browse/HBASE-4955
>             Project: HBase
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 0.94.0
>         Environment: all
>            Reporter: nkeywal
>            Assignee: nkeywal
>            Priority: Minor
>
> We currently use private versions for Surefire & JUnit since HBASE-4763.
> This JIRA traks what we need to move to official versions.
> Surefire 2.11 is just out, but, after some tests, it does not contain all what we need.
> JUnit. Could be for JUnit 4.11. Issue to monitor:
> https://github.com/KentBeck/junit/issues/359: fixed in our version, no feedback for an integration on trunk
> Surefire: Could be for Surefire 2.12. Issues to monitor are:
> 329 (category support): fixed, we use the official implementation from the trunk
> 786 (@Category with forkMode=always): fixed, we use the official implementation from the trunk
> 791 (incorrect elapsed time on test failure): fixed, we use the official implementation from the trunk
> 793 (incorrect time in the XML report): Not fixed (reopen) on trunk, fixed on our version.
> 760 (does not take into account the test method): fixed in trunk, not fixed in our version
> 798 (print immediately the test class name): not fixed in trunk, not fixed in our version
> 799 (Allow test parallelization when forkMode=always): not fixed in trunk, not fixed in our version
> 800 (redirectTestOutputToFile not taken into account): not yet fix on trunk, fixed on our version
> 800 & 793 are the more important to monitor, it's the only ones that are fixed in our version but not on trunk.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-4955) Use the official versions of surefire & junit

Posted by "nkeywal (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13498287#comment-13498287 ] 

nkeywal commented on HBASE-4955:
--------------------------------

Junit 4.11 is now available (wow!). Let's test it on trunk (locally it's ok), I will backport to 0.94 if it's ok.
                
> Use the official versions of surefire & junit
> ---------------------------------------------
>
>                 Key: HBASE-4955
>                 URL: https://issues.apache.org/jira/browse/HBASE-4955
>             Project: HBase
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 0.94.0
>         Environment: all
>            Reporter: nkeywal
>            Assignee: nkeywal
>            Priority: Minor
>             Fix For: 0.96.0
>
>         Attachments: 4955.v1.patch
>
>
> We currently use private versions for Surefire & JUnit since HBASE-4763.
> This JIRA traks what we need to move to official versions.
> Surefire 2.11 is just out, but, after some tests, it does not contain all what we need.
> JUnit. Could be for JUnit 4.11. Issue to monitor:
> https://github.com/KentBeck/junit/issues/359: fixed in our version, no feedback for an integration on trunk
> Surefire: Could be for Surefire 2.12. Issues to monitor are:
> 329 (category support): fixed, we use the official implementation from the trunk
> 786 (@Category with forkMode=always): fixed, we use the official implementation from the trunk
> 791 (incorrect elapsed time on test failure): fixed, we use the official implementation from the trunk
> 793 (incorrect time in the XML report): Not fixed (reopen) on trunk, fixed on our version.
> 760 (does not take into account the test method): fixed in trunk, not fixed in our version
> 798 (print immediately the test class name): not fixed in trunk, not fixed in our version
> 799 (Allow test parallelization when forkMode=always): not fixed in trunk, not fixed in our version
> 800 (redirectTestOutputToFile not taken into account): not yet fix on trunk, fixed on our version
> 800 & 793 are the more important to monitor, it's the only ones that are fixed in our version but not on trunk.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-4955) Use the official versions of surefire & junit

Posted by "stack (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13510567#comment-13510567 ] 

stack commented on HBASE-4955:
------------------------------

If just two test failures, I'm inclined to think it flakey tests rather than junit version and that we should move to junit 4.11 and fix the tests
                
> Use the official versions of surefire & junit
> ---------------------------------------------
>
>                 Key: HBASE-4955
>                 URL: https://issues.apache.org/jira/browse/HBASE-4955
>             Project: HBase
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 0.94.0
>         Environment: all
>            Reporter: nkeywal
>            Assignee: nkeywal
>            Priority: Minor
>             Fix For: 0.96.0
>
>         Attachments: 4955.v1.patch, 4955.v2.patch, 4955.v2.patch
>
>
> We currently use private versions for Surefire & JUnit since HBASE-4763.
> This JIRA traks what we need to move to official versions.
> Surefire 2.11 is just out, but, after some tests, it does not contain all what we need.
> JUnit. Could be for JUnit 4.11. Issue to monitor:
> https://github.com/KentBeck/junit/issues/359: fixed in our version, no feedback for an integration on trunk
> Surefire: Could be for Surefire 2.12. Issues to monitor are:
> 329 (category support): fixed, we use the official implementation from the trunk
> 786 (@Category with forkMode=always): fixed, we use the official implementation from the trunk
> 791 (incorrect elapsed time on test failure): fixed, we use the official implementation from the trunk
> 793 (incorrect time in the XML report): Not fixed (reopen) on trunk, fixed on our version.
> 760 (does not take into account the test method): fixed in trunk, not fixed in our version
> 798 (print immediately the test class name): not fixed in trunk, not fixed in our version
> 799 (Allow test parallelization when forkMode=always): not fixed in trunk, not fixed in our version
> 800 (redirectTestOutputToFile not taken into account): not yet fix on trunk, fixed on our version
> 800 & 793 are the more important to monitor, it's the only ones that are fixed in our version but not on trunk.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-4955) Use the official versions of surefire & junit

Posted by "nkeywal (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-4955?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

nkeywal updated HBASE-4955:
---------------------------

    Attachment: 4955.v1.patch
    
> Use the official versions of surefire & junit
> ---------------------------------------------
>
>                 Key: HBASE-4955
>                 URL: https://issues.apache.org/jira/browse/HBASE-4955
>             Project: HBase
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 0.94.0
>         Environment: all
>            Reporter: nkeywal
>            Assignee: nkeywal
>            Priority: Minor
>         Attachments: 4955.v1.patch
>
>
> We currently use private versions for Surefire & JUnit since HBASE-4763.
> This JIRA traks what we need to move to official versions.
> Surefire 2.11 is just out, but, after some tests, it does not contain all what we need.
> JUnit. Could be for JUnit 4.11. Issue to monitor:
> https://github.com/KentBeck/junit/issues/359: fixed in our version, no feedback for an integration on trunk
> Surefire: Could be for Surefire 2.12. Issues to monitor are:
> 329 (category support): fixed, we use the official implementation from the trunk
> 786 (@Category with forkMode=always): fixed, we use the official implementation from the trunk
> 791 (incorrect elapsed time on test failure): fixed, we use the official implementation from the trunk
> 793 (incorrect time in the XML report): Not fixed (reopen) on trunk, fixed on our version.
> 760 (does not take into account the test method): fixed in trunk, not fixed in our version
> 798 (print immediately the test class name): not fixed in trunk, not fixed in our version
> 799 (Allow test parallelization when forkMode=always): not fixed in trunk, not fixed in our version
> 800 (redirectTestOutputToFile not taken into account): not yet fix on trunk, fixed on our version
> 800 & 793 are the more important to monitor, it's the only ones that are fixed in our version but not on trunk.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-4955) Use the official versions of surefire & junit

Posted by "stack (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13498477#comment-13498477 ] 

stack commented on HBASE-4955:
------------------------------

@nkeywal That'd be sweet undoing one of our custom dependencies
                
> Use the official versions of surefire & junit
> ---------------------------------------------
>
>                 Key: HBASE-4955
>                 URL: https://issues.apache.org/jira/browse/HBASE-4955
>             Project: HBase
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 0.94.0
>         Environment: all
>            Reporter: nkeywal
>            Assignee: nkeywal
>            Priority: Minor
>             Fix For: 0.96.0
>
>         Attachments: 4955.v1.patch
>
>
> We currently use private versions for Surefire & JUnit since HBASE-4763.
> This JIRA traks what we need to move to official versions.
> Surefire 2.11 is just out, but, after some tests, it does not contain all what we need.
> JUnit. Could be for JUnit 4.11. Issue to monitor:
> https://github.com/KentBeck/junit/issues/359: fixed in our version, no feedback for an integration on trunk
> Surefire: Could be for Surefire 2.12. Issues to monitor are:
> 329 (category support): fixed, we use the official implementation from the trunk
> 786 (@Category with forkMode=always): fixed, we use the official implementation from the trunk
> 791 (incorrect elapsed time on test failure): fixed, we use the official implementation from the trunk
> 793 (incorrect time in the XML report): Not fixed (reopen) on trunk, fixed on our version.
> 760 (does not take into account the test method): fixed in trunk, not fixed in our version
> 798 (print immediately the test class name): not fixed in trunk, not fixed in our version
> 799 (Allow test parallelization when forkMode=always): not fixed in trunk, not fixed in our version
> 800 (redirectTestOutputToFile not taken into account): not yet fix on trunk, fixed on our version
> 800 & 793 are the more important to monitor, it's the only ones that are fixed in our version but not on trunk.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-4955) Use the official versions of surefire & junit

Posted by "nkeywal (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-4955?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

nkeywal updated HBASE-4955:
---------------------------

    Status: Open  (was: Patch Available)
    
> Use the official versions of surefire & junit
> ---------------------------------------------
>
>                 Key: HBASE-4955
>                 URL: https://issues.apache.org/jira/browse/HBASE-4955
>             Project: HBase
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 0.94.0
>         Environment: all
>            Reporter: nkeywal
>            Assignee: nkeywal
>            Priority: Minor
>             Fix For: 0.96.0
>
>         Attachments: 4955.v1.patch, 4955.v2.patch, 4955.v2.patch
>
>
> We currently use private versions for Surefire & JUnit since HBASE-4763.
> This JIRA traks what we need to move to official versions.
> Surefire 2.11 is just out, but, after some tests, it does not contain all what we need.
> JUnit. Could be for JUnit 4.11. Issue to monitor:
> https://github.com/KentBeck/junit/issues/359: fixed in our version, no feedback for an integration on trunk
> Surefire: Could be for Surefire 2.12. Issues to monitor are:
> 329 (category support): fixed, we use the official implementation from the trunk
> 786 (@Category with forkMode=always): fixed, we use the official implementation from the trunk
> 791 (incorrect elapsed time on test failure): fixed, we use the official implementation from the trunk
> 793 (incorrect time in the XML report): Not fixed (reopen) on trunk, fixed on our version.
> 760 (does not take into account the test method): fixed in trunk, not fixed in our version
> 798 (print immediately the test class name): not fixed in trunk, not fixed in our version
> 799 (Allow test parallelization when forkMode=always): not fixed in trunk, not fixed in our version
> 800 (redirectTestOutputToFile not taken into account): not yet fix on trunk, fixed on our version
> 800 & 793 are the more important to monitor, it's the only ones that are fixed in our version but not on trunk.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-4955) Use the official versions of surefire & junit

Posted by "nkeywal (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13427894#comment-13427894 ] 

nkeywal commented on HBASE-4955:
--------------------------------

There is a new surefire 2.12.1 version. It fixes the regression #827, #800 is reopened. Our fix is different, but I suppose that if I didn't propose my fix it was for a good reason. I will need to have a look at this. Will wait a little however to see if someone fixes it. And anyway this new version could contain new regressions, so there is no reasons to be the first users.

They're adding stuff into JUnit, so hopefully their will deliver something soon and it won't contain regressions...


                
> Use the official versions of surefire & junit
> ---------------------------------------------
>
>                 Key: HBASE-4955
>                 URL: https://issues.apache.org/jira/browse/HBASE-4955
>             Project: HBase
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 0.94.0
>         Environment: all
>            Reporter: nkeywal
>            Assignee: nkeywal
>            Priority: Minor
>
> We currently use private versions for Surefire & JUnit since HBASE-4763.
> This JIRA traks what we need to move to official versions.
> Surefire 2.11 is just out, but, after some tests, it does not contain all what we need.
> JUnit. Could be for JUnit 4.11. Issue to monitor:
> https://github.com/KentBeck/junit/issues/359: fixed in our version, no feedback for an integration on trunk
> Surefire: Could be for Surefire 2.12. Issues to monitor are:
> 329 (category support): fixed, we use the official implementation from the trunk
> 786 (@Category with forkMode=always): fixed, we use the official implementation from the trunk
> 791 (incorrect elapsed time on test failure): fixed, we use the official implementation from the trunk
> 793 (incorrect time in the XML report): Not fixed (reopen) on trunk, fixed on our version.
> 760 (does not take into account the test method): fixed in trunk, not fixed in our version
> 798 (print immediately the test class name): not fixed in trunk, not fixed in our version
> 799 (Allow test parallelization when forkMode=always): not fixed in trunk, not fixed in our version
> 800 (redirectTestOutputToFile not taken into account): not yet fix on trunk, fixed on our version
> 800 & 793 are the more important to monitor, it's the only ones that are fixed in our version but not on trunk.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-4955) Use the official versions of surefire & junit

Posted by "nkeywal (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13177644#comment-13177644 ] 

nkeywal commented on HBASE-4955:
--------------------------------

We're now using 2.12-TRUNK-HBASE-2.

It's a private version, built on the 2.12 trunk (i.e.: it does not contain eveyrthing that will be in 2.12 final).

Surefire: Could be for Surefire 2.12. Issues to monitor are:
329 (category support): fixed, we use the official implementation from the trunk
773 (forked processes not killed after timeout): not fixed in trunk, not fixed in our version
786 (@Category with forkMode=always): fixed, we use the official implementation from the trunk
791 (incorrect elapsed time on test failure): fixed, we use the official implementation from the trunk
793 (incorrect time in the XML report): Not fixed (reopen) in trunk, partial fixed in our version.
760 (does not take into account the test method): fixed, we use the official implementation from the trunk
798 (print immediately the test class name): not fixed in trunk, not fixed in our version
799 (Allow test parallelization when forkMode=always): fixed in trunk, fixed in our version with some minimal differences.
800 (redirectTestOutputToFile not taken into account): not yet fix on trunk, fixed in our version
806 (Ignore selection criteria when -Dtest= is specified):  not fixed in trunk, not fixed in our version
813 (Randomly wrong tests count and empty summary files): fixed in trunk, fixed in our version 

800 & 793 are the more important to monitor, it's the only ones that are fixed in our version but not on trunk.
                
> Use the official versions of surefire & junit
> ---------------------------------------------
>
>                 Key: HBASE-4955
>                 URL: https://issues.apache.org/jira/browse/HBASE-4955
>             Project: HBase
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 0.94.0
>         Environment: all
>            Reporter: nkeywal
>            Assignee: nkeywal
>            Priority: Minor
>
> We currently use private versions for Surefire & JUnit since HBASE-4763.
> This JIRA traks what we need to move to official versions.
> Surefire 2.11 is just out, but, after some tests, it does not contain all what we need.
> JUnit. Could be for JUnit 4.11. Issue to monitor:
> https://github.com/KentBeck/junit/issues/359: fixed in our version, no feedback for an integration on trunk
> Surefire: Could be for Surefire 2.12. Issues to monitor are:
> 329 (category support): fixed, we use the official implementation from the trunk
> 786 (@Category with forkMode=always): fixed, we use the official implementation from the trunk
> 791 (incorrect elapsed time on test failure): fixed, we use the official implementation from the trunk
> 793 (incorrect time in the XML report): Not fixed (reopen) on trunk, fixed on our version.
> 760 (does not take into account the test method): fixed in trunk, not fixed in our version
> 798 (print immediately the test class name): not fixed in trunk, not fixed in our version
> 799 (Allow test parallelization when forkMode=always): not fixed in trunk, not fixed in our version
> 800 (redirectTestOutputToFile not taken into account): not yet fix on trunk, fixed on our version
> 800 & 793 are the more important to monitor, it's the only ones that are fixed in our version but not on trunk.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-4955) Use the official versions of surefire & junit

Posted by "nkeywal (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-4955?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

nkeywal updated HBASE-4955:
---------------------------

    Fix Version/s: 0.96.0
           Status: Patch Available  (was: Open)
    
> Use the official versions of surefire & junit
> ---------------------------------------------
>
>                 Key: HBASE-4955
>                 URL: https://issues.apache.org/jira/browse/HBASE-4955
>             Project: HBase
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 0.94.0
>         Environment: all
>            Reporter: nkeywal
>            Assignee: nkeywal
>            Priority: Minor
>             Fix For: 0.96.0
>
>         Attachments: 4955.v1.patch
>
>
> We currently use private versions for Surefire & JUnit since HBASE-4763.
> This JIRA traks what we need to move to official versions.
> Surefire 2.11 is just out, but, after some tests, it does not contain all what we need.
> JUnit. Could be for JUnit 4.11. Issue to monitor:
> https://github.com/KentBeck/junit/issues/359: fixed in our version, no feedback for an integration on trunk
> Surefire: Could be for Surefire 2.12. Issues to monitor are:
> 329 (category support): fixed, we use the official implementation from the trunk
> 786 (@Category with forkMode=always): fixed, we use the official implementation from the trunk
> 791 (incorrect elapsed time on test failure): fixed, we use the official implementation from the trunk
> 793 (incorrect time in the XML report): Not fixed (reopen) on trunk, fixed on our version.
> 760 (does not take into account the test method): fixed in trunk, not fixed in our version
> 798 (print immediately the test class name): not fixed in trunk, not fixed in our version
> 799 (Allow test parallelization when forkMode=always): not fixed in trunk, not fixed in our version
> 800 (redirectTestOutputToFile not taken into account): not yet fix on trunk, fixed on our version
> 800 & 793 are the more important to monitor, it's the only ones that are fixed in our version but not on trunk.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-4955) Use the official versions of surefire & junit

Posted by "Ryan Hennig (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13444526#comment-13444526 ] 

Ryan Hennig commented on HBASE-4955:
------------------------------------

With surefire 2.12, we are getting a build error on our Jenkins server with message "Error occurred in starting fork". 
This appears to be due to SUREFIRE-870, which is fixed in 2.12.1 and above.  We are currently experimenting with surefire 2.12.3 to get build working.
                
> Use the official versions of surefire & junit
> ---------------------------------------------
>
>                 Key: HBASE-4955
>                 URL: https://issues.apache.org/jira/browse/HBASE-4955
>             Project: HBase
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 0.94.0
>         Environment: all
>            Reporter: nkeywal
>            Assignee: nkeywal
>            Priority: Minor
>
> We currently use private versions for Surefire & JUnit since HBASE-4763.
> This JIRA traks what we need to move to official versions.
> Surefire 2.11 is just out, but, after some tests, it does not contain all what we need.
> JUnit. Could be for JUnit 4.11. Issue to monitor:
> https://github.com/KentBeck/junit/issues/359: fixed in our version, no feedback for an integration on trunk
> Surefire: Could be for Surefire 2.12. Issues to monitor are:
> 329 (category support): fixed, we use the official implementation from the trunk
> 786 (@Category with forkMode=always): fixed, we use the official implementation from the trunk
> 791 (incorrect elapsed time on test failure): fixed, we use the official implementation from the trunk
> 793 (incorrect time in the XML report): Not fixed (reopen) on trunk, fixed on our version.
> 760 (does not take into account the test method): fixed in trunk, not fixed in our version
> 798 (print immediately the test class name): not fixed in trunk, not fixed in our version
> 799 (Allow test parallelization when forkMode=always): not fixed in trunk, not fixed in our version
> 800 (redirectTestOutputToFile not taken into account): not yet fix on trunk, fixed on our version
> 800 & 793 are the more important to monitor, it's the only ones that are fixed in our version but not on trunk.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-4955) Use the official versions of surefire & junit

Posted by "nkeywal (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13406429#comment-13406429 ] 

nkeywal commented on HBASE-4955:
--------------------------------

Update: Still waiting. There is some life on Surefire, for JUnit there won't be anything before Q4 I guess.
                
> Use the official versions of surefire & junit
> ---------------------------------------------
>
>                 Key: HBASE-4955
>                 URL: https://issues.apache.org/jira/browse/HBASE-4955
>             Project: HBase
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 0.94.0
>         Environment: all
>            Reporter: nkeywal
>            Assignee: nkeywal
>            Priority: Minor
>
> We currently use private versions for Surefire & JUnit since HBASE-4763.
> This JIRA traks what we need to move to official versions.
> Surefire 2.11 is just out, but, after some tests, it does not contain all what we need.
> JUnit. Could be for JUnit 4.11. Issue to monitor:
> https://github.com/KentBeck/junit/issues/359: fixed in our version, no feedback for an integration on trunk
> Surefire: Could be for Surefire 2.12. Issues to monitor are:
> 329 (category support): fixed, we use the official implementation from the trunk
> 786 (@Category with forkMode=always): fixed, we use the official implementation from the trunk
> 791 (incorrect elapsed time on test failure): fixed, we use the official implementation from the trunk
> 793 (incorrect time in the XML report): Not fixed (reopen) on trunk, fixed on our version.
> 760 (does not take into account the test method): fixed in trunk, not fixed in our version
> 798 (print immediately the test class name): not fixed in trunk, not fixed in our version
> 799 (Allow test parallelization when forkMode=always): not fixed in trunk, not fixed in our version
> 800 (redirectTestOutputToFile not taken into account): not yet fix on trunk, fixed on our version
> 800 & 793 are the more important to monitor, it's the only ones that are fixed in our version but not on trunk.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-4955) Use the official versions of surefire & junit

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13498906#comment-13498906 ] 

Hadoop QA commented on HBASE-4955:
----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12553786/4955.v2.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 hadoop2.0{color}.  The patch compiles against the hadoop 2.0 profile.

    {color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 99 warning messages.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:red}-1 findbugs{color}.  The patch appears to introduce 24 new Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.client.TestMultiParallel
                  org.apache.hadoop.hbase.client.TestAdmin
                  org.apache.hadoop.hbase.master.TestSplitLogManager
                  org.apache.hadoop.hbase.TestZooKeeper

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3354//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3354//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3354//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3354//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3354//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3354//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3354//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3354//console

This message is automatically generated.
                
> Use the official versions of surefire & junit
> ---------------------------------------------
>
>                 Key: HBASE-4955
>                 URL: https://issues.apache.org/jira/browse/HBASE-4955
>             Project: HBase
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 0.94.0
>         Environment: all
>            Reporter: nkeywal
>            Assignee: nkeywal
>            Priority: Minor
>             Fix For: 0.96.0
>
>         Attachments: 4955.v1.patch, 4955.v2.patch, 4955.v2.patch
>
>
> We currently use private versions for Surefire & JUnit since HBASE-4763.
> This JIRA traks what we need to move to official versions.
> Surefire 2.11 is just out, but, after some tests, it does not contain all what we need.
> JUnit. Could be for JUnit 4.11. Issue to monitor:
> https://github.com/KentBeck/junit/issues/359: fixed in our version, no feedback for an integration on trunk
> Surefire: Could be for Surefire 2.12. Issues to monitor are:
> 329 (category support): fixed, we use the official implementation from the trunk
> 786 (@Category with forkMode=always): fixed, we use the official implementation from the trunk
> 791 (incorrect elapsed time on test failure): fixed, we use the official implementation from the trunk
> 793 (incorrect time in the XML report): Not fixed (reopen) on trunk, fixed on our version.
> 760 (does not take into account the test method): fixed in trunk, not fixed in our version
> 798 (print immediately the test class name): not fixed in trunk, not fixed in our version
> 799 (Allow test parallelization when forkMode=always): not fixed in trunk, not fixed in our version
> 800 (redirectTestOutputToFile not taken into account): not yet fix on trunk, fixed on our version
> 800 & 793 are the more important to monitor, it's the only ones that are fixed in our version but not on trunk.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-4955) Use the official versions of surefire & junit

Posted by "nkeywal (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13498910#comment-13498910 ] 

nkeywal commented on HBASE-4955:
--------------------------------

This is annoying: 3 times the same errors. I'm gonna wait a little. Will retry in a week or so.
                
> Use the official versions of surefire & junit
> ---------------------------------------------
>
>                 Key: HBASE-4955
>                 URL: https://issues.apache.org/jira/browse/HBASE-4955
>             Project: HBase
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 0.94.0
>         Environment: all
>            Reporter: nkeywal
>            Assignee: nkeywal
>            Priority: Minor
>             Fix For: 0.96.0
>
>         Attachments: 4955.v1.patch, 4955.v2.patch, 4955.v2.patch
>
>
> We currently use private versions for Surefire & JUnit since HBASE-4763.
> This JIRA traks what we need to move to official versions.
> Surefire 2.11 is just out, but, after some tests, it does not contain all what we need.
> JUnit. Could be for JUnit 4.11. Issue to monitor:
> https://github.com/KentBeck/junit/issues/359: fixed in our version, no feedback for an integration on trunk
> Surefire: Could be for Surefire 2.12. Issues to monitor are:
> 329 (category support): fixed, we use the official implementation from the trunk
> 786 (@Category with forkMode=always): fixed, we use the official implementation from the trunk
> 791 (incorrect elapsed time on test failure): fixed, we use the official implementation from the trunk
> 793 (incorrect time in the XML report): Not fixed (reopen) on trunk, fixed on our version.
> 760 (does not take into account the test method): fixed in trunk, not fixed in our version
> 798 (print immediately the test class name): not fixed in trunk, not fixed in our version
> 799 (Allow test parallelization when forkMode=always): not fixed in trunk, not fixed in our version
> 800 (redirectTestOutputToFile not taken into account): not yet fix on trunk, fixed on our version
> 800 & 793 are the more important to monitor, it's the only ones that are fixed in our version but not on trunk.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-4955) Use the official versions of surefire & junit

Posted by "nkeywal (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-4955?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

nkeywal updated HBASE-4955:
---------------------------

    Attachment: 4955.v2.patch
    
> Use the official versions of surefire & junit
> ---------------------------------------------
>
>                 Key: HBASE-4955
>                 URL: https://issues.apache.org/jira/browse/HBASE-4955
>             Project: HBase
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 0.94.0
>         Environment: all
>            Reporter: nkeywal
>            Assignee: nkeywal
>            Priority: Minor
>             Fix For: 0.96.0
>
>         Attachments: 4955.v1.patch, 4955.v2.patch, 4955.v2.patch
>
>
> We currently use private versions for Surefire & JUnit since HBASE-4763.
> This JIRA traks what we need to move to official versions.
> Surefire 2.11 is just out, but, after some tests, it does not contain all what we need.
> JUnit. Could be for JUnit 4.11. Issue to monitor:
> https://github.com/KentBeck/junit/issues/359: fixed in our version, no feedback for an integration on trunk
> Surefire: Could be for Surefire 2.12. Issues to monitor are:
> 329 (category support): fixed, we use the official implementation from the trunk
> 786 (@Category with forkMode=always): fixed, we use the official implementation from the trunk
> 791 (incorrect elapsed time on test failure): fixed, we use the official implementation from the trunk
> 793 (incorrect time in the XML report): Not fixed (reopen) on trunk, fixed on our version.
> 760 (does not take into account the test method): fixed in trunk, not fixed in our version
> 798 (print immediately the test class name): not fixed in trunk, not fixed in our version
> 799 (Allow test parallelization when forkMode=always): not fixed in trunk, not fixed in our version
> 800 (redirectTestOutputToFile not taken into account): not yet fix on trunk, fixed on our version
> 800 & 793 are the more important to monitor, it's the only ones that are fixed in our version but not on trunk.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-4955) Use the official versions of surefire & junit

Posted by "stack (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13510679#comment-13510679 ] 

stack commented on HBASE-4955:
------------------------------

Normally I would say commit but since you are so regular checking in on this issue, lets put off the commit till the next time you make your cycle through this issue.  Hopefully trunk will be more stable then and we'll be able to take on these new failures and fix them quickly.  Thanks [~nkeywal]
                
> Use the official versions of surefire & junit
> ---------------------------------------------
>
>                 Key: HBASE-4955
>                 URL: https://issues.apache.org/jira/browse/HBASE-4955
>             Project: HBase
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 0.94.0
>         Environment: all
>            Reporter: nkeywal
>            Assignee: nkeywal
>            Priority: Minor
>             Fix For: 0.96.0
>
>         Attachments: 4955.v1.patch, 4955.v2.patch, 4955.v2.patch
>
>
> We currently use private versions for Surefire & JUnit since HBASE-4763.
> This JIRA traks what we need to move to official versions.
> Surefire 2.11 is just out, but, after some tests, it does not contain all what we need.
> JUnit. Could be for JUnit 4.11. Issue to monitor:
> https://github.com/KentBeck/junit/issues/359: fixed in our version, no feedback for an integration on trunk
> Surefire: Could be for Surefire 2.12. Issues to monitor are:
> 329 (category support): fixed, we use the official implementation from the trunk
> 786 (@Category with forkMode=always): fixed, we use the official implementation from the trunk
> 791 (incorrect elapsed time on test failure): fixed, we use the official implementation from the trunk
> 793 (incorrect time in the XML report): Not fixed (reopen) on trunk, fixed on our version.
> 760 (does not take into account the test method): fixed in trunk, not fixed in our version
> 798 (print immediately the test class name): not fixed in trunk, not fixed in our version
> 799 (Allow test parallelization when forkMode=always): not fixed in trunk, not fixed in our version
> 800 (redirectTestOutputToFile not taken into account): not yet fix on trunk, fixed on our version
> 800 & 793 are the more important to monitor, it's the only ones that are fixed in our version but not on trunk.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-4955) Use the official versions of surefire & junit

Posted by "nkeywal (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13462757#comment-13462757 ] 

nkeywal commented on HBASE-4955:
--------------------------------

Monthly update...
Surefire: the regression on elapsed time is fixed on 2.12.4 (not tested). Still waiting for #800. May be it will make it to the 2.13. No date.
JUnit: no life there. Still a release this quarter is likely...


                
> Use the official versions of surefire & junit
> ---------------------------------------------
>
>                 Key: HBASE-4955
>                 URL: https://issues.apache.org/jira/browse/HBASE-4955
>             Project: HBase
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 0.94.0
>         Environment: all
>            Reporter: nkeywal
>            Assignee: nkeywal
>            Priority: Minor
>
> We currently use private versions for Surefire & JUnit since HBASE-4763.
> This JIRA traks what we need to move to official versions.
> Surefire 2.11 is just out, but, after some tests, it does not contain all what we need.
> JUnit. Could be for JUnit 4.11. Issue to monitor:
> https://github.com/KentBeck/junit/issues/359: fixed in our version, no feedback for an integration on trunk
> Surefire: Could be for Surefire 2.12. Issues to monitor are:
> 329 (category support): fixed, we use the official implementation from the trunk
> 786 (@Category with forkMode=always): fixed, we use the official implementation from the trunk
> 791 (incorrect elapsed time on test failure): fixed, we use the official implementation from the trunk
> 793 (incorrect time in the XML report): Not fixed (reopen) on trunk, fixed on our version.
> 760 (does not take into account the test method): fixed in trunk, not fixed in our version
> 798 (print immediately the test class name): not fixed in trunk, not fixed in our version
> 799 (Allow test parallelization when forkMode=always): not fixed in trunk, not fixed in our version
> 800 (redirectTestOutputToFile not taken into account): not yet fix on trunk, fixed on our version
> 800 & 793 are the more important to monitor, it's the only ones that are fixed in our version but not on trunk.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-4955) Use the official versions of surefire & junit

Posted by "nkeywal (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13217200#comment-13217200 ] 

nkeywal commented on HBASE-4955:
--------------------------------

Small update:
- No news from JUnit team. Issues was raised in november and they classified it as a bug, but my one line fix is not yet integrated. The main committers don't have a lot of time to spend on the project...
- Surefire 2.12 is available, but there is a regression (SUREFIRE-827) that they are currently fixing, so it seems better to wait for the 2.13.
                
> Use the official versions of surefire & junit
> ---------------------------------------------
>
>                 Key: HBASE-4955
>                 URL: https://issues.apache.org/jira/browse/HBASE-4955
>             Project: HBase
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 0.94.0
>         Environment: all
>            Reporter: nkeywal
>            Assignee: nkeywal
>            Priority: Minor
>
> We currently use private versions for Surefire & JUnit since HBASE-4763.
> This JIRA traks what we need to move to official versions.
> Surefire 2.11 is just out, but, after some tests, it does not contain all what we need.
> JUnit. Could be for JUnit 4.11. Issue to monitor:
> https://github.com/KentBeck/junit/issues/359: fixed in our version, no feedback for an integration on trunk
> Surefire: Could be for Surefire 2.12. Issues to monitor are:
> 329 (category support): fixed, we use the official implementation from the trunk
> 786 (@Category with forkMode=always): fixed, we use the official implementation from the trunk
> 791 (incorrect elapsed time on test failure): fixed, we use the official implementation from the trunk
> 793 (incorrect time in the XML report): Not fixed (reopen) on trunk, fixed on our version.
> 760 (does not take into account the test method): fixed in trunk, not fixed in our version
> 798 (print immediately the test class name): not fixed in trunk, not fixed in our version
> 799 (Allow test parallelization when forkMode=always): not fixed in trunk, not fixed in our version
> 800 (redirectTestOutputToFile not taken into account): not yet fix on trunk, fixed on our version
> 800 & 793 are the more important to monitor, it's the only ones that are fixed in our version but not on trunk.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-4955) Use the official versions of surefire & junit

Posted by "nkeywal (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13510572#comment-13510572 ] 

nkeywal commented on HBASE-4955:
--------------------------------

I've got 2 to 5 failures, but these two are always in the failed, while the others vary. So do I push the 'commit' button? It's likely to fail all builds until we fix the issue :-(
                
> Use the official versions of surefire & junit
> ---------------------------------------------
>
>                 Key: HBASE-4955
>                 URL: https://issues.apache.org/jira/browse/HBASE-4955
>             Project: HBase
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 0.94.0
>         Environment: all
>            Reporter: nkeywal
>            Assignee: nkeywal
>            Priority: Minor
>             Fix For: 0.96.0
>
>         Attachments: 4955.v1.patch, 4955.v2.patch, 4955.v2.patch
>
>
> We currently use private versions for Surefire & JUnit since HBASE-4763.
> This JIRA traks what we need to move to official versions.
> Surefire 2.11 is just out, but, after some tests, it does not contain all what we need.
> JUnit. Could be for JUnit 4.11. Issue to monitor:
> https://github.com/KentBeck/junit/issues/359: fixed in our version, no feedback for an integration on trunk
> Surefire: Could be for Surefire 2.12. Issues to monitor are:
> 329 (category support): fixed, we use the official implementation from the trunk
> 786 (@Category with forkMode=always): fixed, we use the official implementation from the trunk
> 791 (incorrect elapsed time on test failure): fixed, we use the official implementation from the trunk
> 793 (incorrect time in the XML report): Not fixed (reopen) on trunk, fixed on our version.
> 760 (does not take into account the test method): fixed in trunk, not fixed in our version
> 798 (print immediately the test class name): not fixed in trunk, not fixed in our version
> 799 (Allow test parallelization when forkMode=always): not fixed in trunk, not fixed in our version
> 800 (redirectTestOutputToFile not taken into account): not yet fix on trunk, fixed on our version
> 800 & 793 are the more important to monitor, it's the only ones that are fixed in our version but not on trunk.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-4955) Use the official versions of surefire & junit

Posted by "nkeywal (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-4955?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

nkeywal updated HBASE-4955:
---------------------------

    Status: Patch Available  (was: Open)
    
> Use the official versions of surefire & junit
> ---------------------------------------------
>
>                 Key: HBASE-4955
>                 URL: https://issues.apache.org/jira/browse/HBASE-4955
>             Project: HBase
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 0.94.0
>         Environment: all
>            Reporter: nkeywal
>            Assignee: nkeywal
>            Priority: Minor
>             Fix For: 0.96.0
>
>         Attachments: 4955.v1.patch, 4955.v2.patch, 4955.v2.patch
>
>
> We currently use private versions for Surefire & JUnit since HBASE-4763.
> This JIRA traks what we need to move to official versions.
> Surefire 2.11 is just out, but, after some tests, it does not contain all what we need.
> JUnit. Could be for JUnit 4.11. Issue to monitor:
> https://github.com/KentBeck/junit/issues/359: fixed in our version, no feedback for an integration on trunk
> Surefire: Could be for Surefire 2.12. Issues to monitor are:
> 329 (category support): fixed, we use the official implementation from the trunk
> 786 (@Category with forkMode=always): fixed, we use the official implementation from the trunk
> 791 (incorrect elapsed time on test failure): fixed, we use the official implementation from the trunk
> 793 (incorrect time in the XML report): Not fixed (reopen) on trunk, fixed on our version.
> 760 (does not take into account the test method): fixed in trunk, not fixed in our version
> 798 (print immediately the test class name): not fixed in trunk, not fixed in our version
> 799 (Allow test parallelization when forkMode=always): not fixed in trunk, not fixed in our version
> 800 (redirectTestOutputToFile not taken into account): not yet fix on trunk, fixed on our version
> 800 & 793 are the more important to monitor, it's the only ones that are fixed in our version but not on trunk.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-4955) Use the official versions of surefire & junit

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13498765#comment-13498765 ] 

Hadoop QA commented on HBASE-4955:
----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12553768/4955.v2.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 hadoop2.0{color}.  The patch compiles against the hadoop 2.0 profile.

    {color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 99 warning messages.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:red}-1 findbugs{color}.  The patch appears to introduce 24 new Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.client.TestMultiParallel
                  org.apache.hadoop.hbase.client.TestAdmin
                  org.apache.hadoop.hbase.util.TestMiniClusterLoadParallel
                  org.apache.hadoop.hbase.TestZooKeeper

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3351//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3351//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3351//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3351//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3351//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3351//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3351//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3351//console

This message is automatically generated.
                
> Use the official versions of surefire & junit
> ---------------------------------------------
>
>                 Key: HBASE-4955
>                 URL: https://issues.apache.org/jira/browse/HBASE-4955
>             Project: HBase
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 0.94.0
>         Environment: all
>            Reporter: nkeywal
>            Assignee: nkeywal
>            Priority: Minor
>             Fix For: 0.96.0
>
>         Attachments: 4955.v1.patch, 4955.v2.patch
>
>
> We currently use private versions for Surefire & JUnit since HBASE-4763.
> This JIRA traks what we need to move to official versions.
> Surefire 2.11 is just out, but, after some tests, it does not contain all what we need.
> JUnit. Could be for JUnit 4.11. Issue to monitor:
> https://github.com/KentBeck/junit/issues/359: fixed in our version, no feedback for an integration on trunk
> Surefire: Could be for Surefire 2.12. Issues to monitor are:
> 329 (category support): fixed, we use the official implementation from the trunk
> 786 (@Category with forkMode=always): fixed, we use the official implementation from the trunk
> 791 (incorrect elapsed time on test failure): fixed, we use the official implementation from the trunk
> 793 (incorrect time in the XML report): Not fixed (reopen) on trunk, fixed on our version.
> 760 (does not take into account the test method): fixed in trunk, not fixed in our version
> 798 (print immediately the test class name): not fixed in trunk, not fixed in our version
> 799 (Allow test parallelization when forkMode=always): not fixed in trunk, not fixed in our version
> 800 (redirectTestOutputToFile not taken into account): not yet fix on trunk, fixed on our version
> 800 & 793 are the more important to monitor, it's the only ones that are fixed in our version but not on trunk.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-4955) Use the official versions of surefire & junit

Posted by "nkeywal (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13273153#comment-13273153 ] 

nkeywal commented on HBASE-4955:
--------------------------------

Update: Still waiting for JUnit 4.11 & Surefire 2.13, still no release date.
                
> Use the official versions of surefire & junit
> ---------------------------------------------
>
>                 Key: HBASE-4955
>                 URL: https://issues.apache.org/jira/browse/HBASE-4955
>             Project: HBase
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 0.94.0
>         Environment: all
>            Reporter: nkeywal
>            Assignee: nkeywal
>            Priority: Minor
>
> We currently use private versions for Surefire & JUnit since HBASE-4763.
> This JIRA traks what we need to move to official versions.
> Surefire 2.11 is just out, but, after some tests, it does not contain all what we need.
> JUnit. Could be for JUnit 4.11. Issue to monitor:
> https://github.com/KentBeck/junit/issues/359: fixed in our version, no feedback for an integration on trunk
> Surefire: Could be for Surefire 2.12. Issues to monitor are:
> 329 (category support): fixed, we use the official implementation from the trunk
> 786 (@Category with forkMode=always): fixed, we use the official implementation from the trunk
> 791 (incorrect elapsed time on test failure): fixed, we use the official implementation from the trunk
> 793 (incorrect time in the XML report): Not fixed (reopen) on trunk, fixed on our version.
> 760 (does not take into account the test method): fixed in trunk, not fixed in our version
> 798 (print immediately the test class name): not fixed in trunk, not fixed in our version
> 799 (Allow test parallelization when forkMode=always): not fixed in trunk, not fixed in our version
> 800 (redirectTestOutputToFile not taken into account): not yet fix on trunk, fixed on our version
> 800 & 793 are the more important to monitor, it's the only ones that are fixed in our version but not on trunk.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-4955) Use the official versions of surefire & junit

Posted by "nkeywal (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13440491#comment-13440491 ] 

nkeywal commented on HBASE-4955:
--------------------------------

2.12.2 is now available, and there are some activity on surefire, so we could have a 2.13 "soon". I tested the snapshot version on HBase trunk, the only issue I found is #800.

I proposed a reasonable (imho) fix for it in surefire. It covers the case for forkMode=perthread (i.e. medium & large tests). I don't have a non hacky fix for small tests (they are on a different code path in surefire), so we will have either to accept output on the console for small tests either to change the verbose small tests to medium.

The former option would likely put us with very simple tests that we should be able to parallelize within a single jvm, so it's reasonable.
                
> Use the official versions of surefire & junit
> ---------------------------------------------
>
>                 Key: HBASE-4955
>                 URL: https://issues.apache.org/jira/browse/HBASE-4955
>             Project: HBase
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 0.94.0
>         Environment: all
>            Reporter: nkeywal
>            Assignee: nkeywal
>            Priority: Minor
>
> We currently use private versions for Surefire & JUnit since HBASE-4763.
> This JIRA traks what we need to move to official versions.
> Surefire 2.11 is just out, but, after some tests, it does not contain all what we need.
> JUnit. Could be for JUnit 4.11. Issue to monitor:
> https://github.com/KentBeck/junit/issues/359: fixed in our version, no feedback for an integration on trunk
> Surefire: Could be for Surefire 2.12. Issues to monitor are:
> 329 (category support): fixed, we use the official implementation from the trunk
> 786 (@Category with forkMode=always): fixed, we use the official implementation from the trunk
> 791 (incorrect elapsed time on test failure): fixed, we use the official implementation from the trunk
> 793 (incorrect time in the XML report): Not fixed (reopen) on trunk, fixed on our version.
> 760 (does not take into account the test method): fixed in trunk, not fixed in our version
> 798 (print immediately the test class name): not fixed in trunk, not fixed in our version
> 799 (Allow test parallelization when forkMode=always): not fixed in trunk, not fixed in our version
> 800 (redirectTestOutputToFile not taken into account): not yet fix on trunk, fixed on our version
> 800 & 793 are the more important to monitor, it's the only ones that are fixed in our version but not on trunk.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-4955) Use the official versions of surefire & junit

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13498327#comment-13498327 ] 

Hadoop QA commented on HBASE-4955:
----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12553691/4955.v1.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 hadoop2.0{color}.  The patch compiles against the hadoop 2.0 profile.

    {color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 93 warning messages.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:red}-1 findbugs{color}.  The patch appears to introduce 16 new Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.TestZooKeeper
                  org.apache.hadoop.hbase.client.TestAdmin
                  org.apache.hadoop.hbase.client.TestMultiParallel

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3348//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3348//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3348//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3348//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3348//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3348//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3348//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3348//console

This message is automatically generated.
                
> Use the official versions of surefire & junit
> ---------------------------------------------
>
>                 Key: HBASE-4955
>                 URL: https://issues.apache.org/jira/browse/HBASE-4955
>             Project: HBase
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 0.94.0
>         Environment: all
>            Reporter: nkeywal
>            Assignee: nkeywal
>            Priority: Minor
>             Fix For: 0.96.0
>
>         Attachments: 4955.v1.patch
>
>
> We currently use private versions for Surefire & JUnit since HBASE-4763.
> This JIRA traks what we need to move to official versions.
> Surefire 2.11 is just out, but, after some tests, it does not contain all what we need.
> JUnit. Could be for JUnit 4.11. Issue to monitor:
> https://github.com/KentBeck/junit/issues/359: fixed in our version, no feedback for an integration on trunk
> Surefire: Could be for Surefire 2.12. Issues to monitor are:
> 329 (category support): fixed, we use the official implementation from the trunk
> 786 (@Category with forkMode=always): fixed, we use the official implementation from the trunk
> 791 (incorrect elapsed time on test failure): fixed, we use the official implementation from the trunk
> 793 (incorrect time in the XML report): Not fixed (reopen) on trunk, fixed on our version.
> 760 (does not take into account the test method): fixed in trunk, not fixed in our version
> 798 (print immediately the test class name): not fixed in trunk, not fixed in our version
> 799 (Allow test parallelization when forkMode=always): not fixed in trunk, not fixed in our version
> 800 (redirectTestOutputToFile not taken into account): not yet fix on trunk, fixed on our version
> 800 & 793 are the more important to monitor, it's the only ones that are fixed in our version but not on trunk.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-4955) Use the official versions of surefire & junit

Posted by "nkeywal (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-4955?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

nkeywal updated HBASE-4955:
---------------------------

    Status: Open  (was: Patch Available)
    
> Use the official versions of surefire & junit
> ---------------------------------------------
>
>                 Key: HBASE-4955
>                 URL: https://issues.apache.org/jira/browse/HBASE-4955
>             Project: HBase
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 0.94.0
>         Environment: all
>            Reporter: nkeywal
>            Assignee: nkeywal
>            Priority: Minor
>             Fix For: 0.96.0
>
>         Attachments: 4955.v1.patch
>
>
> We currently use private versions for Surefire & JUnit since HBASE-4763.
> This JIRA traks what we need to move to official versions.
> Surefire 2.11 is just out, but, after some tests, it does not contain all what we need.
> JUnit. Could be for JUnit 4.11. Issue to monitor:
> https://github.com/KentBeck/junit/issues/359: fixed in our version, no feedback for an integration on trunk
> Surefire: Could be for Surefire 2.12. Issues to monitor are:
> 329 (category support): fixed, we use the official implementation from the trunk
> 786 (@Category with forkMode=always): fixed, we use the official implementation from the trunk
> 791 (incorrect elapsed time on test failure): fixed, we use the official implementation from the trunk
> 793 (incorrect time in the XML report): Not fixed (reopen) on trunk, fixed on our version.
> 760 (does not take into account the test method): fixed in trunk, not fixed in our version
> 798 (print immediately the test class name): not fixed in trunk, not fixed in our version
> 799 (Allow test parallelization when forkMode=always): not fixed in trunk, not fixed in our version
> 800 (redirectTestOutputToFile not taken into account): not yet fix on trunk, fixed on our version
> 800 & 793 are the more important to monitor, it's the only ones that are fixed in our version but not on trunk.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-4955) Use the official versions of surefire & junit

Posted by "nkeywal (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13510559#comment-13510559 ] 

nkeywal commented on HBASE-4955:
--------------------------------

Retested 3 times again on trunk, these errors are always there. I don't always have then when I test with the current JUnit:
 testZNodeDeletes(org.apache.hadoop.hbase.TestZooKeeper): KeeperErrorCode = NoAuth for /l1
 testFlushCommitsWithAbort(org.apache.hadoop.hbase.client.TestMultiParallel): Server count=2, abort=true expected:<1> but was:<2>

JUnit 4.11 is out for a month, no one raised an issue about it. So may be we have flaky tests that are now just failed tests on 4.11 (i.e. a bug on out side that always appears with 4.11?). We can either wait a little bit more, for example waiting for more validation work on 0.96, either push it now, expecting someone will be motivated about finding the root issue, either try to fix the issue before pushing :-).
                
> Use the official versions of surefire & junit
> ---------------------------------------------
>
>                 Key: HBASE-4955
>                 URL: https://issues.apache.org/jira/browse/HBASE-4955
>             Project: HBase
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 0.94.0
>         Environment: all
>            Reporter: nkeywal
>            Assignee: nkeywal
>            Priority: Minor
>             Fix For: 0.96.0
>
>         Attachments: 4955.v1.patch, 4955.v2.patch, 4955.v2.patch
>
>
> We currently use private versions for Surefire & JUnit since HBASE-4763.
> This JIRA traks what we need to move to official versions.
> Surefire 2.11 is just out, but, after some tests, it does not contain all what we need.
> JUnit. Could be for JUnit 4.11. Issue to monitor:
> https://github.com/KentBeck/junit/issues/359: fixed in our version, no feedback for an integration on trunk
> Surefire: Could be for Surefire 2.12. Issues to monitor are:
> 329 (category support): fixed, we use the official implementation from the trunk
> 786 (@Category with forkMode=always): fixed, we use the official implementation from the trunk
> 791 (incorrect elapsed time on test failure): fixed, we use the official implementation from the trunk
> 793 (incorrect time in the XML report): Not fixed (reopen) on trunk, fixed on our version.
> 760 (does not take into account the test method): fixed in trunk, not fixed in our version
> 798 (print immediately the test class name): not fixed in trunk, not fixed in our version
> 799 (Allow test parallelization when forkMode=always): not fixed in trunk, not fixed in our version
> 800 (redirectTestOutputToFile not taken into account): not yet fix on trunk, fixed on our version
> 800 & 793 are the more important to monitor, it's the only ones that are fixed in our version but not on trunk.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-4955) Use the official versions of surefire & junit

Posted by "nkeywal (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-4955?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

nkeywal updated HBASE-4955:
---------------------------

    Attachment: 4955.v2.patch
    
> Use the official versions of surefire & junit
> ---------------------------------------------
>
>                 Key: HBASE-4955
>                 URL: https://issues.apache.org/jira/browse/HBASE-4955
>             Project: HBase
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 0.94.0
>         Environment: all
>            Reporter: nkeywal
>            Assignee: nkeywal
>            Priority: Minor
>             Fix For: 0.96.0
>
>         Attachments: 4955.v1.patch, 4955.v2.patch
>
>
> We currently use private versions for Surefire & JUnit since HBASE-4763.
> This JIRA traks what we need to move to official versions.
> Surefire 2.11 is just out, but, after some tests, it does not contain all what we need.
> JUnit. Could be for JUnit 4.11. Issue to monitor:
> https://github.com/KentBeck/junit/issues/359: fixed in our version, no feedback for an integration on trunk
> Surefire: Could be for Surefire 2.12. Issues to monitor are:
> 329 (category support): fixed, we use the official implementation from the trunk
> 786 (@Category with forkMode=always): fixed, we use the official implementation from the trunk
> 791 (incorrect elapsed time on test failure): fixed, we use the official implementation from the trunk
> 793 (incorrect time in the XML report): Not fixed (reopen) on trunk, fixed on our version.
> 760 (does not take into account the test method): fixed in trunk, not fixed in our version
> 798 (print immediately the test class name): not fixed in trunk, not fixed in our version
> 799 (Allow test parallelization when forkMode=always): not fixed in trunk, not fixed in our version
> 800 (redirectTestOutputToFile not taken into account): not yet fix on trunk, fixed on our version
> 800 & 793 are the more important to monitor, it's the only ones that are fixed in our version but not on trunk.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-4955) Use the official versions of surefire & junit

Posted by "nkeywal (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-4955?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

nkeywal updated HBASE-4955:
---------------------------

    Status: Patch Available  (was: Open)
    
> Use the official versions of surefire & junit
> ---------------------------------------------
>
>                 Key: HBASE-4955
>                 URL: https://issues.apache.org/jira/browse/HBASE-4955
>             Project: HBase
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 0.94.0
>         Environment: all
>            Reporter: nkeywal
>            Assignee: nkeywal
>            Priority: Minor
>             Fix For: 0.96.0
>
>         Attachments: 4955.v1.patch, 4955.v2.patch
>
>
> We currently use private versions for Surefire & JUnit since HBASE-4763.
> This JIRA traks what we need to move to official versions.
> Surefire 2.11 is just out, but, after some tests, it does not contain all what we need.
> JUnit. Could be for JUnit 4.11. Issue to monitor:
> https://github.com/KentBeck/junit/issues/359: fixed in our version, no feedback for an integration on trunk
> Surefire: Could be for Surefire 2.12. Issues to monitor are:
> 329 (category support): fixed, we use the official implementation from the trunk
> 786 (@Category with forkMode=always): fixed, we use the official implementation from the trunk
> 791 (incorrect elapsed time on test failure): fixed, we use the official implementation from the trunk
> 793 (incorrect time in the XML report): Not fixed (reopen) on trunk, fixed on our version.
> 760 (does not take into account the test method): fixed in trunk, not fixed in our version
> 798 (print immediately the test class name): not fixed in trunk, not fixed in our version
> 799 (Allow test parallelization when forkMode=always): not fixed in trunk, not fixed in our version
> 800 (redirectTestOutputToFile not taken into account): not yet fix on trunk, fixed on our version
> 800 & 793 are the more important to monitor, it's the only ones that are fixed in our version but not on trunk.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-4955) Use the official versions of surefire & junit

Posted by "nkeywal (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13444550#comment-13444550 ] 

nkeywal commented on HBASE-4955:
--------------------------------

Yeah, I've never tried 2.12, it was too smelly. I'm targeting the next release (likely numbered  2.13); i.e. trunk as of today + #800. I'm still awaiting feedback for this last one.
I've done some tests on hadoop-qa, there are in HBASE-6674. Don't hesitate to add your findings.
                
> Use the official versions of surefire & junit
> ---------------------------------------------
>
>                 Key: HBASE-4955
>                 URL: https://issues.apache.org/jira/browse/HBASE-4955
>             Project: HBase
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 0.94.0
>         Environment: all
>            Reporter: nkeywal
>            Assignee: nkeywal
>            Priority: Minor
>
> We currently use private versions for Surefire & JUnit since HBASE-4763.
> This JIRA traks what we need to move to official versions.
> Surefire 2.11 is just out, but, after some tests, it does not contain all what we need.
> JUnit. Could be for JUnit 4.11. Issue to monitor:
> https://github.com/KentBeck/junit/issues/359: fixed in our version, no feedback for an integration on trunk
> Surefire: Could be for Surefire 2.12. Issues to monitor are:
> 329 (category support): fixed, we use the official implementation from the trunk
> 786 (@Category with forkMode=always): fixed, we use the official implementation from the trunk
> 791 (incorrect elapsed time on test failure): fixed, we use the official implementation from the trunk
> 793 (incorrect time in the XML report): Not fixed (reopen) on trunk, fixed on our version.
> 760 (does not take into account the test method): fixed in trunk, not fixed in our version
> 798 (print immediately the test class name): not fixed in trunk, not fixed in our version
> 799 (Allow test parallelization when forkMode=always): not fixed in trunk, not fixed in our version
> 800 (redirectTestOutputToFile not taken into account): not yet fix on trunk, fixed on our version
> 800 & 793 are the more important to monitor, it's the only ones that are fixed in our version but not on trunk.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-4955) Use the official versions of surefire & junit

Posted by "nkeywal (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13235605#comment-13235605 ] 

nkeywal commented on HBASE-4955:
--------------------------------

Monthly update:
 - The JUnit team merged my fix on the JUnit trunk, so the next JUnit version (should be 4.11) will be ok for us. I don't have the release date however.
 - The surefire regression (SUREFIRE-827) is not yet fixed, still planned for 2.13. No release date.
                
> Use the official versions of surefire & junit
> ---------------------------------------------
>
>                 Key: HBASE-4955
>                 URL: https://issues.apache.org/jira/browse/HBASE-4955
>             Project: HBase
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 0.94.0
>         Environment: all
>            Reporter: nkeywal
>            Assignee: nkeywal
>            Priority: Minor
>
> We currently use private versions for Surefire & JUnit since HBASE-4763.
> This JIRA traks what we need to move to official versions.
> Surefire 2.11 is just out, but, after some tests, it does not contain all what we need.
> JUnit. Could be for JUnit 4.11. Issue to monitor:
> https://github.com/KentBeck/junit/issues/359: fixed in our version, no feedback for an integration on trunk
> Surefire: Could be for Surefire 2.12. Issues to monitor are:
> 329 (category support): fixed, we use the official implementation from the trunk
> 786 (@Category with forkMode=always): fixed, we use the official implementation from the trunk
> 791 (incorrect elapsed time on test failure): fixed, we use the official implementation from the trunk
> 793 (incorrect time in the XML report): Not fixed (reopen) on trunk, fixed on our version.
> 760 (does not take into account the test method): fixed in trunk, not fixed in our version
> 798 (print immediately the test class name): not fixed in trunk, not fixed in our version
> 799 (Allow test parallelization when forkMode=always): not fixed in trunk, not fixed in our version
> 800 (redirectTestOutputToFile not taken into account): not yet fix on trunk, fixed on our version
> 800 & 793 are the more important to monitor, it's the only ones that are fixed in our version but not on trunk.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-4955) Use the official versions of surefire & junit

Posted by "nkeywal (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13501861#comment-13501861 ] 

nkeywal commented on HBASE-4955:
--------------------------------

Local test on trunk: errors on TestAdmin / TestZooKeeper / TestMultiParallel as previously in precommit. I will wait another week.

Failed tests:testFlushCommitsWithAbort(org.apache.hadoop.hbase.client.TestMultiParallel): Server count=2, abort=true expected:<1> but was:<2>
  testVerifyRepJob(org.apache.hadoop.hbase.replication.TestReplication): Waited too much time for truncate
  testSmallBatch(org.apache.hadoop.hbase.replication.TestReplication): Waited too much time for truncate
  testDisableEnable(org.apache.hadoop.hbase.replication.TestReplication): Waited too much time for truncate
  testSimplePutDelete(org.apache.hadoop.hbase.replication.TestReplication): Waited too much time for truncate
  testDeleteEditUnknownColumnFamilyAndOrTable(org.apache.hadoop.hbase.client.TestAdmin)

Tests in error:
  testReadModifyWrite(org.apache.hadoop.hbase.coprocessor.TestRowProcessorEndpoint): Failed after attempts=1, exceptions:(..)
  testZNodeDeletes(org.apache.hadoop.hbase.TestZooKeeper): KeeperErrorCode = NoAuth for /l1

                
> Use the official versions of surefire & junit
> ---------------------------------------------
>
>                 Key: HBASE-4955
>                 URL: https://issues.apache.org/jira/browse/HBASE-4955
>             Project: HBase
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 0.94.0
>         Environment: all
>            Reporter: nkeywal
>            Assignee: nkeywal
>            Priority: Minor
>             Fix For: 0.96.0
>
>         Attachments: 4955.v1.patch, 4955.v2.patch, 4955.v2.patch
>
>
> We currently use private versions for Surefire & JUnit since HBASE-4763.
> This JIRA traks what we need to move to official versions.
> Surefire 2.11 is just out, but, after some tests, it does not contain all what we need.
> JUnit. Could be for JUnit 4.11. Issue to monitor:
> https://github.com/KentBeck/junit/issues/359: fixed in our version, no feedback for an integration on trunk
> Surefire: Could be for Surefire 2.12. Issues to monitor are:
> 329 (category support): fixed, we use the official implementation from the trunk
> 786 (@Category with forkMode=always): fixed, we use the official implementation from the trunk
> 791 (incorrect elapsed time on test failure): fixed, we use the official implementation from the trunk
> 793 (incorrect time in the XML report): Not fixed (reopen) on trunk, fixed on our version.
> 760 (does not take into account the test method): fixed in trunk, not fixed in our version
> 798 (print immediately the test class name): not fixed in trunk, not fixed in our version
> 799 (Allow test parallelization when forkMode=always): not fixed in trunk, not fixed in our version
> 800 (redirectTestOutputToFile not taken into account): not yet fix on trunk, fixed on our version
> 800 & 793 are the more important to monitor, it's the only ones that are fixed in our version but not on trunk.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-4955) Use the official versions of surefire & junit

Posted by "nkeywal (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13495208#comment-13495208 ] 

nkeywal commented on HBASE-4955:
--------------------------------

Monthly update: same status as a month ago....
                
> Use the official versions of surefire & junit
> ---------------------------------------------
>
>                 Key: HBASE-4955
>                 URL: https://issues.apache.org/jira/browse/HBASE-4955
>             Project: HBase
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 0.94.0
>         Environment: all
>            Reporter: nkeywal
>            Assignee: nkeywal
>            Priority: Minor
>
> We currently use private versions for Surefire & JUnit since HBASE-4763.
> This JIRA traks what we need to move to official versions.
> Surefire 2.11 is just out, but, after some tests, it does not contain all what we need.
> JUnit. Could be for JUnit 4.11. Issue to monitor:
> https://github.com/KentBeck/junit/issues/359: fixed in our version, no feedback for an integration on trunk
> Surefire: Could be for Surefire 2.12. Issues to monitor are:
> 329 (category support): fixed, we use the official implementation from the trunk
> 786 (@Category with forkMode=always): fixed, we use the official implementation from the trunk
> 791 (incorrect elapsed time on test failure): fixed, we use the official implementation from the trunk
> 793 (incorrect time in the XML report): Not fixed (reopen) on trunk, fixed on our version.
> 760 (does not take into account the test method): fixed in trunk, not fixed in our version
> 798 (print immediately the test class name): not fixed in trunk, not fixed in our version
> 799 (Allow test parallelization when forkMode=always): not fixed in trunk, not fixed in our version
> 800 (redirectTestOutputToFile not taken into account): not yet fix on trunk, fixed on our version
> 800 & 793 are the more important to monitor, it's the only ones that are fixed in our version but not on trunk.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira