[GitHub] [cloudstack] shwstppr opened a new pull request #3383: template: copy md5 mismatch

[GitBox <gi...@apache.org>]

shwstppr opened a new pull request #3383: template: copy md5 mismatch
URL: https://github.com/apache/cloudstack/pull/3383
 
 
   ## Description
   Fixes #3191 
   
   When a template is registered, code stores md5sum of the downloaded file in the `vm_template` table. However, this downloaded file could be deleted after template installation if it is not an actual (`.qcow2`, `.ova`, etc.) file. When the user copies a template using copyTemplate API, the actual template file will be copied across the image stores. Matching checksum for the copied templated file and the stored value from the `vm_template` table will result in a mismatch.
   Changes will set an empty checksum value for the copied template while passing to download service which allows skipping wrong checksum check for the copied while install.
   However, this results in a change in checksum value for concerned template entry in `vm_template` table post template install.
   
   ## Types of changes
   <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [x] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## Screenshots (if appropriate):
   ![template-md5-mismatch-1](https://user-images.githubusercontent.com/153340/59089736-766c0a80-8928-11e9-9372-c190e946bba9.png)
   
   ![template-md5-mismatch-2](https://user-images.githubusercontent.com/153340/59089744-7b30be80-8928-11e9-9a73-92322f12cc9a.png)
   
   ## How Has This Been Tested?
   <!-- Please describe in detail how you tested your changes. -->
   cmk
   
   
   <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services