[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #7606: Fix dynamic configuration watch implementation current value not null when the config is deleted.

[GitBox <gi...@apache.org>]

kezhenxu94 commented on a change in pull request #7606:
URL: https://github.com/apache/skywalking/pull/7606#discussion_r698284166



##########
File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/ApdexThresholdConfig.java
##########
@@ -90,7 +89,9 @@ private synchronized void activeSetting(String config) {
             log.debug("Updating using new static config: {}", config);
         }
         rawConfig = config;
-        updateConfig(new StringReader(config));
+        if (config != null) {
+            updateConfig(new StringReader(config));
+        }

Review comment:
       `config == ""` was an signal to "reset" the config, with this new `if` statement, the config might never been reset even the dynamic config is deleted?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org