[GitHub] gianm commented on issue #6866: Reverse dependencies from /main/ to /test/

[GitBox <gi...@apache.org>]

gianm commented on issue #6866: Reverse dependencies from /main/ to /test/
URL: https://github.com/apache/incubator-druid/issues/6866#issuecomment-454625535
 
 
   > An even larger question is why is Druid-benchmarks even in the main tree?
   
   If I had to guess, it has something to do with that being the way whoever set it up got the packaging to work out for `benchmarks/target/benchmarks.jar`, which is where JMH benchmarks get run from. `druid-benchmarks` isn't part of the `distribution` package, so even though it has a main tree, that tree won't get distributed as part of a Druid binary package. (The kind you get from http://druid.apache.org/downloads.html)
   
   If there's a way to move the sources to a test tree and still get `benchmarks/target/benchmarks.jar` to generate properly, then that would be more aesthetically appealing.
   
   What should _not_ be done is moving some of that test stuff from other packages' `test` to `main`. That would pollute Druid binary packages.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org