You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/03/24 04:48:24 UTC

[GitHub] [airflow] dstandish edited a comment on issue #14945: Circular import issues with airflow_local_settings.py

dstandish edited a comment on issue #14945:
URL: https://github.com/apache/airflow/issues/14945#issuecomment-805491810


   Nope!
   
   Here's how to test:
   
   `airflow_local_settings.py`:
   
   ```python
   #  from airflow.models import DAG
   #  from airflow import DAG
   def dag_policy(dag):
       dag.template_searchpath = ['hello']
   ```
   
   in dag file:
   
   ```python
   from airflow import settings
   settings.dag_policy(dag)
   print(dag.template_searchpath)
   ```
   
   When you import from models, the dag policy works.  When you import from airflow it does not.
   
   So I guess this is mostly a non issue.  
   
   One thing we can do is fix [this line](https://github.com/apache/airflow/blob/1222ebd4e1eb6fdefa886759c43d4d4db691697a/tests/cluster_policies/__init__.py#L21).  I can make a PR for that.  Do you think it's worth adding any documentation?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org