You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "nikam14 (via GitHub)" <gi...@apache.org> on 2023/05/02 10:00:48 UTC
[GitHub] [cloudstack] nikam14 opened a new pull request, #7486: [MINOR][Enhancement] improved concatenation way in PropertiesStorage.java
nikam14 opened a new pull request, #7486:
URL: https://github.com/apache/cloudstack/pull/7486
### Description
This PR... changed the '+' operator for concatenation to .concat method for concatenation because '+' operator takes more time then .concat method.
[Optimisation].
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [x] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [x] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on a diff in pull request #7486: [MINOR][Enhancement] improved concatenation way in PropertiesStorage.java
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on code in PR #7486:
URL: https://github.com/apache/cloudstack/pull/7486#discussion_r1187079958
##########
agent/src/main/java/com/cloud/agent/dao/impl/PropertiesStorage.java:
##########
@@ -92,11 +92,11 @@ public synchronized boolean configure(String name, Map<String, Object> params) {
file = new File(path);
try {
if (!file.createNewFile()) {
- s_logger.error("Unable to create _file: " + file.getAbsolutePath());
+ s_logger.error("Unable to create _file: ".concat(file.getAbsolutePath()));
Review Comment:
the preferred way would be to use String.format, the concatenation using `+` isn't any different from concat.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] soreana closed pull request #7486: [MINOR][Enhancement] improved concatenation way in PropertiesStorage.java
Posted by "soreana (via GitHub)" <gi...@apache.org>.
soreana closed pull request #7486: [MINOR][Enhancement] improved concatenation way in PropertiesStorage.java
URL: https://github.com/apache/cloudstack/pull/7486
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MINOR][Enhancement] improved concatenation way in PropertiesStorage.java [cloudstack]
Posted by "GutoVeronezi (via GitHub)" <gi...@apache.org>.
GutoVeronezi commented on code in PR #7486:
URL: https://github.com/apache/cloudstack/pull/7486#discussion_r1342567071
##########
agent/src/main/java/com/cloud/agent/dao/impl/PropertiesStorage.java:
##########
@@ -92,11 +92,11 @@ public synchronized boolean configure(String name, Map<String, Object> params) {
file = new File(path);
try {
if (!file.createNewFile()) {
- s_logger.error("Unable to create _file: " + file.getAbsolutePath());
+ s_logger.error(String.format("Unable to create _file: %s",file.getAbsolutePath()));
Review Comment:
```suggestion
s_logger.error(String.format("Unable to create _file: %s", file.getAbsolutePath()));
```
##########
agent/src/main/java/com/cloud/agent/dao/impl/PropertiesStorage.java:
##########
@@ -92,11 +92,11 @@ public synchronized boolean configure(String name, Map<String, Object> params) {
file = new File(path);
try {
if (!file.createNewFile()) {
- s_logger.error("Unable to create _file: " + file.getAbsolutePath());
+ s_logger.error(String.format("Unable to create _file: %s",file.getAbsolutePath()));
return false;
}
} catch (IOException e) {
- s_logger.error("Unable to create _file: " + file.getAbsolutePath(), e);
+ s_logger.error(String.format("Unable to create _file: %s",file.getAbsolutePath()), e);
Review Comment:
```suggestion
s_logger.error(String.format("Unable to create _file: %s", file.getAbsolutePath()), e);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improved concatenation way in PropertiesStorage.java [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #7486:
URL: https://github.com/apache/cloudstack/pull/7486#issuecomment-1787389585
@nikam14 @GutoVeronezi , I've applied the rather trivial changes to move this forward, please publicaly shame me here or on email if that was just to brutal of me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improved concatenation way in PropertiesStorage.java [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #7486:
URL: https://github.com/apache/cloudstack/pull/7486#issuecomment-1812713332
formatting log messages only, should be good if compiles
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improved concatenation way in PropertiesStorage.java [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7486:
URL: https://github.com/apache/cloudstack/pull/7486#issuecomment-1787514243
Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 7584
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improved concatenation way in PropertiesStorage.java [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland closed pull request #7486: Improved concatenation way in PropertiesStorage.java
URL: https://github.com/apache/cloudstack/pull/7486
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] codecov[bot] commented on pull request #7486: [MINOR][Enhancement] improved concatenation way in PropertiesStorage.java
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #7486:
URL: https://github.com/apache/cloudstack/pull/7486#issuecomment-1537905030
## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/7486?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7486](https://app.codecov.io/gh/apache/cloudstack/pull/7486?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f70061b) into [main](https://app.codecov.io/gh/apache/cloudstack/commit/8b5bfb145e335209e261056a691ffeb7372ca0e1?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8b5bfb1) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## main #7486 +/- ##
============================================
- Coverage 12.72% 12.71% -0.01%
+ Complexity 8706 8705 -1
============================================
Files 2727 2727
Lines 256526 256526
Branches 39989 39989
============================================
- Hits 32636 32627 -9
- Misses 219738 219748 +10
+ Partials 4152 4151 -1
```
[see 1 file with indirect coverage changes](https://app.codecov.io/gh/apache/cloudstack/pull/7486/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improved concatenation way in PropertiesStorage.java [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on code in PR #7486:
URL: https://github.com/apache/cloudstack/pull/7486#discussion_r1394339714
##########
agent/src/main/java/com/cloud/agent/dao/impl/PropertiesStorage.java:
##########
@@ -92,11 +92,14 @@ public synchronized boolean configure(String name, Map<String, Object> params) {
file = new File(path);
try {
if (!file.createNewFile()) {
- s_logger.error("Unable to create _file: " + file.getAbsolutePath());
+ s_logger.error(String.format("Unable to create _file: %s", file.getAbsolutePath()));
return false;
}
} catch (IOException e) {
- s_logger.error("Unable to create _file: " + file.getAbsolutePath(), e);
+ s_logger.error(String.format("Unable to create file: %s", file.getAbsolutePath()));
+ if (s_logger.isDebugEnabled()) {
+ s_logger.bedug(String.format("IOException while trying to create file: %s", file.getAbsolutePath()), e);
Review Comment:
```suggestion
s_logger.debug(String.format("IOException while trying to create file: %s", file.getAbsolutePath()), e);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improved concatenation way in PropertiesStorage.java [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7486:
URL: https://github.com/apache/cloudstack/pull/7486#issuecomment-1787393535
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improved concatenation way in PropertiesStorage.java [cloudstack]
Posted by "shwstppr (via GitHub)" <gi...@apache.org>.
shwstppr commented on PR #7486:
URL: https://github.com/apache/cloudstack/pull/7486#issuecomment-1748354707
@nikam14 can you please address outstanding review comments?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improved concatenation way in PropertiesStorage.java [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on code in PR #7486:
URL: https://github.com/apache/cloudstack/pull/7486#discussion_r1377753495
##########
agent/src/main/java/com/cloud/agent/dao/impl/PropertiesStorage.java:
##########
@@ -92,11 +92,11 @@ public synchronized boolean configure(String name, Map<String, Object> params) {
file = new File(path);
try {
if (!file.createNewFile()) {
- s_logger.error("Unable to create _file: " + file.getAbsolutePath());
+ s_logger.error(String.format("Unable to create _file: %s", file.getAbsolutePath()));
return false;
}
} catch (IOException e) {
- s_logger.error("Unable to create _file: " + file.getAbsolutePath(), e);
+ s_logger.error(String.format("Unable to create _file: %s", file.getAbsolutePath()), e);
Review Comment:
```suggestion
s_logger.error(String.format("Unable to create file: %s", file.getAbsolutePath()));
if (s_logger.isDebugEnabled()) {
s_logger.bedug(String.format("IOException while trying to create file: %s", file.getAbsolutePath()), e);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improved concatenation way in PropertiesStorage.java [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #7486:
URL: https://github.com/apache/cloudstack/pull/7486#issuecomment-1787390130
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] soreana commented on pull request #7486: [MINOR][Enhancement] improved concatenation way in PropertiesStorage.java
Posted by "soreana (via GitHub)" <gi...@apache.org>.
soreana commented on PR #7486:
URL: https://github.com/apache/cloudstack/pull/7486#issuecomment-1742127259
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] soreana commented on pull request #7486: [MINOR][Enhancement] improved concatenation way in PropertiesStorage.java
Posted by "soreana (via GitHub)" <gi...@apache.org>.
soreana commented on PR #7486:
URL: https://github.com/apache/cloudstack/pull/7486#issuecomment-1742193367
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MINOR][Enhancement] improved concatenation way in PropertiesStorage.java [cloudstack]
Posted by "soreana (via GitHub)" <gi...@apache.org>.
soreana commented on PR #7486:
URL: https://github.com/apache/cloudstack/pull/7486#issuecomment-1743470508
@nikam14 Can you please address @GutoVeronezi 's comments?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #7486: [MINOR][Enhancement] improved concatenation way in PropertiesStorage.java
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on PR #7486:
URL: https://github.com/apache/cloudstack/pull/7486#issuecomment-1558566257
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7486: [MINOR][Enhancement] improved concatenation way in PropertiesStorage.java
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7486:
URL: https://github.com/apache/cloudstack/pull/7486#issuecomment-1558566707
@rohityadavcloud a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7486: [MINOR][Enhancement] improved concatenation way in PropertiesStorage.java
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7486:
URL: https://github.com/apache/cloudstack/pull/7486#issuecomment-1558770072
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6115
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7486: [MINOR][Enhancement] improved concatenation way in PropertiesStorage.java
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7486:
URL: https://github.com/apache/cloudstack/pull/7486#issuecomment-1742193690
@soreana a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improved concatenation way in PropertiesStorage.java [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on code in PR #7486:
URL: https://github.com/apache/cloudstack/pull/7486#discussion_r1378565390
##########
agent/src/main/java/com/cloud/agent/dao/impl/PropertiesStorage.java:
##########
@@ -92,11 +92,11 @@ public synchronized boolean configure(String name, Map<String, Object> params) {
file = new File(path);
try {
if (!file.createNewFile()) {
- s_logger.error("Unable to create _file: " + file.getAbsolutePath());
+ s_logger.error(String.format("Unable to create _file: %s", file.getAbsolutePath()));
return false;
}
} catch (IOException e) {
- s_logger.error("Unable to create _file: " + file.getAbsolutePath(), e);
+ s_logger.error(String.format("Unable to create _file: %s", file.getAbsolutePath()), e);
Review Comment:
can you concur @nikam14 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improved concatenation way in PropertiesStorage.java [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland merged PR #7486:
URL: https://github.com/apache/cloudstack/pull/7486
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7486: [MINOR][Enhancement] improved concatenation way in PropertiesStorage.java
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7486:
URL: https://github.com/apache/cloudstack/pull/7486#issuecomment-1742207393
Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 7183
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7486: [MINOR][Enhancement] improved concatenation way in PropertiesStorage.java
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7486:
URL: https://github.com/apache/cloudstack/pull/7486#issuecomment-1742128725
@soreana a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7486: [MINOR][Enhancement] improved concatenation way in PropertiesStorage.java
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7486:
URL: https://github.com/apache/cloudstack/pull/7486#issuecomment-1741860136
@soreana a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] soreana commented on pull request #7486: [MINOR][Enhancement] improved concatenation way in PropertiesStorage.java
Posted by "soreana (via GitHub)" <gi...@apache.org>.
soreana commented on PR #7486:
URL: https://github.com/apache/cloudstack/pull/7486#issuecomment-1741859936
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nikam14 commented on a diff in pull request #7486: [MINOR][Enhancement] improved concatenation way in PropertiesStorage.java
Posted by "nikam14 (via GitHub)" <gi...@apache.org>.
nikam14 commented on code in PR #7486:
URL: https://github.com/apache/cloudstack/pull/7486#discussion_r1188325799
##########
agent/src/main/java/com/cloud/agent/dao/impl/PropertiesStorage.java:
##########
@@ -92,11 +92,11 @@ public synchronized boolean configure(String name, Map<String, Object> params) {
file = new File(path);
try {
if (!file.createNewFile()) {
- s_logger.error("Unable to create _file: " + file.getAbsolutePath());
+ s_logger.error("Unable to create _file: ".concat(file.getAbsolutePath()));
Review Comment:
thank you for your suggestion , I will change it .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org