You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/02/25 04:32:30 UTC
[GitHub] [flink] JingsongLi opened a new pull request #11205:
[FLINK-16265][table] Use LogicalType to equals in TableSchema
JingsongLi opened a new pull request #11205: [FLINK-16265][table] Use LogicalType to equals in TableSchema
URL: https://github.com/apache/flink/pull/11205
## What is the purpose of the change
```
- name: TableNumber2
type: source
$VAR_UPDATE_MODE
schema:
- name: IntegerField2
type: INT
- name: StringField2
type: VARCHAR
- name: TimestampField3
type: TIMESTAMP
connector:
type: filesystem
path: "$VAR_SOURCE_PATH2"
format:
type: csv
fields:
- name: IntegerField2
type: INT
- name: StringField2
type: VARCHAR
- name: TimestampField3
type: TIMESTAMP
line-delimiter: "\n"
comment-prefix: "#"
```
Table like this will fail in SQL-CLI.
The root cause is we will convert the properties into CatalogTableImpl and then convert into properties again. The schema type properties will use new type systems then which is not equal to the legacy types.
## Brief change log
I think the fix we can do could be comparing LogicalType in TableSchema.equals/hashCode instead of DataType with conversion classes.
## Verifying this change
`LocalExecutorITCase`
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11205: [FLINK-16265][table]
Use LogicalType to equals in TableSchema
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11205: [FLINK-16265][table] Use LogicalType to equals in TableSchema
URL: https://github.com/apache/flink/pull/11205#issuecomment-590680897
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "453d2f6811975cdd4d0826b64adc08dfd5192af4",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "453d2f6811975cdd4d0826b64adc08dfd5192af4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 453d2f6811975cdd4d0826b64adc08dfd5192af4 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wuchong commented on issue #11205: [FLINK-16265][table] Use
LogicalType to equals in TableSchema
Posted by GitBox <gi...@apache.org>.
wuchong commented on issue #11205: [FLINK-16265][table] Use LogicalType to equals in TableSchema
URL: https://github.com/apache/flink/pull/11205#issuecomment-590690935
I'm still not sure about this approach. Because the DataType stored in the TableSchema may still hold the different conversion classes.
Btw, if we want to go with this approach, we should create another JIRA issue to have an explicit title and a `Table SQL/API` module. Otherwise, the API change is too silent.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11205: [FLINK-16265][table]
Use LogicalType to equals in TableSchema
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11205: [FLINK-16265][table] Use LogicalType to equals in TableSchema
URL: https://github.com/apache/flink/pull/11205#issuecomment-590678898
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 453d2f6811975cdd4d0826b64adc08dfd5192af4 (Tue Feb 25 04:35:27 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] JingsongLi commented on issue #11205: [FLINK-16265][table]
Use LogicalType to equals in TableSchema
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on issue #11205: [FLINK-16265][table] Use LogicalType to equals in TableSchema
URL: https://github.com/apache/flink/pull/11205#issuecomment-590694517
> I'm still not sure about this approach. Because the DataType stored in the TableSchema may still hold the different conversion classes.
>
> Btw, if we want to go with this approach, we should create another JIRA issue to have an explicit title and a `Table SQL/API` module. Otherwise, the API change is too silent.
Created https://issues.apache.org/jira/browse/FLINK-16270 .
This is a pit, if not repaired, I think it will lead to more problems.
Conversion classes should not exist in `TableSchema`, but for legacy planner, it is hard to remove this.
The origin of this problem is in `DescriptorProperties`, it not serialize conversion classes in `TableSchema`. After `putTableSchema` and `getTableSchema`, conversion classes changed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11205:
[FLINK-16265][table] Use LogicalType to equals in TableSchema
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11205: [FLINK-16265][table] Use LogicalType to equals in TableSchema
URL: https://github.com/apache/flink/pull/11205#issuecomment-590680897
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "453d2f6811975cdd4d0826b64adc08dfd5192af4",
"status" : "PENDING",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150418415",
"triggerID" : "453d2f6811975cdd4d0826b64adc08dfd5192af4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 453d2f6811975cdd4d0826b64adc08dfd5192af4 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/150418415)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11205:
[FLINK-16265][table] Use LogicalType to equals in TableSchema
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11205: [FLINK-16265][table] Use LogicalType to equals in TableSchema
URL: https://github.com/apache/flink/pull/11205#issuecomment-590680897
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "453d2f6811975cdd4d0826b64adc08dfd5192af4",
"status" : "FAILURE",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150418415",
"triggerID" : "453d2f6811975cdd4d0826b64adc08dfd5192af4",
"triggerType" : "PUSH"
}, {
"hash" : "453d2f6811975cdd4d0826b64adc08dfd5192af4",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5541",
"triggerID" : "453d2f6811975cdd4d0826b64adc08dfd5192af4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 453d2f6811975cdd4d0826b64adc08dfd5192af4 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/150418415) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5541)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wuchong commented on issue #11205: [FLINK-16265][table] Use
LogicalType to equals in TableSchema
Posted by GitBox <gi...@apache.org>.
wuchong commented on issue #11205: [FLINK-16265][table] Use LogicalType to equals in TableSchema
URL: https://github.com/apache/flink/pull/11205#issuecomment-590696428
If the `TableSchema` only accept/store new types, I think it's fine to refactor the equals. However, as you said, legacy planner is still using the old types in TableSchema. That's why I'm not sure whether there is problem to refactor equals.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] JingsongLi closed pull request #11205: [FLINK-16265][table]
Use LogicalType to equals in TableSchema
Posted by GitBox <gi...@apache.org>.
JingsongLi closed pull request #11205: [FLINK-16265][table] Use LogicalType to equals in TableSchema
URL: https://github.com/apache/flink/pull/11205
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] JingsongLi commented on issue #11205: [FLINK-16265][table]
Use LogicalType to equals in TableSchema
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on issue #11205: [FLINK-16265][table] Use LogicalType to equals in TableSchema
URL: https://github.com/apache/flink/pull/11205#issuecomment-590698568
> If the `TableSchema` only accept/store new types, I think it's fine to refactor the equals. However, as you said, legacy planner is still using the old types in TableSchema. That's why I'm not sure whether there is problem to refactor equals.
Whether it's legacy or blink, conversion classes in `TableSchema` have no actual meaning.
The role of conversion classes in legacy planner is to get the old `SqlTimestampTypeInfo`. Not mean it treats different conversion classes differently.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services