You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by GitBox <gi...@apache.org> on 2021/08/04 16:10:11 UTC
[GitHub] [brooklyn-ui] jathanasiou opened a new pull request #261: Fixed Composer required label check
jathanasiou opened a new pull request #261:
URL: https://github.com/apache/brooklyn-ui/pull/261
Default values were not being checked properly from Parameters and Configuration fields erroneously had *required* label
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [brooklyn-ui] ahgittin commented on pull request #261: Fixed Composer required label check
Posted by GitBox <gi...@apache.org>.
ahgittin commented on pull request #261:
URL: https://github.com/apache/brooklyn-ui/pull/261#issuecomment-893420836
aha this is part of the fix -- `parameter` uses `default` -- however _config_ key definitions use `defaultValue` so this will break for defaults coming from the server-side model (eg parent class). and there are other places we use `defaultValue` where we should be checking both `defaultValue` and `default`. will open follow-on PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [brooklyn-ui] iuliana commented on pull request #261: Fixed Composer required label check
Posted by GitBox <gi...@apache.org>.
iuliana commented on pull request #261:
URL: https://github.com/apache/brooklyn-ui/pull/261#issuecomment-893335498
The test failure is not related to the changes. I will merge this, because I am pretty confident it won't break anything, but move things forward on other issues being worked on.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [brooklyn-ui] iuliana merged pull request #261: Fixed Composer required label check
Posted by GitBox <gi...@apache.org>.
iuliana merged pull request #261:
URL: https://github.com/apache/brooklyn-ui/pull/261
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [brooklyn-ui] iuliana merged pull request #261: Fixed Composer required label check
Posted by GitBox <gi...@apache.org>.
iuliana merged pull request #261:
URL: https://github.com/apache/brooklyn-ui/pull/261
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [brooklyn-ui] iuliana commented on pull request #261: Fixed Composer required label check
Posted by GitBox <gi...@apache.org>.
iuliana commented on pull request #261:
URL: https://github.com/apache/brooklyn-ui/pull/261#issuecomment-893335498
The test failure is not related to the changes. I will merge this, because I am pretty confident it won't break anything, but move things forward on other issues being worked on.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org