You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by wu...@apache.org on 2021/03/26 06:59:17 UTC
[servicecomb-java-chassis] 02/02: [SCB-2216]fix review comments
This is an automated email from the ASF dual-hosted git repository.
wujimin pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/servicecomb-java-chassis.git
commit 0b46b0fabc1c9f5aa1905ce0697d02e389e31b92
Author: liubao68 <bi...@qq.com>
AuthorDate: Fri Mar 26 09:33:38 2021 +0800
[SCB-2216]fix review comments
---
.../org/apache/servicecomb/transport/highway/HighwayClientFilter.java | 2 +-
.../org/apache/servicecomb/transport/rest/client/RestClientSender.java | 2 +-
.../servicecomb/transport/rest/client/RestClientSenderFilter.java | 2 --
3 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/transports/transport-highway/src/main/java/org/apache/servicecomb/transport/highway/HighwayClientFilter.java b/transports/transport-highway/src/main/java/org/apache/servicecomb/transport/highway/HighwayClientFilter.java
index fdd7a3e..ccebe79 100644
--- a/transports/transport-highway/src/main/java/org/apache/servicecomb/transport/highway/HighwayClientFilter.java
+++ b/transports/transport-highway/src/main/java/org/apache/servicecomb/transport/highway/HighwayClientFilter.java
@@ -62,7 +62,7 @@ public class HighwayClientFilter implements ConsumerFilter {
}
protected CompletableFuture<TcpData> send(Invocation invocation, OperationProtobuf operationProtobuf) {
- invocation.getInvocationStageTrace().startSend();
+ invocation.onStartSendRequest();
HighwayClient highwayClient = ((HighwayTransport) invocation.getTransport()).getHighwayClient();
HighwayClientPackage clientPackage = highwayClient.createClientPackage(invocation, operationProtobuf);
diff --git a/transports/transport-rest/transport-rest-client/src/main/java/org/apache/servicecomb/transport/rest/client/RestClientSender.java b/transports/transport-rest/transport-rest-client/src/main/java/org/apache/servicecomb/transport/rest/client/RestClientSender.java
index caa62b4..558245e 100644
--- a/transports/transport-rest/transport-rest-client/src/main/java/org/apache/servicecomb/transport/rest/client/RestClientSender.java
+++ b/transports/transport-rest/transport-rest-client/src/main/java/org/apache/servicecomb/transport/rest/client/RestClientSender.java
@@ -65,7 +65,7 @@ public class RestClientSender {
@SuppressWarnings("deprecation")
public CompletableFuture<Response> send() {
- invocation.getInvocationStageTrace().startSend();
+ invocation.onStartSendRequest();
httpClientRequest.exceptionHandler(future::completeExceptionally);
httpClientRequest.handler(this::processResponse);
diff --git a/transports/transport-rest/transport-rest-client/src/main/java/org/apache/servicecomb/transport/rest/client/RestClientSenderFilter.java b/transports/transport-rest/transport-rest-client/src/main/java/org/apache/servicecomb/transport/rest/client/RestClientSenderFilter.java
index 84e8baa..d5c2bd4 100644
--- a/transports/transport-rest/transport-rest-client/src/main/java/org/apache/servicecomb/transport/rest/client/RestClientSenderFilter.java
+++ b/transports/transport-rest/transport-rest-client/src/main/java/org/apache/servicecomb/transport/rest/client/RestClientSenderFilter.java
@@ -38,8 +38,6 @@ public class RestClientSenderFilter implements ConsumerFilter {
@Override
public CompletableFuture<Response> onFilter(Invocation invocation, FilterNode nextNode) {
- invocation.onStartSendRequest();
-
CompletableFuture<Response> future = new RestClientSender(invocation)
.send();