You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by ja...@apache.org on 2026/10/13 11:03:04 UTC

(lucene) branch branch_10x updated: Deprecate VectorValueSource and MultiValueSource (#16813)

This is an automated email from the ASF dual-hosted git repository.

javanna pushed a commit to branch branch_10x
in repository https://gitbox.apache.org/repos/asf/lucene.git


The following commit(s) were added to refs/heads/branch_10x by this push:
     new 892b361df0c Deprecate VectorValueSource and MultiValueSource (#16813)
892b361df0c is described below

commit 892b361df0c192bea669c2e9816881010545a620
Author: Luca Cavanna <ja...@apache.org>
AuthorDate: Tue Oct 13 13:02:55 2026 +0200

    Deprecate VectorValueSource and MultiValueSource (#16813)
    
    These classes are part of the public API but have fallen unused and unmaintained
---
 lucene/CHANGES.txt                                                    | 2 ++
 .../apache/lucene/queries/function/valuesource/MultiValueSource.java  | 3 +++
 .../apache/lucene/queries/function/valuesource/VectorValueSource.java | 4 +++-
 3 files changed, 8 insertions(+), 1 deletion(-)

diff --git a/lucene/CHANGES.txt b/lucene/CHANGES.txt
index 2ab31803784..828722dd7c0 100644
--- a/lucene/CHANGES.txt
+++ b/lucene/CHANGES.txt
@@ -30,6 +30,8 @@ API Changes
 
 * GITHUB#16647: Add KnnVectorsReader.getVectorCount to read vector counts from metadata (Chris Hegarty)
 
+* GITHUB#16813: Deprecate unused VectorValueSource and MultiValueSource. (Luca Cavanna)
+
 New Features
 ---------------------
 * GITHUB#16722: Support user dictionary in ThaiTokenizer and ThaiTokenizerFactory.
diff --git a/lucene/queries/src/java/org/apache/lucene/queries/function/valuesource/MultiValueSource.java b/lucene/queries/src/java/org/apache/lucene/queries/function/valuesource/MultiValueSource.java
index 35c72edc87c..f80470d5aa0 100644
--- a/lucene/queries/src/java/org/apache/lucene/queries/function/valuesource/MultiValueSource.java
+++ b/lucene/queries/src/java/org/apache/lucene/queries/function/valuesource/MultiValueSource.java
@@ -21,7 +21,10 @@ import org.apache.lucene.queries.function.ValueSource;
 /**
  * A {@link ValueSource} that abstractly represents {@link ValueSource}s for poly fields, and other
  * things.
+ *
+ * @deprecated unused and will be removed
  */
+@Deprecated
 public abstract class MultiValueSource extends ValueSource {
 
   public abstract int dimension();
diff --git a/lucene/queries/src/java/org/apache/lucene/queries/function/valuesource/VectorValueSource.java b/lucene/queries/src/java/org/apache/lucene/queries/function/valuesource/VectorValueSource.java
index 3ec560759d5..5a4c3712dbc 100644
--- a/lucene/queries/src/java/org/apache/lucene/queries/function/valuesource/VectorValueSource.java
+++ b/lucene/queries/src/java/org/apache/lucene/queries/function/valuesource/VectorValueSource.java
@@ -28,8 +28,10 @@ import org.apache.lucene.search.IndexSearcher;
  * Converts individual ValueSource instances to leverage the FunctionValues *Val functions that work
  * with multiple values, i.e. {@link
  * org.apache.lucene.queries.function.FunctionValues#doubleVal(int, double[])}
+ *
+ * @deprecated unused and will be removed
  */
-// Not crazy about the name, but...
+@Deprecated
 public class VectorValueSource extends MultiValueSource {
   protected final List<ValueSource> sources;