You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by jo...@apache.org on 2019/08/06 07:54:24 UTC
svn commit: r1864464 - in /httpd/httpd/trunk/modules/filters:
mod_proxy_html.c mod_xml2enc.c
Author: jorton
Date: Tue Aug 6 07:54:24 2019
New Revision: 1864464
URL: http://svn.apache.org/viewvc?rev=1864464&view=rev
Log:
* modules/filters/mod_proxy_html.c, modules/filters/mod_xml2enc.c:
Fix gcc 9 warnings in code attempting to reduce gcc warnings.
(should have used expat...)
mod_xml2enc.c:26:28: warning: "/*" within comment [-Wcomment]
26 | /* libxml2 includes unicode/*.h files which uses C++ comments */
|
mod_proxy_html.c:32:28: warning: "/*" within comment [-Wcomment]
32 | /* libxml2 includes unicode/*.h files which uses C++ comments */
|
Modified:
httpd/httpd/trunk/modules/filters/mod_proxy_html.c
httpd/httpd/trunk/modules/filters/mod_xml2enc.c
Modified: httpd/httpd/trunk/modules/filters/mod_proxy_html.c
URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/filters/mod_proxy_html.c?rev=1864464&r1=1864463&r2=1864464&view=diff
==============================================================================
--- httpd/httpd/trunk/modules/filters/mod_proxy_html.c (original)
+++ httpd/httpd/trunk/modules/filters/mod_proxy_html.c Tue Aug 6 07:54:24 2019
@@ -29,7 +29,7 @@
#define VERBOSEB(x) if (verbose) {x}
#endif
-/* libxml2 includes unicode/*.h files which uses C++ comments */
+/* libxml2 includes unicode/[...].h files which uses C++ comments */
#if defined(__GNUC__)
#if __GNUC__ > 4 || (__GNUC__ == 4 && __GNUC_MINOR__ >= 6)
#pragma GCC diagnostic push
Modified: httpd/httpd/trunk/modules/filters/mod_xml2enc.c
URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/filters/mod_xml2enc.c?rev=1864464&r1=1864463&r2=1864464&view=diff
==============================================================================
--- httpd/httpd/trunk/modules/filters/mod_xml2enc.c (original)
+++ httpd/httpd/trunk/modules/filters/mod_xml2enc.c Tue Aug 6 07:54:24 2019
@@ -23,7 +23,7 @@
#include <ctype.h>
-/* libxml2 includes unicode/*.h files which uses C++ comments */
+/* libxml2 includes unicode/[...].h files which uses C++ comments */
#if defined(__GNUC__)
#if __GNUC__ > 4 || (__GNUC__ == 4 && __GNUC_MINOR__ >= 6)
#pragma GCC diagnostic push
Re: svn commit: r1864464 - in /httpd/httpd/trunk/modules/filters:
mod_proxy_html.c mod_xml2enc.c
Posted by Joe Orton <jo...@redhat.com>.
On Tue, Aug 06, 2019 at 09:57:50AM +0200, Rainer Jung wrote:
> Thank you. It's funny, that the warning happens directly before the new
> pragma use to influence -Wcomment ...
No worries, quite a funny one indeed ;)
Re: svn commit: r1864464 - in /httpd/httpd/trunk/modules/filters:
mod_proxy_html.c mod_xml2enc.c
Posted by Rainer Jung <ra...@kippdata.de>.
Thank you. It's funny, that the warning happens directly before the new
pragma use to influence -Wcomment ...
Regards,
Rainer
Am 06.08.2019 um 09:54 schrieb jorton@apache.org:
> Author: jorton
> Date: Tue Aug 6 07:54:24 2019
> New Revision: 1864464
>
> URL: http://svn.apache.org/viewvc?rev=1864464&view=rev
> Log:
> * modules/filters/mod_proxy_html.c, modules/filters/mod_xml2enc.c:
> Fix gcc 9 warnings in code attempting to reduce gcc warnings.
> (should have used expat...)
>
> mod_xml2enc.c:26:28: warning: "/*" within comment [-Wcomment]
> 26 | /* libxml2 includes unicode/*.h files which uses C++ comments */
> |
> mod_proxy_html.c:32:28: warning: "/*" within comment [-Wcomment]
> 32 | /* libxml2 includes unicode/*.h files which uses C++ comments */
> |
>
> Modified:
> httpd/httpd/trunk/modules/filters/mod_proxy_html.c
> httpd/httpd/trunk/modules/filters/mod_xml2enc.c
>
> Modified: httpd/httpd/trunk/modules/filters/mod_proxy_html.c
> URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/filters/mod_proxy_html.c?rev=1864464&r1=1864463&r2=1864464&view=diff
> ==============================================================================
> --- httpd/httpd/trunk/modules/filters/mod_proxy_html.c (original)
> +++ httpd/httpd/trunk/modules/filters/mod_proxy_html.c Tue Aug 6 07:54:24 2019
> @@ -29,7 +29,7 @@
> #define VERBOSEB(x) if (verbose) {x}
> #endif
>
> -/* libxml2 includes unicode/*.h files which uses C++ comments */
> +/* libxml2 includes unicode/[...].h files which uses C++ comments */
> #if defined(__GNUC__)
> #if __GNUC__ > 4 || (__GNUC__ == 4 && __GNUC_MINOR__ >= 6)
> #pragma GCC diagnostic push
>
> Modified: httpd/httpd/trunk/modules/filters/mod_xml2enc.c
> URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/filters/mod_xml2enc.c?rev=1864464&r1=1864463&r2=1864464&view=diff
> ==============================================================================
> --- httpd/httpd/trunk/modules/filters/mod_xml2enc.c (original)
> +++ httpd/httpd/trunk/modules/filters/mod_xml2enc.c Tue Aug 6 07:54:24 2019
> @@ -23,7 +23,7 @@
>
> #include <ctype.h>
>
> -/* libxml2 includes unicode/*.h files which uses C++ comments */
> +/* libxml2 includes unicode/[...].h files which uses C++ comments */
> #if defined(__GNUC__)
> #if __GNUC__ > 4 || (__GNUC__ == 4 && __GNUC_MINOR__ >= 6)
> #pragma GCC diagnostic push