You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/01/13 10:03:48 UTC
[GitHub] [camel] oscerd commented on a change in pull request #4876: [CAMEL-15961] Google Calendar synchronization flow
oscerd commented on a change in pull request #4876:
URL: https://github.com/apache/camel/pull/4876#discussion_r556400607
##########
File path: components/camel-google-calendar/src/main/java/org/apache/camel/component/google/calendar/stream/GoogleCalendarStreamConsumer.java
##########
@@ -59,19 +70,21 @@ public GoogleCalendarStreamEndpoint getEndpoint() {
@Override
protected int poll() throws Exception {
- com.google.api.services.calendar.Calendar.Events.List request
- = getClient().events().list(getConfiguration().getCalendarId()).setOrderBy("updated");
+ Calendar.Events.List request = getClient().events().list(getConfiguration().getCalendarId());
if (ObjectHelper.isNotEmpty(getConfiguration().getQuery())) {
Review comment:
Please don't use this class, we have all the tools to check this stuff the camel way
##########
File path: components/camel-google-calendar/src/main/java/org/apache/camel/component/google/calendar/stream/GoogleCalendarStreamConsumer.java
##########
@@ -59,19 +70,21 @@ public GoogleCalendarStreamEndpoint getEndpoint() {
@Override
protected int poll() throws Exception {
- com.google.api.services.calendar.Calendar.Events.List request
- = getClient().events().list(getConfiguration().getCalendarId()).setOrderBy("updated");
+ Calendar.Events.List request = getClient().events().list(getConfiguration().getCalendarId());
if (ObjectHelper.isNotEmpty(getConfiguration().getQuery())) {
+ Preconditions.checkArgument(!getConfiguration().isSyncFlow(), "query is incompatible with sync flow.");
request.setQ(getConfiguration().getQuery());
}
if (ObjectHelper.isNotEmpty(getConfiguration().getMaxResults())) {
request.setMaxResults(getConfiguration().getMaxResults());
}
- if (getConfiguration().isConsumeFromNow()) {
+ // in synchronization flow only set timeMin on first request
+ if (getConfiguration().isConsumeFromNow() && syncToken == null) {
Date date = new Date();
request.setTimeMin(new DateTime(date));
}
if (getConfiguration().isConsiderLastUpdate()) {
+ Preconditions.checkArgument(!getConfiguration().isSyncFlow(), "considerLastUpdate is incompatible with sync flow.");
Review comment:
Same
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org