You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "blackmwk (via GitHub)" <gi...@apache.org> on 2026/04/23 08:18:54 UTC

[PR] Split arrow reader into smaller modules [iceberg-rust]

blackmwk opened a new pull request, #2358:
URL: https://github.com/apache/iceberg-rust/pull/2358

   ## Which issue does this PR close?
   
   - Closes #2309  
   
   ## What changes are included in this PR?
   
   Split arrow reader module into smaller onces so that it would be easier to maintain. I didn't do any extra changes on purpose to make the pr easier to read.
   
   ## Are these changes tested?
   
   ut.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

Re: [PR] Split arrow reader into smaller modules [iceberg-rust]

Posted by "blackmwk (via GitHub)" <gi...@apache.org>.
blackmwk commented on PR #2358:
URL: https://github.com/apache/iceberg-rust/pull/2358#issuecomment-4311077969

   > Thanks for tackling this @blackmwk! My only comment is that I noticed `PredicateConverter` fields are `pub(super)` with `pub(super) column_indices: &'a Vec<usize>`. In the original they were `pub`. This is actually a tightening of visibility, which is fine. I think long term that's the right move, and now I wonder if there's anything else we should tighten visibility on, but for now this looks good.
   
   Thanks for reporting, I agree that it's fine for now to make it a crate private api.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

Re: [PR] Split arrow reader into smaller modules [iceberg-rust]

Posted by "CTTY (via GitHub)" <gi...@apache.org>.
CTTY merged PR #2358:
URL: https://github.com/apache/iceberg-rust/pull/2358


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

Re: [PR] Split arrow reader into smaller modules [iceberg-rust]

Posted by "mbutrovich (via GitHub)" <gi...@apache.org>.
mbutrovich commented on PR #2358:
URL: https://github.com/apache/iceberg-rust/pull/2358#issuecomment-4304996713

   Thanks for tackling this @blackmwk! My only comment is that I noticed `PredicateConverter` fields are `pub(super)` with `pub(super) column_indices: &'a Vec<usize>`. In the original they were `pub`. This is actually a tightening of visibility, which is fine. I think long term that's the right move, and now I wonder if there's anything else we should tighten visibility on, but for now this looks good.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org