You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/06/01 00:11:32 UTC
[GitHub] [beam] yixiaoshen opened a new pull request, #17789: [BEAM-14541]: fix Cloud Datastore Timestamp value conversion
yixiaoshen opened a new pull request, #17789:
URL: https://github.com/apache/beam/pull/17789
Current code does the conversion by first manually calculating the millis from a proto Timestamp with `long millis = time.getSeconds() * 1000 + time.getNanos() / 1000`, but 1 millisecond = 1,000,000 nanoseconds instead of 1,000. This PR changes to use proto Timestamps util class to do the conversion in order to be less prone to such mistakes.
R: @chamikaramj
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] yixiaoshen commented on pull request #17789: [BEAM-14541]: fix Cloud Datastore Timestamp value conversion
Posted by GitBox <gi...@apache.org>.
yixiaoshen commented on PR #17789:
URL: https://github.com/apache/beam/pull/17789#issuecomment-1147691748
R: @pcostell
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] asf-ci commented on pull request #17789: [BEAM-14541]: fix Cloud Datastore Timestamp value conversion
Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #17789:
URL: https://github.com/apache/beam/pull/17789#issuecomment-1142819833
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] asf-ci commented on pull request #17789: [BEAM-14541]: fix Cloud Datastore Timestamp value conversion
Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #17789:
URL: https://github.com/apache/beam/pull/17789#issuecomment-1142819834
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pcostell commented on pull request #17789: [BEAM-14541]: fix Cloud Datastore Timestamp value conversion
Posted by GitBox <gi...@apache.org>.
pcostell commented on PR #17789:
URL: https://github.com/apache/beam/pull/17789#issuecomment-1147712666
LGTM from Datastore
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] chamikaramj commented on pull request #17789: [BEAM-14541]: fix Cloud Datastore Timestamp value conversion
Posted by GitBox <gi...@apache.org>.
chamikaramj commented on PR #17789:
URL: https://github.com/apache/beam/pull/17789#issuecomment-1151572146
Run Java PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] chamikaramj commented on pull request #17789: [BEAM-14541]: fix Cloud Datastore Timestamp value conversion
Posted by GitBox <gi...@apache.org>.
chamikaramj commented on PR #17789:
URL: https://github.com/apache/beam/pull/17789#issuecomment-1150200103
LGTM. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] asf-ci commented on pull request #17789: [BEAM-14541]: fix Cloud Datastore Timestamp value conversion
Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #17789:
URL: https://github.com/apache/beam/pull/17789#issuecomment-1142819842
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] chamikaramj commented on pull request #17789: [BEAM-14541]: fix Cloud Datastore Timestamp value conversion
Posted by GitBox <gi...@apache.org>.
chamikaramj commented on PR #17789:
URL: https://github.com/apache/beam/pull/17789#issuecomment-1150200937
Run Java PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] chamikaramj commented on pull request #17789: [BEAM-14541]: fix Cloud Datastore Timestamp value conversion
Posted by GitBox <gi...@apache.org>.
chamikaramj commented on PR #17789:
URL: https://github.com/apache/beam/pull/17789#issuecomment-1150388379
Run Java PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] chamikaramj merged pull request #17789: [BEAM-14541]: fix Cloud Datastore Timestamp value conversion
Posted by GitBox <gi...@apache.org>.
chamikaramj merged PR #17789:
URL: https://github.com/apache/beam/pull/17789
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org