You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2021/11/16 18:56:57 UTC
[GitHub] [solr] madrob commented on a change in pull request #419: SOLR-15800: Add ref-guide upload to the release wizard.
madrob commented on a change in pull request #419:
URL: https://github.com/apache/solr/pull/419#discussion_r750571906
##########
File path: dev-tools/scripts/releaseWizard.yaml
##########
@@ -1067,6 +1067,70 @@ groups:
cmd: svn -m "Add docs, changes and javadocs for Solr {{ release_version }}" import {{ git_checkout_folder }}/solr/build/docs https://svn.apache.org/repos/infra/sites/solr/docs/{{ version }}
logfile: add-docs-solr.log
comment: Add docs for Solr
+ - !Todo
+ id: build_final_ref_guide
+ title: Build the ref guide
+ links:
+ - https://solr.apache.org/guide/{{ release_version_refguide }}
+ commands: !Commands
+ root_folder: '{{ git_checkout_folder }}'
+ commands_text: Build the Solr Ref Guide
+ commands:
+ - !Command
+ cmd: "{{ gradle_cmd }} solr:solr-ref-guide:clean"
+ comment: Clean the Ref Guide build
+ - !Command
+ cmd: "{{ gradle_cmd }} solr:solr-ref-guide:buildSite -PsolrGuideDraft=false"
+ comment: Build Ref Guide
+ - !Todo
+ id: upload_final_ref_guide
+ title: Upload the ref guide
+ links:
+ - https://solr.apache.org/guide/{{ release_version_refguide }}
+ depends:
+ - build_final_ref_guide
+ types:
+ - major
+ - minor
+ commands: !Commands
+ root_folder: '{{ git_checkout_folder }}'
+ commands_text: Upload the Solr Ref Guide to SVN production tree
+ commands:
+ - !Command
+ cmd: svn -m "Add Solr Ref Guide {{ release_version }}" import {{ git_checkout_folder }}/solr/solr-ref-guide/build/html-site https://svn.apache.org/repos/infra/sites/solr/guide/{{ release_version_refguide }}
+ logfile: add-docs-solr.log
+ comment: Upload Solr Ref Guide
+ - !Todo
+ id: upload_final_ref_guide
+ title: Upload (and overwrite-write) the ref guide
+ links:
+ - https://solr.apache.org/guide/{{ release_version_refguide }}
+ depends:
+ - build_final_ref_guide
+ types:
+ - patch
+ commands: !Commands
+ root_folder: '{{ ref_guide_svn_folder }}'
+ commands_text: Upload the Solr Ref Guide to SVN production tree, overwriting the previous version
+ commands:
+ - !Command
+ cmd: svn co https://svn.apache.org/repos/infra/sites/solr/guide/{{ release_version_refguide }} "{{ ref_guide_svn_folder }}"
+ logfile: ref-guide-svn-co.log
+ comment: Checkout the existing Solr Ref Guide for version {{ ref_guide_svn_folder }}
+ root_folder: '{{ git_checkout_folder }}'
+ - !Command
+ cmd: cp -r {{ git_checkout_folder }}/solr/solr-ref-guide/build/html-site {{ ref_guide_svn_folder }}
+ comment: Copy and overwrite new Solr Ref Guide
+ root_folder: '{{ git_checkout_folder }}'
+ - !Command
+ cmd: svn status | grep '^!' | awk '{print $2}' | xargs svn delete
Review comment:
Will this prompt for confirmation? I'm a little nervous about running a blind svn delete
##########
File path: dev-tools/scripts/releaseWizard.py
##########
@@ -83,6 +83,7 @@ def expand_jinja(text, vars=None):
'script_branch': state.script_branch,
'release_folder': state.get_release_folder(),
'git_checkout_folder': state.get_git_checkout_folder(),
+ 'ref_guide_svn_folder': state.get_git_checkout_folder(),
Review comment:
```suggestion
'ref_guide_svn_folder': state.get_ref_guide_svn_folder(),
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org