[GitHub] [guacamole-client] phreakocious commented on a change in pull request #592: prompt when closing the window/tab to avoid accidents with ctrl-w

[GitBox <gi...@apache.org>]

phreakocious commented on a change in pull request #592:
URL: https://github.com/apache/guacamole-client/pull/592#discussion_r578805280



##########
File path: guacamole/src/main/webapp/app/client/controllers/clientController.js
##########
@@ -776,6 +783,8 @@ angular.module('client').controller('clientController', ['$scope', '$routeParams
 
         // Client error
         else if (connectionState === ManagedClientState.ConnectionState.CLIENT_ERROR) {
+            // Stop intercepting window close
+            $window.removeEventListener('beforeunload', ctrlwlistener, false);

Review comment:
       I'm not much of a JS programmer.. couldn't find a way to test whether there was currently a connection.  If using connection groups, it would be ideal to be prompted even if at one of the settings screens, as they could lose the connection they had if it closes.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org