[GitHub] [kafka] dengziming commented on a change in pull request #11450: KAFKA-13414: Replace Powermock/EasyMock by Mockito in connect.storage

[GitBox <gi...@apache.org>]

dengziming commented on a change in pull request #11450:
URL: https://github.com/apache/kafka/pull/11450#discussion_r739315725



##########
File path: connect/runtime/src/test/java/org/apache/kafka/connect/storage/FileOffsetBackingStoreTest.java
##########
@@ -77,21 +74,17 @@ public void teardown() {
     @Test
     public void testGetSet() throws Exception {
         Callback<Void> setCallback = expectSuccessfulSetCallback();
-        PowerMock.replayAll();
 
         store.set(firstSet, setCallback).get();
 
         Map<ByteBuffer, ByteBuffer> values = store.get(Arrays.asList(buffer("key"), buffer("bad"))).get();
         assertEquals(buffer("value"), values.get(buffer("key")));
         assertNull(values.get(buffer("bad")));
-
-        PowerMock.verifyAll();

Review comment:
       The following comments also apply for other changes:
   should we call `Mockito.verify(setCallback).onCompletion()` here?
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org