You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/02/10 18:52:27 UTC

[GitHub] [incubator-tvm] Laurawly opened a new pull request #4853: [Fix] reverse some changes made for `intel_graphics/conv2d.py` in PR #4849

Laurawly opened a new pull request #4853: [Fix] reverse some changes made for `intel_graphics/conv2d.py` in PR #4849
URL: https://github.com/apache/incubator-tvm/pull/4853
 
 
   In recent PR $4849,  code after line 51 was mistakenly moved under the for loop in [line 48](https://github.com/apache/incubator-tvm/commit/b528acc143dd8a09b322ba0845743e18ae206e22#diff-f42aee9848a02ce033e17e390757f49bL48), which caused problems for `tile_ic` and other `cfg` params not defined when output channel size is a multiple of 16. In this PR, we correct this change.
   @comaniac @tqchen 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-tvm] tqchen commented on issue #4853: [Fix] reverse some changes made for intel_graphics/conv2d.py in PR #4849

Posted by GitBox <gi...@apache.org>.
tqchen commented on issue #4853: [Fix] reverse some changes made for intel_graphics/conv2d.py in PR #4849
URL: https://github.com/apache/incubator-tvm/pull/4853#issuecomment-584296417
 
 
   sorry for the oversight

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-tvm] tqchen merged pull request #4853: [Fix] reverse some changes made for intel_graphics/conv2d.py in PR #4849

Posted by GitBox <gi...@apache.org>.
tqchen merged pull request #4853: [Fix] reverse some changes made for intel_graphics/conv2d.py in PR #4849
URL: https://github.com/apache/incubator-tvm/pull/4853
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services