You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by "Jarek Gawor (JIRA)" <ji...@apache.org> on 2012/10/04 22:15:47 UTC

[jira] [Created] (GERONIMODEVTOOLS-804) Remove unused come from 3.0 plugin

Jarek Gawor created GERONIMODEVTOOLS-804:
--------------------------------------------

             Summary: Remove unused come from 3.0 plugin
                 Key: GERONIMODEVTOOLS-804
                 URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-804
             Project: Geronimo-Devtools
          Issue Type: Improvement
          Components: eclipse-plugin
    Affects Versions: 3.0
            Reporter: Jarek Gawor
            Assignee: Jarek Gawor


There is a lot of code in the 3.0 version of the plugin that will never be used. Code that checks and does slightly different things based on different Geronimo server runtime version. Since the 3.0 set of plugins only work with 3.0 version of the server there is no need for this extra code.


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (GERONIMODEVTOOLS-804) Remove unused code from 3.0 plugin

Posted by "Johannes Weberhofer (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13470212#comment-13470212 ] 

Johannes Weberhofer commented on GERONIMODEVTOOLS-804:
------------------------------------------------------

Will it still be possible to manage older Geronimo versions with the plugin?
                
> Remove unused code from 3.0 plugin
> ----------------------------------
>
>                 Key: GERONIMODEVTOOLS-804
>                 URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-804
>             Project: Geronimo-Devtools
>          Issue Type: Improvement
>          Components: eclipse-plugin
>    Affects Versions: 3.0
>            Reporter: Jarek Gawor
>            Assignee: Jarek Gawor
>
> There is a lot of code in the 3.0 version of the plugin that will never be used. Code that checks and does slightly different things based on different Geronimo server runtime version. Since the 3.0 set of plugins only work with 3.0 version of the server there is no need for this extra code.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (GERONIMODEVTOOLS-804) Remove unused code from 3.0 plugin

Posted by "Jarek Gawor (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jarek Gawor updated GERONIMODEVTOOLS-804:
-----------------------------------------

    Summary: Remove unused code from 3.0 plugin  (was: Remove unused come from 3.0 plugin)
    
> Remove unused code from 3.0 plugin
> ----------------------------------
>
>                 Key: GERONIMODEVTOOLS-804
>                 URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-804
>             Project: Geronimo-Devtools
>          Issue Type: Improvement
>          Components: eclipse-plugin
>    Affects Versions: 3.0
>            Reporter: Jarek Gawor
>            Assignee: Jarek Gawor
>
> There is a lot of code in the 3.0 version of the plugin that will never be used. Code that checks and does slightly different things based on different Geronimo server runtime version. Since the 3.0 set of plugins only work with 3.0 version of the server there is no need for this extra code.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (GERONIMODEVTOOLS-804) Remove unused code from 3.0 plugin

Posted by "Jarek Gawor (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13470347#comment-13470347 ] 

Jarek Gawor commented on GERONIMODEVTOOLS-804:
----------------------------------------------

Yes. What I meant to say is that there is some 3.0 specific code that only works for 3.0 runtime but it had some logic for older runtimes. And that logic for older runtime would never be executed. 

                
> Remove unused code from 3.0 plugin
> ----------------------------------
>
>                 Key: GERONIMODEVTOOLS-804
>                 URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-804
>             Project: Geronimo-Devtools
>          Issue Type: Improvement
>          Components: eclipse-plugin
>    Affects Versions: 3.0
>            Reporter: Jarek Gawor
>            Assignee: Jarek Gawor
>
> There is a lot of code in the 3.0 version of the plugin that will never be used. Code that checks and does slightly different things based on different Geronimo server runtime version. Since the 3.0 set of plugins only work with 3.0 version of the server there is no need for this extra code.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (GERONIMODEVTOOLS-804) Remove unused code from 3.0 plugin

Posted by "Jarek Gawor (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jarek Gawor resolved GERONIMODEVTOOLS-804.
------------------------------------------

       Resolution: Fixed
    Fix Version/s: 3.0.1

Resolving as the unused code is now removed.  

                
> Remove unused code from 3.0 plugin
> ----------------------------------
>
>                 Key: GERONIMODEVTOOLS-804
>                 URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-804
>             Project: Geronimo-Devtools
>          Issue Type: Improvement
>          Components: eclipse-plugin
>    Affects Versions: 3.0
>            Reporter: Jarek Gawor
>            Assignee: Jarek Gawor
>             Fix For: 3.0.1
>
>
> There is a lot of code in the 3.0 version of the plugin that will never be used. Code that checks and does slightly different things based on different Geronimo server runtime version. Since the 3.0 set of plugins only work with 3.0 version of the server there is no need for this extra code.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (GERONIMODEVTOOLS-804) Remove unused code from 3.0 plugin

Posted by "Jarek Gawor (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13470023#comment-13470023 ] 

Jarek Gawor commented on GERONIMODEVTOOLS-804:
----------------------------------------------

Committed initial changes in revision 1394359.

                
> Remove unused code from 3.0 plugin
> ----------------------------------
>
>                 Key: GERONIMODEVTOOLS-804
>                 URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-804
>             Project: Geronimo-Devtools
>          Issue Type: Improvement
>          Components: eclipse-plugin
>    Affects Versions: 3.0
>            Reporter: Jarek Gawor
>            Assignee: Jarek Gawor
>
> There is a lot of code in the 3.0 version of the plugin that will never be used. Code that checks and does slightly different things based on different Geronimo server runtime version. Since the 3.0 set of plugins only work with 3.0 version of the server there is no need for this extra code.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira