You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Jesse Yates (JIRA)" <ji...@apache.org> on 2012/05/08 20:55:51 UTC
[jira] [Created] (HBASE-5961) New standard HBase code formatter
Jesse Yates created HBASE-5961:
----------------------------------
Summary: New standard HBase code formatter
Key: HBASE-5961
URL: https://issues.apache.org/jira/browse/HBASE-5961
Project: HBase
Issue Type: Improvement
Components: build
Affects Versions: 0.96.0
Reporter: Jesse Yates
Assignee: Jesse Yates
Priority: Minor
Attachments: HBase-Formmatter.xml
There is currently no good way of passing out the formmatter currently the 'standard' in HBase. The standard Apache formatter is actually not very close to what we are considering 'good'/'pretty' code. Further, its not trivial to get a good formatter setup.
Proposing two things:
1) Adding a formmatter to the dev tools and calling out the formmatter usage in the docs
2) Move to a 'better' formmatter that is not the standard apache formmatter.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5961) New standard HBase code formatter
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13270739#comment-13270739 ]
stack commented on HBASE-5961:
------------------------------
We need to check this in or do we just have the reference guide refer to this issue?
> New standard HBase code formatter
> ---------------------------------
>
> Key: HBASE-5961
> URL: https://issues.apache.org/jira/browse/HBASE-5961
> Project: HBase
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.96.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Priority: Minor
> Attachments: HBase-Formmatter.xml
>
>
> There is currently no good way of passing out the formmatter currently the 'standard' in HBase. The standard Apache formatter is actually not very close to what we are considering 'good'/'pretty' code. Further, its not trivial to get a good formatter setup.
> Proposing two things:
> 1) Adding a formmatter to the dev tools and calling out the formmatter usage in the docs
> 2) Move to a 'better' formmatter that is not the standard apache formmatter.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5961) New standard HBase code formatter
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13464131#comment-13464131 ]
stack commented on HBASE-5961:
------------------------------
Added addendum2
> New standard HBase code formatter
> ---------------------------------
>
> Key: HBASE-5961
> URL: https://issues.apache.org/jira/browse/HBASE-5961
> Project: HBase
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.96.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: 5961-addendum2.txt, 5961-addendum.txt, HBase-Formmatter.xml
>
>
> There is currently no good way of passing out the formmatter currently the 'standard' in HBase. The standard Apache formatter is actually not very close to what we are considering 'good'/'pretty' code. Further, its not trivial to get a good formatter setup.
> Proposing two things:
> 1) Adding a formmatter to the dev tools and calling out the formmatter usage in the docs
> 2) Move to a 'better' formmatter that is not the standard apache formmatter.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5961) New standard HBase code formatter
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13464270#comment-13464270 ]
Hudson commented on HBASE-5961:
-------------------------------
Integrated in HBase-TRUNK #3381 (See [https://builds.apache.org/job/HBase-TRUNK/3381/])
HBASE-5961 New standard HBase code formatter; ADDENDUM -- ADD LICENSE (Revision 1390713)
HBASE-5961 New standard HBase code formatter; ADDENDUM -- ADD RAT EXCLUSION FOR ECLIPSE FORMATTER FILE (Revision 1390703)
Result = FAILURE
stack :
Files :
* /hbase/trunk/dev-support/hbase_eclipse_formatter.xml
* /hbase/trunk/pom.xml
stack :
Files :
* /hbase/trunk/pom.xml
> New standard HBase code formatter
> ---------------------------------
>
> Key: HBASE-5961
> URL: https://issues.apache.org/jira/browse/HBASE-5961
> Project: HBase
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.96.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: 5961-addendum2.txt, 5961-addendum.txt, HBase-Formmatter.xml
>
>
> There is currently no good way of passing out the formmatter currently the 'standard' in HBase. The standard Apache formatter is actually not very close to what we are considering 'good'/'pretty' code. Further, its not trivial to get a good formatter setup.
> Proposing two things:
> 1) Adding a formmatter to the dev tools and calling out the formmatter usage in the docs
> 2) Move to a 'better' formmatter that is not the standard apache formmatter.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5961) New standard HBase code formatter
Posted by "Jesse Yates (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13462401#comment-13462401 ]
Jesse Yates commented on HBASE-5961:
------------------------------------
[~saint.ack@gmail.com] sounds good! And maybe update the book when you commit with info about where to find the formatter/template?
> New standard HBase code formatter
> ---------------------------------
>
> Key: HBASE-5961
> URL: https://issues.apache.org/jira/browse/HBASE-5961
> Project: HBase
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.96.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Priority: Minor
> Attachments: HBase-Formmatter.xml
>
>
> There is currently no good way of passing out the formmatter currently the 'standard' in HBase. The standard Apache formatter is actually not very close to what we are considering 'good'/'pretty' code. Further, its not trivial to get a good formatter setup.
> Proposing two things:
> 1) Adding a formmatter to the dev tools and calling out the formmatter usage in the docs
> 2) Move to a 'better' formmatter that is not the standard apache formmatter.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HBASE-5961) New standard HBase code formatter
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack resolved HBASE-5961.
--------------------------
Resolution: Fixed
Fix Version/s: 0.96.0
Hadoop Flags: Reviewed
Committed to trunk. Thanks for the patch Jesse.
> New standard HBase code formatter
> ---------------------------------
>
> Key: HBASE-5961
> URL: https://issues.apache.org/jira/browse/HBASE-5961
> Project: HBase
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.96.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: HBase-Formmatter.xml
>
>
> There is currently no good way of passing out the formmatter currently the 'standard' in HBase. The standard Apache formatter is actually not very close to what we are considering 'good'/'pretty' code. Further, its not trivial to get a good formatter setup.
> Proposing two things:
> 1) Adding a formmatter to the dev tools and calling out the formmatter usage in the docs
> 2) Move to a 'better' formmatter that is not the standard apache formmatter.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5961) New standard HBase code formatter
Posted by "Jesse Yates (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13463109#comment-13463109 ]
Jesse Yates commented on HBASE-5961:
------------------------------------
hmmm, looks like we might need to add this to the rat excludes file too.
> New standard HBase code formatter
> ---------------------------------
>
> Key: HBASE-5961
> URL: https://issues.apache.org/jira/browse/HBASE-5961
> Project: HBase
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.96.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: HBase-Formmatter.xml
>
>
> There is currently no good way of passing out the formmatter currently the 'standard' in HBase. The standard Apache formatter is actually not very close to what we are considering 'good'/'pretty' code. Further, its not trivial to get a good formatter setup.
> Proposing two things:
> 1) Adding a formmatter to the dev tools and calling out the formmatter usage in the docs
> 2) Move to a 'better' formmatter that is not the standard apache formmatter.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5961) New standard HBase code formatter
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13464329#comment-13464329 ]
Hudson commented on HBASE-5961:
-------------------------------
Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #194 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/194/])
HBASE-5961 New standard HBase code formatter; ADDENDUM -- ADD LICENSE (Revision 1390713)
HBASE-5961 New standard HBase code formatter; ADDENDUM -- ADD RAT EXCLUSION FOR ECLIPSE FORMATTER FILE (Revision 1390703)
Result = FAILURE
stack :
Files :
* /hbase/trunk/dev-support/hbase_eclipse_formatter.xml
* /hbase/trunk/pom.xml
stack :
Files :
* /hbase/trunk/pom.xml
> New standard HBase code formatter
> ---------------------------------
>
> Key: HBASE-5961
> URL: https://issues.apache.org/jira/browse/HBASE-5961
> Project: HBase
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.96.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: 5961-addendum2.txt, 5961-addendum.txt, HBase-Formmatter.xml
>
>
> There is currently no good way of passing out the formmatter currently the 'standard' in HBase. The standard Apache formatter is actually not very close to what we are considering 'good'/'pretty' code. Further, its not trivial to get a good formatter setup.
> Proposing two things:
> 1) Adding a formmatter to the dev tools and calling out the formmatter usage in the docs
> 2) Move to a 'better' formmatter that is not the standard apache formmatter.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5961) New standard HBase code formatter
Posted by "Jesse Yates (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13270803#comment-13270803 ]
Jesse Yates commented on HBASE-5961:
------------------------------------
Was thinking this could be checked in, so we have a single source of truth. In the future, if people want to update it, they just modify the file, rather than be pointed to a jira which could end up holding a ton of versions.
> New standard HBase code formatter
> ---------------------------------
>
> Key: HBASE-5961
> URL: https://issues.apache.org/jira/browse/HBASE-5961
> Project: HBase
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.96.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Priority: Minor
> Attachments: HBase-Formmatter.xml
>
>
> There is currently no good way of passing out the formmatter currently the 'standard' in HBase. The standard Apache formatter is actually not very close to what we are considering 'good'/'pretty' code. Further, its not trivial to get a good formatter setup.
> Proposing two things:
> 1) Adding a formmatter to the dev tools and calling out the formmatter usage in the docs
> 2) Move to a 'better' formmatter that is not the standard apache formmatter.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5961) New standard HBase code formatter
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13463047#comment-13463047 ]
stack commented on HBASE-5961:
------------------------------
I committed this formatter under dev-support and I added how to install doc from HBASE-3678.
> New standard HBase code formatter
> ---------------------------------
>
> Key: HBASE-5961
> URL: https://issues.apache.org/jira/browse/HBASE-5961
> Project: HBase
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.96.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: HBase-Formmatter.xml
>
>
> There is currently no good way of passing out the formmatter currently the 'standard' in HBase. The standard Apache formatter is actually not very close to what we are considering 'good'/'pretty' code. Further, its not trivial to get a good formatter setup.
> Proposing two things:
> 1) Adding a formmatter to the dev tools and calling out the formmatter usage in the docs
> 2) Move to a 'better' formmatter that is not the standard apache formmatter.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5961) New standard HBase code formatter
Posted by "Jesse Yates (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jesse Yates updated HBASE-5961:
-------------------------------
Attachment: HBase-Formmatter.xml
Attaching a proposal eclipse formmatter.
> New standard HBase code formatter
> ---------------------------------
>
> Key: HBASE-5961
> URL: https://issues.apache.org/jira/browse/HBASE-5961
> Project: HBase
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.96.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Priority: Minor
> Attachments: HBase-Formmatter.xml
>
>
> There is currently no good way of passing out the formmatter currently the 'standard' in HBase. The standard Apache formatter is actually not very close to what we are considering 'good'/'pretty' code. Further, its not trivial to get a good formatter setup.
> Proposing two things:
> 1) Adding a formmatter to the dev tools and calling out the formmatter usage in the docs
> 2) Move to a 'better' formmatter that is not the standard apache formmatter.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5961) New standard HBase code formatter
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-5961:
-------------------------
Attachment: 5961-addendum.txt
Addendum excluding formatter file from rat check
> New standard HBase code formatter
> ---------------------------------
>
> Key: HBASE-5961
> URL: https://issues.apache.org/jira/browse/HBASE-5961
> Project: HBase
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.96.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: 5961-addendum.txt, HBase-Formmatter.xml
>
>
> There is currently no good way of passing out the formmatter currently the 'standard' in HBase. The standard Apache formatter is actually not very close to what we are considering 'good'/'pretty' code. Further, its not trivial to get a good formatter setup.
> Proposing two things:
> 1) Adding a formmatter to the dev tools and calling out the formmatter usage in the docs
> 2) Move to a 'better' formmatter that is not the standard apache formmatter.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5961) New standard HBase code formatter
Posted by "Andrew Purtell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13462171#comment-13462171 ]
Andrew Purtell commented on HBASE-5961:
---------------------------------------
Cool, thanks.
> New standard HBase code formatter
> ---------------------------------
>
> Key: HBASE-5961
> URL: https://issues.apache.org/jira/browse/HBASE-5961
> Project: HBase
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.96.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Priority: Minor
> Attachments: HBase-Formmatter.xml
>
>
> There is currently no good way of passing out the formmatter currently the 'standard' in HBase. The standard Apache formatter is actually not very close to what we are considering 'good'/'pretty' code. Further, its not trivial to get a good formatter setup.
> Proposing two things:
> 1) Adding a formmatter to the dev tools and calling out the formmatter usage in the docs
> 2) Move to a 'better' formmatter that is not the standard apache formmatter.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5961) New standard HBase code formatter
Posted by "Jesse Yates (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jesse Yates updated HBASE-5961:
-------------------------------
Attachment: HBase-Formmatter.xml
Replacing formmater with fix for comment width.
> New standard HBase code formatter
> ---------------------------------
>
> Key: HBASE-5961
> URL: https://issues.apache.org/jira/browse/HBASE-5961
> Project: HBase
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.96.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Priority: Minor
> Attachments: HBase-Formmatter.xml
>
>
> There is currently no good way of passing out the formmatter currently the 'standard' in HBase. The standard Apache formatter is actually not very close to what we are considering 'good'/'pretty' code. Further, its not trivial to get a good formatter setup.
> Proposing two things:
> 1) Adding a formmatter to the dev tools and calling out the formmatter usage in the docs
> 2) Move to a 'better' formmatter that is not the standard apache formmatter.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5961) New standard HBase code formatter
Posted by "Cody Marcel (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13462009#comment-13462009 ]
Cody Marcel commented on HBASE-5961:
------------------------------------
We should add this to the src.
> New standard HBase code formatter
> ---------------------------------
>
> Key: HBASE-5961
> URL: https://issues.apache.org/jira/browse/HBASE-5961
> Project: HBase
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.96.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Priority: Minor
> Attachments: HBase-Formmatter.xml
>
>
> There is currently no good way of passing out the formmatter currently the 'standard' in HBase. The standard Apache formatter is actually not very close to what we are considering 'good'/'pretty' code. Further, its not trivial to get a good formatter setup.
> Proposing two things:
> 1) Adding a formmatter to the dev tools and calling out the formmatter usage in the docs
> 2) Move to a 'better' formmatter that is not the standard apache formmatter.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5961) New standard HBase code formatter
Posted by "Cody Marcel (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13464124#comment-13464124 ]
Cody Marcel commented on HBASE-5961:
------------------------------------
+1 to adding the licences.
> New standard HBase code formatter
> ---------------------------------
>
> Key: HBASE-5961
> URL: https://issues.apache.org/jira/browse/HBASE-5961
> Project: HBase
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.96.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: 5961-addendum.txt, HBase-Formmatter.xml
>
>
> There is currently no good way of passing out the formmatter currently the 'standard' in HBase. The standard Apache formatter is actually not very close to what we are considering 'good'/'pretty' code. Further, its not trivial to get a good formatter setup.
> Proposing two things:
> 1) Adding a formmatter to the dev tools and calling out the formmatter usage in the docs
> 2) Move to a 'better' formmatter that is not the standard apache formmatter.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5961) New standard HBase code formatter
Posted by "Jesse Yates (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jesse Yates updated HBASE-5961:
-------------------------------
Attachment: (was: HBase-Formmatter.xml)
> New standard HBase code formatter
> ---------------------------------
>
> Key: HBASE-5961
> URL: https://issues.apache.org/jira/browse/HBASE-5961
> Project: HBase
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.96.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Priority: Minor
> Attachments: HBase-Formmatter.xml
>
>
> There is currently no good way of passing out the formmatter currently the 'standard' in HBase. The standard Apache formatter is actually not very close to what we are considering 'good'/'pretty' code. Further, its not trivial to get a good formatter setup.
> Proposing two things:
> 1) Adding a formmatter to the dev tools and calling out the formmatter usage in the docs
> 2) Move to a 'better' formmatter that is not the standard apache formmatter.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5961) New standard HBase code formatter
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-5961:
-------------------------
Attachment: 5961-addendum2.txt
Add license and remove the exclusion as per Cody +1
> New standard HBase code formatter
> ---------------------------------
>
> Key: HBASE-5961
> URL: https://issues.apache.org/jira/browse/HBASE-5961
> Project: HBase
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.96.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: 5961-addendum2.txt, 5961-addendum.txt, HBase-Formmatter.xml
>
>
> There is currently no good way of passing out the formmatter currently the 'standard' in HBase. The standard Apache formatter is actually not very close to what we are considering 'good'/'pretty' code. Further, its not trivial to get a good formatter setup.
> Proposing two things:
> 1) Adding a formmatter to the dev tools and calling out the formmatter usage in the docs
> 2) Move to a 'better' formmatter that is not the standard apache formmatter.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5961) New standard HBase code formatter
Posted by "Jesse Yates (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13403316#comment-13403316 ]
Jesse Yates commented on HBASE-5961:
------------------------------------
@Matt - thanks for the heads up. I'll post a new version.
> New standard HBase code formatter
> ---------------------------------
>
> Key: HBASE-5961
> URL: https://issues.apache.org/jira/browse/HBASE-5961
> Project: HBase
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.96.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Priority: Minor
> Attachments: HBase-Formmatter.xml
>
>
> There is currently no good way of passing out the formmatter currently the 'standard' in HBase. The standard Apache formatter is actually not very close to what we are considering 'good'/'pretty' code. Further, its not trivial to get a good formatter setup.
> Proposing two things:
> 1) Adding a formmatter to the dev tools and calling out the formmatter usage in the docs
> 2) Move to a 'better' formmatter that is not the standard apache formmatter.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5961) New standard HBase code formatter
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13464118#comment-13464118 ]
stack commented on HBASE-5961:
------------------------------
Committed exclusion addendum (I suppose I could equally as well added the apache license...)
> New standard HBase code formatter
> ---------------------------------
>
> Key: HBASE-5961
> URL: https://issues.apache.org/jira/browse/HBASE-5961
> Project: HBase
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.96.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: 5961-addendum.txt, HBase-Formmatter.xml
>
>
> There is currently no good way of passing out the formmatter currently the 'standard' in HBase. The standard Apache formatter is actually not very close to what we are considering 'good'/'pretty' code. Further, its not trivial to get a good formatter setup.
> Proposing two things:
> 1) Adding a formmatter to the dev tools and calling out the formmatter usage in the docs
> 2) Move to a 'better' formmatter that is not the standard apache formmatter.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5961) New standard HBase code formatter
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13462014#comment-13462014 ]
stack commented on HBASE-5961:
------------------------------
Where would we add it? Check it in under dev-support?
> New standard HBase code formatter
> ---------------------------------
>
> Key: HBASE-5961
> URL: https://issues.apache.org/jira/browse/HBASE-5961
> Project: HBase
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.96.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Priority: Minor
> Attachments: HBase-Formmatter.xml
>
>
> There is currently no good way of passing out the formmatter currently the 'standard' in HBase. The standard Apache formatter is actually not very close to what we are considering 'good'/'pretty' code. Further, its not trivial to get a good formatter setup.
> Proposing two things:
> 1) Adding a formmatter to the dev tools and calling out the formmatter usage in the docs
> 2) Move to a 'better' formmatter that is not the standard apache formmatter.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5961) New standard HBase code formatter
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13462393#comment-13462393 ]
stack commented on HBASE-5961:
------------------------------
[~jesse_yates] So commit this to dev-support and then open new issue for code template?
> New standard HBase code formatter
> ---------------------------------
>
> Key: HBASE-5961
> URL: https://issues.apache.org/jira/browse/HBASE-5961
> Project: HBase
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.96.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Priority: Minor
> Attachments: HBase-Formmatter.xml
>
>
> There is currently no good way of passing out the formmatter currently the 'standard' in HBase. The standard Apache formatter is actually not very close to what we are considering 'good'/'pretty' code. Further, its not trivial to get a good formatter setup.
> Proposing two things:
> 1) Adding a formmatter to the dev tools and calling out the formmatter usage in the docs
> 2) Move to a 'better' formmatter that is not the standard apache formmatter.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5961) New standard HBase code formatter
Posted by "Matt Corgan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13403300#comment-13403300 ]
Matt Corgan commented on HBASE-5961:
------------------------------------
Jesse - I was using this and noticed the comments are still broken at 80 characters. Unless it's intentional, there's a setting at the bottom of the "Comments" tab.
> New standard HBase code formatter
> ---------------------------------
>
> Key: HBASE-5961
> URL: https://issues.apache.org/jira/browse/HBASE-5961
> Project: HBase
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.96.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Priority: Minor
> Attachments: HBase-Formmatter.xml
>
>
> There is currently no good way of passing out the formmatter currently the 'standard' in HBase. The standard Apache formatter is actually not very close to what we are considering 'good'/'pretty' code. Further, its not trivial to get a good formatter setup.
> Proposing two things:
> 1) Adding a formmatter to the dev tools and calling out the formmatter usage in the docs
> 2) Move to a 'better' formmatter that is not the standard apache formmatter.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5961) New standard HBase code formatter
Posted by "Jesse Yates (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13462138#comment-13462138 ]
Jesse Yates commented on HBASE-5961:
------------------------------------
[~saint.ack@gmail.com] yeah, dev-support seems like a solid plan. We should also consider having a code-template as well so things like the license, etc. are always added. Accumulo folks did this and it really helps ensure good formatting, especially when the formatters are part of the codebase.
> New standard HBase code formatter
> ---------------------------------
>
> Key: HBASE-5961
> URL: https://issues.apache.org/jira/browse/HBASE-5961
> Project: HBase
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.96.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Priority: Minor
> Attachments: HBase-Formmatter.xml
>
>
> There is currently no good way of passing out the formmatter currently the 'standard' in HBase. The standard Apache formatter is actually not very close to what we are considering 'good'/'pretty' code. Further, its not trivial to get a good formatter setup.
> Proposing two things:
> 1) Adding a formmatter to the dev tools and calling out the formmatter usage in the docs
> 2) Move to a 'better' formmatter that is not the standard apache formmatter.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5961) New standard HBase code formatter
Posted by "Cody Marcel (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13462851#comment-13462851 ]
Cody Marcel commented on HBASE-5961:
------------------------------------
Nice!
> New standard HBase code formatter
> ---------------------------------
>
> Key: HBASE-5961
> URL: https://issues.apache.org/jira/browse/HBASE-5961
> Project: HBase
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.96.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Priority: Minor
> Attachments: HBase-Formmatter.xml
>
>
> There is currently no good way of passing out the formmatter currently the 'standard' in HBase. The standard Apache formatter is actually not very close to what we are considering 'good'/'pretty' code. Further, its not trivial to get a good formatter setup.
> Proposing two things:
> 1) Adding a formmatter to the dev tools and calling out the formmatter usage in the docs
> 2) Move to a 'better' formmatter that is not the standard apache formmatter.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira