[jira] [Resolved] (LANG-1665) Modify Tuple equals to take BigDecimal comparison

["Gary D. Gregory (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/LANG-1665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gary D. Gregory resolved LANG-1665.
-----------------------------------
    Resolution: Not A Problem

PR is closed. See comments there.

> Modify Tuple equals to take BigDecimal comparison
> -------------------------------------------------
>
>                 Key: LANG-1665
>                 URL: https://issues.apache.org/jira/browse/LANG-1665
>             Project: Commons Lang
>          Issue Type: Improvement
>          Components: lang.tuple.*
>    Affects Versions: 3.12.0
>            Reporter: Chikashi Toyoshima
>            Priority: Trivial
>          Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> I understand that this would be a bit controversial. Imhp as possibly ignorable suggestion, it'd be more helpful if the Tuple supports BgDecimal numeric equality rather than simply checking object.
>  
> In a particular case, you may want to check if a collection of pairs contain a certain pair which includes BigDecimal values. Then to check object equality is maybe just right or not. But in many cases, I assume that numeric comparison would be more demanded such as following simple example. 
> {code:java}
> Set<Pair<String, BigDecimal>> someCollection = getPairs(); 
> someCollection.contains(Pair.of("foo", BigDecimal.valueOf(100))); 
> {code}
>  
> I created the PR. Please take a look. I'm happy to whichever it is accepted or not receiving feedback.
> [https://github.com/apache/commons-lang/pull/780]



--
This message was sent by Atlassian Jira
(v8.20.1#820001)