[jira] Updated: (ZOOKEEPER-738) zookeeper.jute.h fails to compile with -pedantic

["Jozef Hatala (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/ZOOKEEPER-738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jozef Hatala updated ZOOKEEPER-738:
-----------------------------------

    Attachment: semi.patch

The attached patch removes the extra semicolon after the call to JType.genCDecl (which comes with its own semicolon already):

src/java/main/org/apache/jute/compiler/JType.java:
 52         String genCDecl(String name) {
 53                 return "    " + mCName + " "+name+";\n";
 54         }

The attached diff is against http://svn.apache.org/repos/asf/hadoop/zookeeper/trunk at revision 932666 specifically.

(Regenerated the files like this: rm -rf src/{c,java}/generated/ && ant compile_jute)

Testing done: I diff:ed the C and Java files that "ant compile_jute" generates in the ZK tree *with* and *without* this patch applied, and I confirmed that the only difference between the two is that with the patch applied the extra semicolon is not present any more.  (Diff:ed like this: diff -ru src{.orig,}/c/generated/)

> zookeeper.jute.h fails to compile with -pedantic 
> -------------------------------------------------
>
>                 Key: ZOOKEEPER-738
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-738
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: c client
>    Affects Versions: 3.3.0
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>             Fix For: 3.3.1, 3.4.0
>
>         Attachments: semi.patch
>
>
> /home/y/include/zookeeper/zookeeper.jute.h:96: error: extra semicolon
> /home/y/include/zookeeper/zookeeper.jute.h:158: error: extra semicolon
> /home/y/include/zookeeper/zookeeper.jute.h:288: error: extra semicolon
> the code generator needs to be updated to not output a naked semi

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.