[GitHub] [incubator-celeborn] FMX commented on a diff in pull request #1441: [CELEBORN-537] Improve blacklist compute & minor fix for Flink

["FMX (via GitHub)" <gi...@apache.org>]

FMX commented on code in PR #1441:
URL: https://github.com/apache/incubator-celeborn/pull/1441#discussion_r1172082404


##########
common/src/main/scala/org/apache/celeborn/common/meta/ShufflePartitionLocationInfo.scala:
##########
@@ -65,6 +61,12 @@ class ShufflePartitionLocationInfo {
     removePartitions(slavePartitionLocations, partitionId)
   }
 
+  def removeAndGetAllMasterPartitionIds(): util.Set[Integer] = {
+    masterPartitionLocations.entrySet().asScala

Review Comment:
   This method looks wired. Getting keySet and clearing the map will be more efficient.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org