You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/02/24 15:42:45 UTC

[GitHub] [incubator-apisix] membphis opened a new pull request #1157: bugfix: drop custom Lua search paths and use Lua standard search path…

membphis opened a new pull request #1157: bugfix: drop custom Lua search paths and use Lua standard search path…
URL: https://github.com/apache/incubator-apisix/pull/1157
 
 
   …s instead.
   
   The different Lua version have different Lua search path.
   For example:
     Lua 5.1: /usr/local/share/5.1 or /usr/share/5.1 .
     Lua 5.2: /usr/local/share/5.2 or others.
     Lua 5.3: /usr/local/share/5.3 or others.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix] moonming commented on issue #1157: bugfix: drop custom Lua search paths and use Lua standard search path…

Posted by GitBox <gi...@apache.org>.
moonming commented on issue #1157: bugfix: drop custom Lua search paths and use Lua standard search path…
URL: https://github.com/apache/incubator-apisix/pull/1157#issuecomment-601973561
 
 
   as discuss in mailling list, I will continue to fix this bug

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix] membphis edited a comment on issue #1157: bugfix: drop custom Lua search paths and use Lua standard search path…

Posted by GitBox <gi...@apache.org>.
membphis edited a comment on issue #1157: bugfix: drop custom Lua search paths and use Lua standard search path…
URL: https://github.com/apache/incubator-apisix/pull/1157#issuecomment-590392652
 
 
   discuss mail: https://lists.apache.org/thread.html/r2cfef17709f51f2c4dd134ba7274c3bad3242917ce205dcd708dc9f0%40%3Cdev.apisix.apache.org%3E

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix] membphis commented on issue #1157: bugfix: drop custom Lua search paths and use Lua standard search path…

Posted by GitBox <gi...@apache.org>.
membphis commented on issue #1157: bugfix: drop custom Lua search paths and use Lua standard search path…
URL: https://github.com/apache/incubator-apisix/pull/1157#issuecomment-596182651
 
 
   There are compatibility issues with the current implementation.
   
   We can also just modify the make install section. After installing via luarocks, the `lua` directory will be removed automatically.
   
   I will submit a new PR later.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix] membphis commented on issue #1157: bugfix: drop custom Lua search paths and use Lua standard search path…

Posted by GitBox <gi...@apache.org>.
membphis commented on issue #1157: bugfix: drop custom Lua search paths and use Lua standard search path…
URL: https://github.com/apache/incubator-apisix/pull/1157#issuecomment-600982734
 
 
   some

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix] membphis commented on issue #1157: bugfix: drop custom Lua search paths and use Lua standard search path…

Posted by GitBox <gi...@apache.org>.
membphis commented on issue #1157: bugfix: drop custom Lua search paths and use Lua standard search path…
URL: https://github.com/apache/incubator-apisix/pull/1157#issuecomment-590392652
 
 
   dev mail: https://lists.apache.org/thread.html/r2cfef17709f51f2c4dd134ba7274c3bad3242917ce205dcd708dc9f0%40%3Cdev.apisix.apache.org%3E

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix] moonming commented on issue #1157: bugfix: drop custom Lua search paths and use Lua standard search path…

Posted by GitBox <gi...@apache.org>.
moonming commented on issue #1157: bugfix: drop custom Lua search paths and use Lua standard search path…
URL: https://github.com/apache/incubator-apisix/pull/1157#issuecomment-601973691
 
 
   > Some users like the folder "lua", which is easy to understand, so we can keep the current way.
   
   which is not a good reason, we discuss in mailing list not in private channel from `some users`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix] membphis closed pull request #1157: bugfix: drop custom Lua search paths and use Lua standard search path…

Posted by GitBox <gi...@apache.org>.
membphis closed pull request #1157: bugfix: drop custom Lua search paths and use Lua standard search path…
URL: https://github.com/apache/incubator-apisix/pull/1157
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix] membphis edited a comment on issue #1157: bugfix: drop custom Lua search paths and use Lua standard search path…

Posted by GitBox <gi...@apache.org>.
membphis edited a comment on issue #1157: bugfix: drop custom Lua search paths and use Lua standard search path…
URL: https://github.com/apache/incubator-apisix/pull/1157#issuecomment-600982734
 
 
   Some users like the folder "lua", which is easy to understand, so we can keep the current way.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services