[GitHub] [airflow] potiuk commented on a change in pull request #16338: SFTP hook to prefer the SSH paramiko key over the key file path

[GitBox <gi...@apache.org>]

potiuk commented on a change in pull request #16338:
URL: https://github.com/apache/airflow/pull/16338#discussion_r688935347



##########
File path: airflow/providers/sftp/hooks/sftp.py
##########
@@ -135,8 +135,13 @@ def get_conn(self) -> pysftp.Connection:
             }
             if self.password and self.password.strip():
                 conn_params['password'] = self.password
-            if self.key_file:
+
+            # Try to use the paramiko key from the SSH hook

Review comment:
       SFTPHook has several methods that are sftp-specific (such as retrieve_file/store_file but also many others). Those make no sense for "ssh hook". 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org