You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/10/12 10:43:35 UTC
[GitHub] [flink] JingGe opened a new pull request #17458: [hotfix][docs] add more information about how to speed up maven build.
JingGe opened a new pull request #17458:
URL: https://github.com/apache/flink/pull/17458
## What is the purpose of the change
This pull request improves the information about how to speed up the maven build, which will help Flink developer for their daily work.
## Brief change log
- Briefly describe the "fast" maven profile.
- Show alternative option of controlling skips manually.
- Recommend maven parallel build.
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17458: [hotfix][docs] add more information about how to speed up maven build.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17458:
URL: https://github.com/apache/flink/pull/17458#issuecomment-940890804
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4b0f47786b0d5a84903440146195eb960d427183",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24984",
"triggerID" : "4b0f47786b0d5a84903440146195eb960d427183",
"triggerType" : "PUSH"
}, {
"hash" : "1527085f5c1365c300b47c783f655cb8494a92f5",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1527085f5c1365c300b47c783f655cb8494a92f5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4b0f47786b0d5a84903440146195eb960d427183 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24984)
* 1527085f5c1365c300b47c783f655cb8494a92f5 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17458: [hotfix][docs] add more information about how to speed up maven build.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17458:
URL: https://github.com/apache/flink/pull/17458#issuecomment-940890804
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4b0f47786b0d5a84903440146195eb960d427183",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24984",
"triggerID" : "4b0f47786b0d5a84903440146195eb960d427183",
"triggerType" : "PUSH"
}, {
"hash" : "1527085f5c1365c300b47c783f655cb8494a92f5",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25003",
"triggerID" : "1527085f5c1365c300b47c783f655cb8494a92f5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4b0f47786b0d5a84903440146195eb960d427183 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24984)
* 1527085f5c1365c300b47c783f655cb8494a92f5 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25003)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17458: [hotfix][docs] add more information about how to speed up maven build.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17458:
URL: https://github.com/apache/flink/pull/17458#issuecomment-940890804
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4b0f47786b0d5a84903440146195eb960d427183",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24984",
"triggerID" : "4b0f47786b0d5a84903440146195eb960d427183",
"triggerType" : "PUSH"
}, {
"hash" : "1527085f5c1365c300b47c783f655cb8494a92f5",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25003",
"triggerID" : "1527085f5c1365c300b47c783f655cb8494a92f5",
"triggerType" : "PUSH"
}, {
"hash" : "2c0a31553ff573e2ac794d0dc5f11c33144c24c8",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25225",
"triggerID" : "2c0a31553ff573e2ac794d0dc5f11c33144c24c8",
"triggerType" : "PUSH"
}, {
"hash" : "2a955c618facf78f9953cb6159f201c2262a78eb",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2a955c618facf78f9953cb6159f201c2262a78eb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1527085f5c1365c300b47c783f655cb8494a92f5 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25003)
* 2c0a31553ff573e2ac794d0dc5f11c33144c24c8 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25225)
* 2a955c618facf78f9953cb6159f201c2262a78eb UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #17458: [hotfix][docs] add more information about how to speed up maven build.
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #17458:
URL: https://github.com/apache/flink/pull/17458#discussion_r727359834
##########
File path: docs/content/docs/flinkDev/building.md
##########
@@ -52,11 +52,19 @@ mvn clean install -DskipTests
This instructs [Maven](http://maven.apache.org) (`mvn`) to first remove all existing builds (`clean`) and then create a new Flink binary (`install`).
-To speed up the build you can skip tests, QA plugins, and JavaDocs:
+To speed up the build you can:
+- use the build-in "fast" maven profile which will skip unit tests, integration tests, QA plugins, and JavaDocs.
+- active maven parallel build, e.g. "mvn -T 1C" means 1 thread per cpu core.
+The build script will be:
```bash
-mvn clean install -DskipTests -Dfast
+mvn clean install -DskipTests -Dfast -T 1C
```
+You can obviously control all skips manually too:
+```bash
+mvn clean install -DskipTests -Dskip.npm=true -Dcheckstyle.skip=true -Drat.skip=true -Dscalastyle.skip=true -Denforcer.skip=true -Dmaven.javadoc.skip=true -Djapicmp.skip=true -T 1C
Review comment:
yes that is fine.
##########
File path: docs/content/docs/flinkDev/building.md
##########
@@ -52,11 +52,19 @@ mvn clean install -DskipTests
This instructs [Maven](http://maven.apache.org) (`mvn`) to first remove all existing builds (`clean`) and then create a new Flink binary (`install`).
-To speed up the build you can skip tests, QA plugins, and JavaDocs:
+To speed up the build you can:
+- use the build-in "fast" maven profile which will skip unit tests, integration tests, QA plugins, and JavaDocs.
+- active maven parallel build, e.g. "mvn -T 1C" means 1 thread per cpu core.
+The build script will be:
```bash
-mvn clean install -DskipTests -Dfast
+mvn clean install -DskipTests -Dfast -T 1C
Review comment:
Its really not because this documentation is aimed at people who _do not know maven_, and putting them into a situation where the build fails for no reason is just not acceptable.
##########
File path: docs/content/docs/flinkDev/building.md
##########
@@ -52,11 +52,19 @@ mvn clean install -DskipTests
This instructs [Maven](http://maven.apache.org) (`mvn`) to first remove all existing builds (`clean`) and then create a new Flink binary (`install`).
-To speed up the build you can skip tests, QA plugins, and JavaDocs:
+To speed up the build you can:
+- use the build-in "fast" maven profile which will skip unit tests, integration tests, QA plugins, and JavaDocs.
+- active maven parallel build, e.g. "mvn -T 1C" means 1 thread per cpu core.
+The build script will be:
```bash
-mvn clean install -DskipTests -Dfast
+mvn clean install -DskipTests -Dfast -T 1C
```
+You can obviously control all skips manually too:
+```bash
+mvn clean install -DskipTests -Dskip.npm=true -Dcheckstyle.skip=true -Drat.skip=true -Dscalastyle.skip=true -Denforcer.skip=true -Dmaven.javadoc.skip=true -Djapicmp.skip=true -T 1C
Review comment:
I don't think we should be documenting the "manual" way in the first place. People who don't know maven should just stick to the `fast` profile a) for readability and b) to have a hook that works across all current and future Flink versions (e.g., they automatically reap the benefits if we add more stuff to the profile).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17458: [hotfix][docs] add more information about how to speed up maven build.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17458:
URL: https://github.com/apache/flink/pull/17458#issuecomment-940890804
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17458: [hotfix][docs] add more information about how to speed up maven build.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17458:
URL: https://github.com/apache/flink/pull/17458#issuecomment-940890804
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4b0f47786b0d5a84903440146195eb960d427183",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24984",
"triggerID" : "4b0f47786b0d5a84903440146195eb960d427183",
"triggerType" : "PUSH"
}, {
"hash" : "1527085f5c1365c300b47c783f655cb8494a92f5",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25003",
"triggerID" : "1527085f5c1365c300b47c783f655cb8494a92f5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1527085f5c1365c300b47c783f655cb8494a92f5 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25003)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] JingGe commented on a change in pull request #17458: [hotfix][docs] add more information about how to speed up maven build.
Posted by GitBox <gi...@apache.org>.
JingGe commented on a change in pull request #17458:
URL: https://github.com/apache/flink/pull/17458#discussion_r727793607
##########
File path: docs/content/docs/flinkDev/building.md
##########
@@ -52,11 +52,19 @@ mvn clean install -DskipTests
This instructs [Maven](http://maven.apache.org) (`mvn`) to first remove all existing builds (`clean`) and then create a new Flink binary (`install`).
-To speed up the build you can skip tests, QA plugins, and JavaDocs:
+To speed up the build you can:
+- use the build-in "fast" maven profile which will skip unit tests, integration tests, QA plugins, and JavaDocs.
+- active maven parallel build, e.g. "mvn -T 1C" means 1 thread per cpu core.
+The build script will be:
```bash
-mvn clean install -DskipTests -Dfast
+mvn clean install -DskipTests -Dfast -T 1C
Review comment:
Your consideration is great! I would suggest to point out the risk in the documentation and let user make the choice, since I did find any another place that is better to tell people who do know maven about this improvement hint and info about building Flink should be kept at one place for people with different background.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] JingGe commented on a change in pull request #17458: [hotfix][docs] add more information about how to speed up maven build.
Posted by GitBox <gi...@apache.org>.
JingGe commented on a change in pull request #17458:
URL: https://github.com/apache/flink/pull/17458#discussion_r727162524
##########
File path: docs/content/docs/flinkDev/building.md
##########
@@ -52,11 +52,19 @@ mvn clean install -DskipTests
This instructs [Maven](http://maven.apache.org) (`mvn`) to first remove all existing builds (`clean`) and then create a new Flink binary (`install`).
-To speed up the build you can skip tests, QA plugins, and JavaDocs:
+To speed up the build you can:
+- use the build-in "fast" maven profile which will skip unit tests, integration tests, QA plugins, and JavaDocs.
+- active maven parallel build, e.g. "mvn -T 1C" means 1 thread per cpu core.
+The build script will be:
```bash
-mvn clean install -DskipTests -Dfast
+mvn clean install -DskipTests -Dfast -T 1C
```
+You can obviously control all skips manually too:
Review comment:
Thanks for the hint.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] JingGe commented on a change in pull request #17458: [hotfix][docs] add more information about how to speed up maven build.
Posted by GitBox <gi...@apache.org>.
JingGe commented on a change in pull request #17458:
URL: https://github.com/apache/flink/pull/17458#discussion_r727793607
##########
File path: docs/content/docs/flinkDev/building.md
##########
@@ -52,11 +52,19 @@ mvn clean install -DskipTests
This instructs [Maven](http://maven.apache.org) (`mvn`) to first remove all existing builds (`clean`) and then create a new Flink binary (`install`).
-To speed up the build you can skip tests, QA plugins, and JavaDocs:
+To speed up the build you can:
+- use the build-in "fast" maven profile which will skip unit tests, integration tests, QA plugins, and JavaDocs.
+- active maven parallel build, e.g. "mvn -T 1C" means 1 thread per cpu core.
+The build script will be:
```bash
-mvn clean install -DskipTests -Dfast
+mvn clean install -DskipTests -Dfast -T 1C
Review comment:
Your consideration is great! Thanks. I would suggest to point out the risk in the documentation and let user make the choice, since on one hand I did not find any another place that is better to tell people who do know maven about this improvement hint and on the other hand info about building Flink should be kept at one place for people with different backgrounds.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #17458: [hotfix][docs] add more information about how to speed up maven build.
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17458:
URL: https://github.com/apache/flink/pull/17458#issuecomment-940890804
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4b0f47786b0d5a84903440146195eb960d427183",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "4b0f47786b0d5a84903440146195eb960d427183",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4b0f47786b0d5a84903440146195eb960d427183 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17458: [hotfix][docs] add more information about how to speed up maven build.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17458:
URL: https://github.com/apache/flink/pull/17458#issuecomment-940890804
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4b0f47786b0d5a84903440146195eb960d427183",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24984",
"triggerID" : "4b0f47786b0d5a84903440146195eb960d427183",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4b0f47786b0d5a84903440146195eb960d427183 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24984)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] JingGe commented on a change in pull request #17458: [hotfix][docs] add more information about how to speed up maven build.
Posted by GitBox <gi...@apache.org>.
JingGe commented on a change in pull request #17458:
URL: https://github.com/apache/flink/pull/17458#discussion_r727793607
##########
File path: docs/content/docs/flinkDev/building.md
##########
@@ -52,11 +52,19 @@ mvn clean install -DskipTests
This instructs [Maven](http://maven.apache.org) (`mvn`) to first remove all existing builds (`clean`) and then create a new Flink binary (`install`).
-To speed up the build you can skip tests, QA plugins, and JavaDocs:
+To speed up the build you can:
+- use the build-in "fast" maven profile which will skip unit tests, integration tests, QA plugins, and JavaDocs.
+- active maven parallel build, e.g. "mvn -T 1C" means 1 thread per cpu core.
+The build script will be:
```bash
-mvn clean install -DskipTests -Dfast
+mvn clean install -DskipTests -Dfast -T 1C
Review comment:
Your consideration is great! Thanks. I would suggest to point out the risk in the documentation and let user make the choice, since on one hand I did not find any another place that is better to tell people who do know maven about this improvement hint and on the other hand info about building Flink should be kept at one place for people with different background.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol merged pull request #17458: [hotfix][docs] add more information about how to speed up maven build.
Posted by GitBox <gi...@apache.org>.
zentol merged pull request #17458:
URL: https://github.com/apache/flink/pull/17458
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #17458: [hotfix][docs] add more information about how to speed up maven build.
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #17458:
URL: https://github.com/apache/flink/pull/17458#discussion_r727364094
##########
File path: docs/content/docs/flinkDev/building.md
##########
@@ -52,11 +52,19 @@ mvn clean install -DskipTests
This instructs [Maven](http://maven.apache.org) (`mvn`) to first remove all existing builds (`clean`) and then create a new Flink binary (`install`).
-To speed up the build you can skip tests, QA plugins, and JavaDocs:
+To speed up the build you can:
+- use the build-in "fast" maven profile which will skip unit tests, integration tests, QA plugins, and JavaDocs.
+- active maven parallel build, e.g. "mvn -T 1C" means 1 thread per cpu core.
+The build script will be:
```bash
-mvn clean install -DskipTests -Dfast
+mvn clean install -DskipTests -Dfast -T 1C
```
+You can obviously control all skips manually too:
+```bash
+mvn clean install -DskipTests -Dskip.npm=true -Dcheckstyle.skip=true -Drat.skip=true -Dscalastyle.skip=true -Denforcer.skip=true -Dmaven.javadoc.skip=true -Djapicmp.skip=true -T 1C
Review comment:
I don't think we should be documenting the "manual" way in the first place. People who don't know maven should just stick to the `fast` profile a) for readability and b) to have a hook that works across all current and future Flink versions (e.g., they automatically reap the benefits if we add more stuff to the profile).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17458: [hotfix][docs] add more information about how to speed up maven build.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17458:
URL: https://github.com/apache/flink/pull/17458#issuecomment-940890804
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4b0f47786b0d5a84903440146195eb960d427183",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24984",
"triggerID" : "4b0f47786b0d5a84903440146195eb960d427183",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4b0f47786b0d5a84903440146195eb960d427183 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24984)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] JingGe commented on a change in pull request #17458: [hotfix][docs] add more information about how to speed up maven build.
Posted by GitBox <gi...@apache.org>.
JingGe commented on a change in pull request #17458:
URL: https://github.com/apache/flink/pull/17458#discussion_r727793607
##########
File path: docs/content/docs/flinkDev/building.md
##########
@@ -52,11 +52,19 @@ mvn clean install -DskipTests
This instructs [Maven](http://maven.apache.org) (`mvn`) to first remove all existing builds (`clean`) and then create a new Flink binary (`install`).
-To speed up the build you can skip tests, QA plugins, and JavaDocs:
+To speed up the build you can:
+- use the build-in "fast" maven profile which will skip unit tests, integration tests, QA plugins, and JavaDocs.
+- active maven parallel build, e.g. "mvn -T 1C" means 1 thread per cpu core.
+The build script will be:
```bash
-mvn clean install -DskipTests -Dfast
+mvn clean install -DskipTests -Dfast -T 1C
Review comment:
Your consideration is great! Thanks. I would suggest to point out the risk in the documentation and let user make the choice, since I did not find any another place that is better to tell people who do know maven about this improvement hint and info about building Flink should be kept at one place for people with different background.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] JingGe commented on a change in pull request #17458: [hotfix][docs] add more information about how to speed up maven build.
Posted by GitBox <gi...@apache.org>.
JingGe commented on a change in pull request #17458:
URL: https://github.com/apache/flink/pull/17458#discussion_r731899520
##########
File path: docs/content/docs/flinkDev/building.md
##########
@@ -52,11 +52,19 @@ mvn clean install -DskipTests
This instructs [Maven](http://maven.apache.org) (`mvn`) to first remove all existing builds (`clean`) and then create a new Flink binary (`install`).
-To speed up the build you can skip tests, QA plugins, and JavaDocs:
+To speed up the build you can:
+- skip unit tests, integration tests and use the build-in "fast" and "skip-webui-build" maven profile to skip QA, JavaDocs, and frontend plugins.
+- active maven parallel build, e.g. "mvn -T 1C" means 1 thread per cpu core. The maven parallel build may have deadlock(issue with the shade plugin). Please be aware of that and make sure you can live with it.
Review comment:
sounds great!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17458: [hotfix][docs] add more information about how to speed up maven build.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17458:
URL: https://github.com/apache/flink/pull/17458#issuecomment-940890804
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4b0f47786b0d5a84903440146195eb960d427183",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24984",
"triggerID" : "4b0f47786b0d5a84903440146195eb960d427183",
"triggerType" : "PUSH"
}, {
"hash" : "1527085f5c1365c300b47c783f655cb8494a92f5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25003",
"triggerID" : "1527085f5c1365c300b47c783f655cb8494a92f5",
"triggerType" : "PUSH"
}, {
"hash" : "2c0a31553ff573e2ac794d0dc5f11c33144c24c8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25225",
"triggerID" : "2c0a31553ff573e2ac794d0dc5f11c33144c24c8",
"triggerType" : "PUSH"
}, {
"hash" : "2a955c618facf78f9953cb6159f201c2262a78eb",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25231",
"triggerID" : "2a955c618facf78f9953cb6159f201c2262a78eb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2a955c618facf78f9953cb6159f201c2262a78eb Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25231)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #17458: [hotfix][docs] add more information about how to speed up maven build.
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #17458:
URL: https://github.com/apache/flink/pull/17458#discussion_r727361542
##########
File path: docs/content/docs/flinkDev/building.md
##########
@@ -52,11 +52,19 @@ mvn clean install -DskipTests
This instructs [Maven](http://maven.apache.org) (`mvn`) to first remove all existing builds (`clean`) and then create a new Flink binary (`install`).
-To speed up the build you can skip tests, QA plugins, and JavaDocs:
+To speed up the build you can:
+- use the build-in "fast" maven profile which will skip unit tests, integration tests, QA plugins, and JavaDocs.
+- active maven parallel build, e.g. "mvn -T 1C" means 1 thread per cpu core.
+The build script will be:
```bash
-mvn clean install -DskipTests -Dfast
+mvn clean install -DskipTests -Dfast -T 1C
Review comment:
Its really not because this documentation is aimed at people who _do not know maven_, and putting them into a situation where the build fails for no reason is just not acceptable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #17458: [hotfix][docs] add more information about how to speed up maven build.
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #17458:
URL: https://github.com/apache/flink/pull/17458#discussion_r727359834
##########
File path: docs/content/docs/flinkDev/building.md
##########
@@ -52,11 +52,19 @@ mvn clean install -DskipTests
This instructs [Maven](http://maven.apache.org) (`mvn`) to first remove all existing builds (`clean`) and then create a new Flink binary (`install`).
-To speed up the build you can skip tests, QA plugins, and JavaDocs:
+To speed up the build you can:
+- use the build-in "fast" maven profile which will skip unit tests, integration tests, QA plugins, and JavaDocs.
+- active maven parallel build, e.g. "mvn -T 1C" means 1 thread per cpu core.
+The build script will be:
```bash
-mvn clean install -DskipTests -Dfast
+mvn clean install -DskipTests -Dfast -T 1C
```
+You can obviously control all skips manually too:
+```bash
+mvn clean install -DskipTests -Dskip.npm=true -Dcheckstyle.skip=true -Drat.skip=true -Dscalastyle.skip=true -Denforcer.skip=true -Dmaven.javadoc.skip=true -Djapicmp.skip=true -T 1C
Review comment:
yes that is fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] JingGe commented on a change in pull request #17458: [hotfix][docs] add more information about how to speed up maven build.
Posted by GitBox <gi...@apache.org>.
JingGe commented on a change in pull request #17458:
URL: https://github.com/apache/flink/pull/17458#discussion_r727165480
##########
File path: docs/content/docs/flinkDev/building.md
##########
@@ -52,11 +52,19 @@ mvn clean install -DskipTests
This instructs [Maven](http://maven.apache.org) (`mvn`) to first remove all existing builds (`clean`) and then create a new Flink binary (`install`).
-To speed up the build you can skip tests, QA plugins, and JavaDocs:
+To speed up the build you can:
+- use the build-in "fast" maven profile which will skip unit tests, integration tests, QA plugins, and JavaDocs.
+- active maven parallel build, e.g. "mvn -T 1C" means 1 thread per cpu core.
+The build script will be:
```bash
-mvn clean install -DskipTests -Dfast
+mvn clean install -DskipTests -Dfast -T 1C
Review comment:
Thanks for the feedback. Compare to the ca 50% performance improvement, I think it is acceptable to live with the issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #17458: [hotfix][docs] add more information about how to speed up maven build.
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17458:
URL: https://github.com/apache/flink/pull/17458#issuecomment-940891575
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 4b0f47786b0d5a84903440146195eb960d427183 (Tue Oct 12 10:47:12 UTC 2021)
**Warnings:**
* Documentation files were touched, but no `docs/content.zh/` files: Update Chinese documentation or file Jira ticket.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17458: [hotfix][docs] add more information about how to speed up maven build.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17458:
URL: https://github.com/apache/flink/pull/17458#issuecomment-940890804
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4b0f47786b0d5a84903440146195eb960d427183",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24984",
"triggerID" : "4b0f47786b0d5a84903440146195eb960d427183",
"triggerType" : "PUSH"
}, {
"hash" : "1527085f5c1365c300b47c783f655cb8494a92f5",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25003",
"triggerID" : "1527085f5c1365c300b47c783f655cb8494a92f5",
"triggerType" : "PUSH"
}, {
"hash" : "2c0a31553ff573e2ac794d0dc5f11c33144c24c8",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2c0a31553ff573e2ac794d0dc5f11c33144c24c8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1527085f5c1365c300b47c783f655cb8494a92f5 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25003)
* 2c0a31553ff573e2ac794d0dc5f11c33144c24c8 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17458: [hotfix][docs] add more information about how to speed up maven build.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17458:
URL: https://github.com/apache/flink/pull/17458#issuecomment-940890804
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4b0f47786b0d5a84903440146195eb960d427183",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24984",
"triggerID" : "4b0f47786b0d5a84903440146195eb960d427183",
"triggerType" : "PUSH"
}, {
"hash" : "1527085f5c1365c300b47c783f655cb8494a92f5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25003",
"triggerID" : "1527085f5c1365c300b47c783f655cb8494a92f5",
"triggerType" : "PUSH"
}, {
"hash" : "2c0a31553ff573e2ac794d0dc5f11c33144c24c8",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25225",
"triggerID" : "2c0a31553ff573e2ac794d0dc5f11c33144c24c8",
"triggerType" : "PUSH"
}, {
"hash" : "2a955c618facf78f9953cb6159f201c2262a78eb",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25231",
"triggerID" : "2a955c618facf78f9953cb6159f201c2262a78eb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2c0a31553ff573e2ac794d0dc5f11c33144c24c8 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25225)
* 2a955c618facf78f9953cb6159f201c2262a78eb Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25231)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] JingGe commented on a change in pull request #17458: [hotfix][docs] add more information about how to speed up maven build.
Posted by GitBox <gi...@apache.org>.
JingGe commented on a change in pull request #17458:
URL: https://github.com/apache/flink/pull/17458#discussion_r731899795
##########
File path: docs/content/docs/flinkDev/building.md
##########
@@ -52,11 +52,19 @@ mvn clean install -DskipTests
This instructs [Maven](http://maven.apache.org) (`mvn`) to first remove all existing builds (`clean`) and then create a new Flink binary (`install`).
-To speed up the build you can skip tests, QA plugins, and JavaDocs:
+To speed up the build you can:
+- skip unit tests, integration tests and use the build-in "fast" and "skip-webui-build" maven profile to skip QA, JavaDocs, and frontend plugins.
+- active maven parallel build, e.g. "mvn -T 1C" means 1 thread per cpu core. The maven parallel build may have deadlock(issue with the shade plugin). Please be aware of that and make sure you can live with it.
+The build script will be:
```bash
-mvn clean install -DskipTests -Dfast
+mvn clean install -DskipTests -Dfast -Pskip-webui-build -T 1C
```
+The fast build profile will observably reduce the build time. You can also control each skip manually without using profiles, e.g. skip part of or more than the skip setup defined by the profiles, but it is recommended to stick to the fast and skip-webui-build profile, because:
+- the maven build script has better readability.
+- the profiles will be the abstraction that works across all current and future Flink versions.
+- developer will automatically reap the benefits without extra effort if more stuff has been added to the profile.
+
Review comment:
agree
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] JingGe commented on a change in pull request #17458: [hotfix][docs] add more information about how to speed up maven build.
Posted by GitBox <gi...@apache.org>.
JingGe commented on a change in pull request #17458:
URL: https://github.com/apache/flink/pull/17458#discussion_r727162253
##########
File path: docs/content/docs/flinkDev/building.md
##########
@@ -52,11 +52,19 @@ mvn clean install -DskipTests
This instructs [Maven](http://maven.apache.org) (`mvn`) to first remove all existing builds (`clean`) and then create a new Flink binary (`install`).
-To speed up the build you can skip tests, QA plugins, and JavaDocs:
+To speed up the build you can:
+- use the build-in "fast" maven profile which will skip unit tests, integration tests, QA plugins, and JavaDocs.
Review comment:
Thanks, you are right, I will update the text.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] JingGe commented on a change in pull request #17458: [hotfix][docs] add more information about how to speed up maven build.
Posted by GitBox <gi...@apache.org>.
JingGe commented on a change in pull request #17458:
URL: https://github.com/apache/flink/pull/17458#discussion_r727788707
##########
File path: docs/content/docs/flinkDev/building.md
##########
@@ -52,11 +52,19 @@ mvn clean install -DskipTests
This instructs [Maven](http://maven.apache.org) (`mvn`) to first remove all existing builds (`clean`) and then create a new Flink binary (`install`).
-To speed up the build you can skip tests, QA plugins, and JavaDocs:
+To speed up the build you can:
+- use the build-in "fast" maven profile which will skip unit tests, integration tests, QA plugins, and JavaDocs.
+- active maven parallel build, e.g. "mvn -T 1C" means 1 thread per cpu core.
+The build script will be:
```bash
-mvn clean install -DskipTests -Dfast
+mvn clean install -DskipTests -Dfast -T 1C
```
+You can obviously control all skips manually too:
+```bash
+mvn clean install -DskipTests -Dskip.npm=true -Dcheckstyle.skip=true -Drat.skip=true -Dscalastyle.skip=true -Denforcer.skip=true -Dmaven.javadoc.skip=true -Djapicmp.skip=true -T 1C
Review comment:
make sense, I am going to remove this part.
##########
File path: docs/content/docs/flinkDev/building.md
##########
@@ -52,11 +52,19 @@ mvn clean install -DskipTests
This instructs [Maven](http://maven.apache.org) (`mvn`) to first remove all existing builds (`clean`) and then create a new Flink binary (`install`).
-To speed up the build you can skip tests, QA plugins, and JavaDocs:
+To speed up the build you can:
+- use the build-in "fast" maven profile which will skip unit tests, integration tests, QA plugins, and JavaDocs.
+- active maven parallel build, e.g. "mvn -T 1C" means 1 thread per cpu core.
+The build script will be:
```bash
-mvn clean install -DskipTests -Dfast
+mvn clean install -DskipTests -Dfast -T 1C
Review comment:
Your consideration is great! I would suggest to point out the risk in the documentation and let user make the choice, since I did find any another place that is better to tell people who do know maven about this improvement hint and info about building Flink should be kept at one place for people with different background.
##########
File path: docs/content/docs/flinkDev/building.md
##########
@@ -52,11 +52,19 @@ mvn clean install -DskipTests
This instructs [Maven](http://maven.apache.org) (`mvn`) to first remove all existing builds (`clean`) and then create a new Flink binary (`install`).
-To speed up the build you can skip tests, QA plugins, and JavaDocs:
+To speed up the build you can:
+- use the build-in "fast" maven profile which will skip unit tests, integration tests, QA plugins, and JavaDocs.
+- active maven parallel build, e.g. "mvn -T 1C" means 1 thread per cpu core.
+The build script will be:
```bash
-mvn clean install -DskipTests -Dfast
+mvn clean install -DskipTests -Dfast -T 1C
Review comment:
Your consideration is great! Thanks. I would suggest to point out the risk in the documentation and let user make the choice, since I did not find any another place that is better to tell people who do know maven about this improvement hint and info about building Flink should be kept at one place for people with different background.
##########
File path: docs/content/docs/flinkDev/building.md
##########
@@ -52,11 +52,19 @@ mvn clean install -DskipTests
This instructs [Maven](http://maven.apache.org) (`mvn`) to first remove all existing builds (`clean`) and then create a new Flink binary (`install`).
-To speed up the build you can skip tests, QA plugins, and JavaDocs:
+To speed up the build you can:
+- use the build-in "fast" maven profile which will skip unit tests, integration tests, QA plugins, and JavaDocs.
+- active maven parallel build, e.g. "mvn -T 1C" means 1 thread per cpu core.
+The build script will be:
```bash
-mvn clean install -DskipTests -Dfast
+mvn clean install -DskipTests -Dfast -T 1C
Review comment:
Your consideration is great! Thanks. I would suggest to point out the risk in the documentation and let user make the choice, since on one hand I did not find any another place that is better to tell people who do know maven about this improvement hint and on the other hand info about building Flink should be kept at one place for people with different background.
##########
File path: docs/content/docs/flinkDev/building.md
##########
@@ -52,11 +52,19 @@ mvn clean install -DskipTests
This instructs [Maven](http://maven.apache.org) (`mvn`) to first remove all existing builds (`clean`) and then create a new Flink binary (`install`).
-To speed up the build you can skip tests, QA plugins, and JavaDocs:
+To speed up the build you can:
+- use the build-in "fast" maven profile which will skip unit tests, integration tests, QA plugins, and JavaDocs.
+- active maven parallel build, e.g. "mvn -T 1C" means 1 thread per cpu core.
+The build script will be:
```bash
-mvn clean install -DskipTests -Dfast
+mvn clean install -DskipTests -Dfast -T 1C
Review comment:
Your consideration is great! Thanks. I would suggest to point out the risk in the documentation and let user make the choice, since on one hand I did not find any another place that is better to tell people who do know maven about this improvement hint and on the other hand info about building Flink should be kept at one place for people with different backgrounds.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #17458: [hotfix][docs] add more information about how to speed up maven build.
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #17458:
URL: https://github.com/apache/flink/pull/17458#discussion_r727068548
##########
File path: docs/content/docs/flinkDev/building.md
##########
@@ -52,11 +52,19 @@ mvn clean install -DskipTests
This instructs [Maven](http://maven.apache.org) (`mvn`) to first remove all existing builds (`clean`) and then create a new Flink binary (`install`).
-To speed up the build you can skip tests, QA plugins, and JavaDocs:
+To speed up the build you can:
+- use the build-in "fast" maven profile which will skip unit tests, integration tests, QA plugins, and JavaDocs.
+- active maven parallel build, e.g. "mvn -T 1C" means 1 thread per cpu core.
+The build script will be:
```bash
-mvn clean install -DskipTests -Dfast
+mvn clean install -DskipTests -Dfast -T 1C
Review comment:
You shouldn't use parallel builds because they frequently deadlock. (issue with the shade plugin)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #17458: [hotfix][docs] add more information about how to speed up maven build.
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #17458:
URL: https://github.com/apache/flink/pull/17458#discussion_r727070835
##########
File path: docs/content/docs/flinkDev/building.md
##########
@@ -52,11 +52,19 @@ mvn clean install -DskipTests
This instructs [Maven](http://maven.apache.org) (`mvn`) to first remove all existing builds (`clean`) and then create a new Flink binary (`install`).
-To speed up the build you can skip tests, QA plugins, and JavaDocs:
+To speed up the build you can:
+- use the build-in "fast" maven profile which will skip unit tests, integration tests, QA plugins, and JavaDocs.
+- active maven parallel build, e.g. "mvn -T 1C" means 1 thread per cpu core.
+The build script will be:
```bash
-mvn clean install -DskipTests -Dfast
+mvn clean install -DskipTests -Dfast -T 1C
```
+You can obviously control all skips manually too:
+```bash
+mvn clean install -DskipTests -Dskip.npm=true -Dcheckstyle.skip=true -Drat.skip=true -Dscalastyle.skip=true -Denforcer.skip=true -Dmaven.javadoc.skip=true -Djapicmp.skip=true -T 1C
+```
+The fast build script will observable reduce the build time and is therefore recommended for Flink development.
Review comment:
```suggestion
The fast build profile will observably reduce the build time and is therefore recommended for Flink development.
```
##########
File path: docs/content/docs/flinkDev/building.md
##########
@@ -52,11 +52,19 @@ mvn clean install -DskipTests
This instructs [Maven](http://maven.apache.org) (`mvn`) to first remove all existing builds (`clean`) and then create a new Flink binary (`install`).
-To speed up the build you can skip tests, QA plugins, and JavaDocs:
+To speed up the build you can:
+- use the build-in "fast" maven profile which will skip unit tests, integration tests, QA plugins, and JavaDocs.
+- active maven parallel build, e.g. "mvn -T 1C" means 1 thread per cpu core.
+The build script will be:
```bash
-mvn clean install -DskipTests -Dfast
+mvn clean install -DskipTests -Dfast -T 1C
```
+You can obviously control all skips manually too:
+```bash
+mvn clean install -DskipTests -Dskip.npm=true -Dcheckstyle.skip=true -Drat.skip=true -Dscalastyle.skip=true -Denforcer.skip=true -Dmaven.javadoc.skip=true -Djapicmp.skip=true -T 1C
Review comment:
`-Dskip.npm=true` is not part of the fast profile and doesn't really fit here. Furthermore, it is recommended to use the `skip-webui-build` profile instead.
##########
File path: docs/content/docs/flinkDev/building.md
##########
@@ -52,11 +52,19 @@ mvn clean install -DskipTests
This instructs [Maven](http://maven.apache.org) (`mvn`) to first remove all existing builds (`clean`) and then create a new Flink binary (`install`).
-To speed up the build you can skip tests, QA plugins, and JavaDocs:
+To speed up the build you can:
+- use the build-in "fast" maven profile which will skip unit tests, integration tests, QA plugins, and JavaDocs.
Review comment:
the `fast` profile does _not_ skip tests, only QA plugins and javadocs.
##########
File path: docs/content/docs/flinkDev/building.md
##########
@@ -52,11 +52,19 @@ mvn clean install -DskipTests
This instructs [Maven](http://maven.apache.org) (`mvn`) to first remove all existing builds (`clean`) and then create a new Flink binary (`install`).
-To speed up the build you can skip tests, QA plugins, and JavaDocs:
+To speed up the build you can:
+- use the build-in "fast" maven profile which will skip unit tests, integration tests, QA plugins, and JavaDocs.
+- active maven parallel build, e.g. "mvn -T 1C" means 1 thread per cpu core.
+The build script will be:
```bash
-mvn clean install -DskipTests -Dfast
+mvn clean install -DskipTests -Dfast -T 1C
```
+You can obviously control all skips manually too:
Review comment:
```suggestion
You can control all skips manually too:
```
We do not use terms like `obviously`; see the documentation guide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] JingGe commented on a change in pull request #17458: [hotfix][docs] add more information about how to speed up maven build.
Posted by GitBox <gi...@apache.org>.
JingGe commented on a change in pull request #17458:
URL: https://github.com/apache/flink/pull/17458#discussion_r727177127
##########
File path: docs/content/docs/flinkDev/building.md
##########
@@ -52,11 +52,19 @@ mvn clean install -DskipTests
This instructs [Maven](http://maven.apache.org) (`mvn`) to first remove all existing builds (`clean`) and then create a new Flink binary (`install`).
-To speed up the build you can skip tests, QA plugins, and JavaDocs:
+To speed up the build you can:
+- use the build-in "fast" maven profile which will skip unit tests, integration tests, QA plugins, and JavaDocs.
+- active maven parallel build, e.g. "mvn -T 1C" means 1 thread per cpu core.
+The build script will be:
```bash
-mvn clean install -DskipTests -Dfast
+mvn clean install -DskipTests -Dfast -T 1C
```
+You can obviously control all skips manually too:
+```bash
+mvn clean install -DskipTests -Dskip.npm=true -Dcheckstyle.skip=true -Drat.skip=true -Dscalastyle.skip=true -Denforcer.skip=true -Dmaven.javadoc.skip=true -Djapicmp.skip=true -T 1C
Review comment:
The focus of this second option is on "manually" without using maven profile. I was not aware that skip-webui-build profile is recommended. Thanks for the info. The The skip-webui-build profile is only defined in the web submodule, as far as I knew, running build like "mvn clean install -Pskip-webui-build" will apply it to all submodules. Is that fine?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] JingGe commented on a change in pull request #17458: [hotfix][docs] add more information about how to speed up maven build.
Posted by GitBox <gi...@apache.org>.
JingGe commented on a change in pull request #17458:
URL: https://github.com/apache/flink/pull/17458#discussion_r727788707
##########
File path: docs/content/docs/flinkDev/building.md
##########
@@ -52,11 +52,19 @@ mvn clean install -DskipTests
This instructs [Maven](http://maven.apache.org) (`mvn`) to first remove all existing builds (`clean`) and then create a new Flink binary (`install`).
-To speed up the build you can skip tests, QA plugins, and JavaDocs:
+To speed up the build you can:
+- use the build-in "fast" maven profile which will skip unit tests, integration tests, QA plugins, and JavaDocs.
+- active maven parallel build, e.g. "mvn -T 1C" means 1 thread per cpu core.
+The build script will be:
```bash
-mvn clean install -DskipTests -Dfast
+mvn clean install -DskipTests -Dfast -T 1C
```
+You can obviously control all skips manually too:
+```bash
+mvn clean install -DskipTests -Dskip.npm=true -Dcheckstyle.skip=true -Drat.skip=true -Dscalastyle.skip=true -Denforcer.skip=true -Dmaven.javadoc.skip=true -Djapicmp.skip=true -T 1C
Review comment:
make sense, I am going to remove this part.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17458: [hotfix][docs] add more information about how to speed up maven build.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17458:
URL: https://github.com/apache/flink/pull/17458#issuecomment-940890804
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4b0f47786b0d5a84903440146195eb960d427183",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24984",
"triggerID" : "4b0f47786b0d5a84903440146195eb960d427183",
"triggerType" : "PUSH"
}, {
"hash" : "1527085f5c1365c300b47c783f655cb8494a92f5",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25003",
"triggerID" : "1527085f5c1365c300b47c783f655cb8494a92f5",
"triggerType" : "PUSH"
}, {
"hash" : "2c0a31553ff573e2ac794d0dc5f11c33144c24c8",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25225",
"triggerID" : "2c0a31553ff573e2ac794d0dc5f11c33144c24c8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1527085f5c1365c300b47c783f655cb8494a92f5 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25003)
* 2c0a31553ff573e2ac794d0dc5f11c33144c24c8 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25225)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17458: [hotfix][docs] add more information about how to speed up maven build.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17458:
URL: https://github.com/apache/flink/pull/17458#issuecomment-940890804
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4b0f47786b0d5a84903440146195eb960d427183",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24984",
"triggerID" : "4b0f47786b0d5a84903440146195eb960d427183",
"triggerType" : "PUSH"
}, {
"hash" : "1527085f5c1365c300b47c783f655cb8494a92f5",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25003",
"triggerID" : "1527085f5c1365c300b47c783f655cb8494a92f5",
"triggerType" : "PUSH"
}, {
"hash" : "2c0a31553ff573e2ac794d0dc5f11c33144c24c8",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25225",
"triggerID" : "2c0a31553ff573e2ac794d0dc5f11c33144c24c8",
"triggerType" : "PUSH"
}, {
"hash" : "2a955c618facf78f9953cb6159f201c2262a78eb",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25231",
"triggerID" : "2a955c618facf78f9953cb6159f201c2262a78eb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1527085f5c1365c300b47c783f655cb8494a92f5 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25003)
* 2c0a31553ff573e2ac794d0dc5f11c33144c24c8 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25225)
* 2a955c618facf78f9953cb6159f201c2262a78eb Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25231)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org