You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by el...@apache.org on 2024/11/16 14:56:55 UTC
(maven-dependency-plugin) branch it created (now fe61ba28)
This is an automated email from the ASF dual-hosted git repository.
elharo pushed a change to branch it
in repository https://gitbox.apache.org/repos/asf/maven-dependency-plugin.git
at fe61ba28 Reduce noise from passing integration tests
This branch includes the following new commits:
new fe61ba28 Reduce noise from passing integration tests
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
(maven-dependency-plugin) 01/01: Reduce noise from passing integration tests
Posted by el...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
elharo pushed a commit to branch it
in repository https://gitbox.apache.org/repos/asf/maven-dependency-plugin.git
commit fe61ba28ac160610f7ef3ca635279aec84c2dcff
Author: Elliotte Rusty Harold <el...@ibiblio.org>
AuthorDate: Sat Nov 16 09:56:38 2024 -0500
Reduce noise from passing integration tests
---
src/it/projects/copy-and-unpack-with-alternate-local-repo/verify.bsh | 3 ---
src/it/projects/copy-cli/verify.bsh | 1 -
src/it/projects/copy-dependencies/verify.bsh | 2 --
src/it/projects/copy-from-reactor/verify.bsh | 1 -
src/it/projects/copy-from-remote-repository/verify.bsh | 1 -
src/it/projects/copy-with-prependGroupId/verify.bsh | 1 -
src/it/projects/copy/verify.bsh | 1 -
src/it/projects/get-artifact-maven-plugin/verify.bsh | 1 -
src/it/projects/get-artifact-no-transitive/verify.bsh | 2 --
src/it/projects/get-artifact/verify.bsh | 1 -
src/it/projects/get-gav/verify.bsh | 1 -
src/it/projects/purge-local-repository-bad-pom/verify.bsh | 2 --
.../projects/purge-local-repository-multi-module-execution/setup.bsh | 2 --
.../purge-local-repository-multi-module-execution/verify.bsh | 4 +---
src/it/projects/purge-local-repository-multi-module/setup.bsh | 2 --
src/it/projects/purge-local-repository-non-transitive/verify.bsh | 2 --
src/it/projects/purge-local-repository-reresolve/verify.bsh | 2 --
src/it/projects/purge-local-repository-snapshots-only/setup.bsh | 5 -----
src/it/projects/purge-local-repository-snapshots-only/verify.bsh | 4 ----
src/it/projects/purge-local-repository-version-range/verify.bsh | 2 --
src/it/projects/purge-local-repository-without-pom/setup.bsh | 2 --
src/it/projects/purge-local-repository/setup.bsh | 2 --
src/it/projects/purge-local-repository/verify.groovy | 1 -
src/it/projects/unpack-cli/verify.bsh | 4 ----
src/it/projects/unpack-dependencies/verify.groovy | 4 ++--
src/it/projects/unpack-from-remote-repository/verify.bsh | 1 -
src/it/projects/unpack/verify.bsh | 4 ----
27 files changed, 3 insertions(+), 55 deletions(-)
diff --git a/src/it/projects/copy-and-unpack-with-alternate-local-repo/verify.bsh b/src/it/projects/copy-and-unpack-with-alternate-local-repo/verify.bsh
index e4046ae6..9bfa4394 100644
--- a/src/it/projects/copy-and-unpack-with-alternate-local-repo/verify.bsh
+++ b/src/it/projects/copy-and-unpack-with-alternate-local-repo/verify.bsh
@@ -22,21 +22,18 @@ import java.io.*;
File file = new File( basedir, "target/dependency/junit-3.8.1.jar" );
-System.out.println( "Checking for existence of " + file );
if ( !file.isFile() )
{
throw new Exception( "Missing " + file );
}
file = new File( basedir, "target/dependency/junit" );
-System.out.println( "Checking for existence of " + file );
if ( !file.isDirectory() )
{
throw new Exception( "Missing " + file );
}
file = new File( basedir, "target/repo/junit/junit/3.8.1/junit-3.8.1.jar" );
-System.out.println( "Checking for existence of " + file );
if ( !file.isFile() )
{
throw new Exception( "Missing " + file );
diff --git a/src/it/projects/copy-cli/verify.bsh b/src/it/projects/copy-cli/verify.bsh
index 93fad155..da93772d 100644
--- a/src/it/projects/copy-cli/verify.bsh
+++ b/src/it/projects/copy-cli/verify.bsh
@@ -28,7 +28,6 @@ String[] expectedFiles = {
for ( String expectedFile : expectedFiles )
{
File file = new File( libDir, expectedFile );
- System.out.println( "Checking for existence of " + file );
if ( !file.isFile() )
{
throw new Exception( "Missing file " + file );
diff --git a/src/it/projects/copy-dependencies/verify.bsh b/src/it/projects/copy-dependencies/verify.bsh
index 80031daf..7a3ce860 100644
--- a/src/it/projects/copy-dependencies/verify.bsh
+++ b/src/it/projects/copy-dependencies/verify.bsh
@@ -24,7 +24,6 @@ void checkExpected( File dir, String[] expectedFiles )
for ( String expectedFile : expectedFiles )
{
File file = new File( dir, expectedFile );
- System.out.println( "Checking for existence of " + file );
if ( !file.isFile() )
{
throw new Exception( "Missing file " + file );
@@ -39,7 +38,6 @@ void checkExpected( File dir, String[] expectedFiles, String[] unexpectedFiles )
for ( String unexpectedFile : unexpectedFiles )
{
File file = new File( dir, unexpectedFile );
- System.out.println( "Checking for inexistence of " + file );
if ( file.isFile() )
{
throw new Exception( "Unexpected file " + file + " found" );
diff --git a/src/it/projects/copy-from-reactor/verify.bsh b/src/it/projects/copy-from-reactor/verify.bsh
index d4c63a65..9367fb01 100644
--- a/src/it/projects/copy-from-reactor/verify.bsh
+++ b/src/it/projects/copy-from-reactor/verify.bsh
@@ -28,7 +28,6 @@ String[] expectedFiles = {
for ( String expectedFile : expectedFiles )
{
File file = new File( libDir, expectedFile );
- System.out.println( "Checking for existence of " + file );
if ( !file.isFile() )
{
throw new Exception( "Missing file " + file );
diff --git a/src/it/projects/copy-from-remote-repository/verify.bsh b/src/it/projects/copy-from-remote-repository/verify.bsh
index 1e390870..6edc839f 100644
--- a/src/it/projects/copy-from-remote-repository/verify.bsh
+++ b/src/it/projects/copy-from-remote-repository/verify.bsh
@@ -26,7 +26,6 @@ String[] expectedFiles = {
for ( String expectedFile : expectedFiles )
{
File file = new File( localRepositoryPath, expectedFile );
- System.out.println( "Checking for existence of " + file );
if ( !file.isFile() )
{
throw new Exception( "Missing file " + file );
diff --git a/src/it/projects/copy-with-prependGroupId/verify.bsh b/src/it/projects/copy-with-prependGroupId/verify.bsh
index 8018ef23..38018ab5 100644
--- a/src/it/projects/copy-with-prependGroupId/verify.bsh
+++ b/src/it/projects/copy-with-prependGroupId/verify.bsh
@@ -28,7 +28,6 @@ String[] expectedFiles = {
for ( String expectedFile : expectedFiles )
{
File file = new File( libDir, expectedFile );
- System.out.println( "Checking for existence of " + file );
if ( !file.isFile() )
{
throw new Exception( "Missing file " + file );
diff --git a/src/it/projects/copy/verify.bsh b/src/it/projects/copy/verify.bsh
index 93fad155..da93772d 100644
--- a/src/it/projects/copy/verify.bsh
+++ b/src/it/projects/copy/verify.bsh
@@ -28,7 +28,6 @@ String[] expectedFiles = {
for ( String expectedFile : expectedFiles )
{
File file = new File( libDir, expectedFile );
- System.out.println( "Checking for existence of " + file );
if ( !file.isFile() )
{
throw new Exception( "Missing file " + file );
diff --git a/src/it/projects/get-artifact-maven-plugin/verify.bsh b/src/it/projects/get-artifact-maven-plugin/verify.bsh
index 2f8cad07..e75bdf47 100644
--- a/src/it/projects/get-artifact-maven-plugin/verify.bsh
+++ b/src/it/projects/get-artifact-maven-plugin/verify.bsh
@@ -27,7 +27,6 @@ String[] expectedFiles = {
for ( String expectedFile : expectedFiles )
{
File file = new File( localRepositoryPath, expectedFile );
- System.out.println( "Checking for existence of " + file );
if ( !file.isFile() )
{
throw new Exception( "Missing file " + file );
diff --git a/src/it/projects/get-artifact-no-transitive/verify.bsh b/src/it/projects/get-artifact-no-transitive/verify.bsh
index dfa7d298..3c53da8d 100644
--- a/src/it/projects/get-artifact-no-transitive/verify.bsh
+++ b/src/it/projects/get-artifact-no-transitive/verify.bsh
@@ -27,7 +27,6 @@ String[] expectedFiles = {
for ( String expectedFile : expectedFiles )
{
File file = new File( localRepositoryPath, expectedFile );
- System.out.println( "Checking for existence of " + file );
if ( !file.isFile() )
{
throw new Exception( "Missing file " + file );
@@ -42,7 +41,6 @@ String[] notExpectedFiles = {
for ( String notExpectedFile : notExpectedFiles )
{
File file = new File( localRepositoryPath, notExpectedFile );
- System.out.println( "Checking for absence of " + file );
if ( file.isFile() )
{
throw new Exception( "Existing file " + file );
diff --git a/src/it/projects/get-artifact/verify.bsh b/src/it/projects/get-artifact/verify.bsh
index a586d565..25120f4f 100644
--- a/src/it/projects/get-artifact/verify.bsh
+++ b/src/it/projects/get-artifact/verify.bsh
@@ -29,7 +29,6 @@ String[] expectedFiles = {
for ( String expectedFile : expectedFiles )
{
File file = new File( localRepositoryPath, expectedFile );
- System.out.println( "Checking for existence of " + file );
if ( !file.isFile() )
{
throw new Exception( "Missing file " + file );
diff --git a/src/it/projects/get-gav/verify.bsh b/src/it/projects/get-gav/verify.bsh
index a586d565..25120f4f 100644
--- a/src/it/projects/get-gav/verify.bsh
+++ b/src/it/projects/get-gav/verify.bsh
@@ -29,7 +29,6 @@ String[] expectedFiles = {
for ( String expectedFile : expectedFiles )
{
File file = new File( localRepositoryPath, expectedFile );
- System.out.println( "Checking for existence of " + file );
if ( !file.isFile() )
{
throw new Exception( "Missing file " + file );
diff --git a/src/it/projects/purge-local-repository-bad-pom/verify.bsh b/src/it/projects/purge-local-repository-bad-pom/verify.bsh
index 45b5cc9a..0ecebd67 100644
--- a/src/it/projects/purge-local-repository-bad-pom/verify.bsh
+++ b/src/it/projects/purge-local-repository-bad-pom/verify.bsh
@@ -19,8 +19,6 @@
import java.io.*;
-System.out.println( "Checking for presence of purged dependency directories" );
-
File depJar = new File( localRepositoryPath, "org/apache/maven/its/dependency/purge-local-repository/1.0/purge-local-repository-1.0.jar" );
if ( !depJar.exists() )
diff --git a/src/it/projects/purge-local-repository-multi-module-execution/setup.bsh b/src/it/projects/purge-local-repository-multi-module-execution/setup.bsh
index 27051f6c..f55d12dd 100644
--- a/src/it/projects/purge-local-repository-multi-module-execution/setup.bsh
+++ b/src/it/projects/purge-local-repository-multi-module-execution/setup.bsh
@@ -25,8 +25,6 @@ void createJar( String artifactId )
purgedJar.getParentFile().mkdirs();
purgedJar.createNewFile();
-
- System.out.println( "Created dummy JAR " + purgedJar );
}
createJar( "purged-a" );
diff --git a/src/it/projects/purge-local-repository-multi-module-execution/verify.bsh b/src/it/projects/purge-local-repository-multi-module-execution/verify.bsh
index fde1a2bf..c5f00b8a 100644
--- a/src/it/projects/purge-local-repository-multi-module-execution/verify.bsh
+++ b/src/it/projects/purge-local-repository-multi-module-execution/verify.bsh
@@ -22,9 +22,7 @@ import java.io.File;
void checkFilePurged( String artifactId )
{
File purgedJar = new File( localRepositoryPath, "org/apache/maven/its/dependency/" + artifactId + "/1.0/" + artifactId + "-1.0.jar" );
-
- System.out.println( "Checking for absence of dummy JAR " + purgedJar );
-
+
if ( purgedJar.exists() )
{
throw new Exception( "JAR was not purged: " + purgedJar );
diff --git a/src/it/projects/purge-local-repository-multi-module/setup.bsh b/src/it/projects/purge-local-repository-multi-module/setup.bsh
index 27051f6c..f55d12dd 100644
--- a/src/it/projects/purge-local-repository-multi-module/setup.bsh
+++ b/src/it/projects/purge-local-repository-multi-module/setup.bsh
@@ -25,8 +25,6 @@ void createJar( String artifactId )
purgedJar.getParentFile().mkdirs();
purgedJar.createNewFile();
-
- System.out.println( "Created dummy JAR " + purgedJar );
}
createJar( "purged-a" );
diff --git a/src/it/projects/purge-local-repository-non-transitive/verify.bsh b/src/it/projects/purge-local-repository-non-transitive/verify.bsh
index e913c82a..2766ec78 100644
--- a/src/it/projects/purge-local-repository-non-transitive/verify.bsh
+++ b/src/it/projects/purge-local-repository-non-transitive/verify.bsh
@@ -21,8 +21,6 @@ import java.io.*;
File depDir = new File( localRepositoryPath, "org/apache/maven/its/dependency/purge-local-repository/1.0" );
-System.out.println( "Checking for absence of purged dependency directory " + depDir );
-
if ( depDir.exists() )
{
throw new Exception( "Directory was not deleted: " + depDir );
diff --git a/src/it/projects/purge-local-repository-reresolve/verify.bsh b/src/it/projects/purge-local-repository-reresolve/verify.bsh
index 45b5cc9a..0ecebd67 100644
--- a/src/it/projects/purge-local-repository-reresolve/verify.bsh
+++ b/src/it/projects/purge-local-repository-reresolve/verify.bsh
@@ -19,8 +19,6 @@
import java.io.*;
-System.out.println( "Checking for presence of purged dependency directories" );
-
File depJar = new File( localRepositoryPath, "org/apache/maven/its/dependency/purge-local-repository/1.0/purge-local-repository-1.0.jar" );
if ( !depJar.exists() )
diff --git a/src/it/projects/purge-local-repository-snapshots-only/setup.bsh b/src/it/projects/purge-local-repository-snapshots-only/setup.bsh
index 00eacb5d..4552c8f9 100644
--- a/src/it/projects/purge-local-repository-snapshots-only/setup.bsh
+++ b/src/it/projects/purge-local-repository-snapshots-only/setup.bsh
@@ -24,14 +24,9 @@ File purgedJar = new File( localRepositoryPath, "org/apache/maven/its/dependency
purgedJar.getParentFile().mkdirs();
purgedJar.createNewFile();
-System.out.println( "Created dummy JAR " + purgedJar );
-
purgedJar = new File( localRepositoryPath, "org/apache/maven/its/dependency/snap-purged/1.0-SNAPSHOT/snap-purged-1.0-SNAPSHOT.jar" );
purgedJar.getParentFile().mkdirs();
purgedJar.createNewFile();
-System.out.println( "Created dummy JAR " + purgedJar );
-
-
return true;
diff --git a/src/it/projects/purge-local-repository-snapshots-only/verify.bsh b/src/it/projects/purge-local-repository-snapshots-only/verify.bsh
index 60d0c7f6..fad0644d 100644
--- a/src/it/projects/purge-local-repository-snapshots-only/verify.bsh
+++ b/src/it/projects/purge-local-repository-snapshots-only/verify.bsh
@@ -21,8 +21,6 @@ import java.io.*;
File nonPurgedJar = new File( localRepositoryPath, "org/apache/maven/its/dependency/purged/1.0/purged-1.0.jar" );
-System.out.println( "Checking for presence of dummy JAR " + nonPurgedJar );
-
if ( !nonPurgedJar.exists() )
{
throw new Exception( "JAR was purged: " + nonPurgedJar );
@@ -31,8 +29,6 @@ if ( !nonPurgedJar.exists() )
File purgedJar = new File( localRepositoryPath, "org/apache/maven/its/dependency/snap-purged/1.0-SNAPSHOT/snap-purged-1.0-SNAPSHOT.jar" );
-System.out.println( "Checking for absence of dummy JAR " + purgedJar );
-
if ( purgedJar.exists() )
{
throw new Exception( "JAR was not purged: " + purgedJar );
diff --git a/src/it/projects/purge-local-repository-version-range/verify.bsh b/src/it/projects/purge-local-repository-version-range/verify.bsh
index 45b5cc9a..0ecebd67 100644
--- a/src/it/projects/purge-local-repository-version-range/verify.bsh
+++ b/src/it/projects/purge-local-repository-version-range/verify.bsh
@@ -19,8 +19,6 @@
import java.io.*;
-System.out.println( "Checking for presence of purged dependency directories" );
-
File depJar = new File( localRepositoryPath, "org/apache/maven/its/dependency/purge-local-repository/1.0/purge-local-repository-1.0.jar" );
if ( !depJar.exists() )
diff --git a/src/it/projects/purge-local-repository-without-pom/setup.bsh b/src/it/projects/purge-local-repository-without-pom/setup.bsh
index 02644699..dba9cfb3 100644
--- a/src/it/projects/purge-local-repository-without-pom/setup.bsh
+++ b/src/it/projects/purge-local-repository-without-pom/setup.bsh
@@ -24,6 +24,4 @@ File purgedJar = new File( localRepositoryPath, "org/apache/maven/its/dependency
purgedJar.getParentFile().mkdirs();
purgedJar.createNewFile();
-System.out.println( "Created dummy JAR " + purgedJar );
-
return true;
diff --git a/src/it/projects/purge-local-repository/setup.bsh b/src/it/projects/purge-local-repository/setup.bsh
index cfb57916..92b835d1 100644
--- a/src/it/projects/purge-local-repository/setup.bsh
+++ b/src/it/projects/purge-local-repository/setup.bsh
@@ -24,6 +24,4 @@ File purgedJar = new File( localRepositoryPath, "org/apache/maven/its/dependency
purgedJar.getParentFile().mkdirs();
purgedJar.createNewFile();
-System.out.println( "Created dummy JAR " + purgedJar );
-
return true;
diff --git a/src/it/projects/purge-local-repository/verify.groovy b/src/it/projects/purge-local-repository/verify.groovy
index 1ee8ed0d..7c97d11a 100644
--- a/src/it/projects/purge-local-repository/verify.groovy
+++ b/src/it/projects/purge-local-repository/verify.groovy
@@ -20,7 +20,6 @@
void checkFileAbsence( String path )
{
File depJar = new File( localRepositoryPath, path )
- System.out.println( "Checking for absence of dummy JAR " + depJar )
if ( depJar.exists() )
{
throw new Exception( "Dependency jar was not purged: " + depJar )
diff --git a/src/it/projects/unpack-cli/verify.bsh b/src/it/projects/unpack-cli/verify.bsh
index fc16bb2f..4b93d072 100644
--- a/src/it/projects/unpack-cli/verify.bsh
+++ b/src/it/projects/unpack-cli/verify.bsh
@@ -21,21 +21,18 @@ import java.io.*;
File file = new File( basedir, "target/output spaces directory" );
-System.out.println( "Checking for existence of " + file );
if ( !file.isDirectory() )
{
throw new Exception( "Missing " + file );
}
file = new File( file, "qdox-1.5" );
-System.out.println( "Checking for existence of " + file );
if ( !file.isDirectory() )
{
throw new Exception( "Missing " + file );
}
file = new File( file, "build.xml" );
-System.out.println( "Checking for existence of " + file );
if ( !file.isFile() )
{
throw new Exception( "Missing " + file );
@@ -43,7 +40,6 @@ if ( !file.isFile() )
//until MDEP-242 is fixed, the next test will passed
file = new File( file.getParent(), "src" );
-System.out.println( "Checking for existence of " + file );
if ( !file.isDirectory() )
{
throw new Exception( "Missing " + file );
diff --git a/src/it/projects/unpack-dependencies/verify.groovy b/src/it/projects/unpack-dependencies/verify.groovy
index dcd8104b..70757222 100644
--- a/src/it/projects/unpack-dependencies/verify.groovy
+++ b/src/it/projects/unpack-dependencies/verify.groovy
@@ -24,7 +24,7 @@ for (item in expected)
def file = new File(basedir, 'target/dependency/' + item)
if (!file.exists())
{
- throw new RuntimeException("Missing "+file.name)
+ throw new RuntimeException("Missing " + file.name)
}
}
@@ -35,7 +35,7 @@ for (item in notExpected)
def file = new File(basedir, 'target/dependency/' + item)
if (file.exists())
{
- throw new RuntimeException("This file shouldn't be here: "+file.name)
+ throw new RuntimeException("This file shouldn't be here: " + file.name)
}
}
diff --git a/src/it/projects/unpack-from-remote-repository/verify.bsh b/src/it/projects/unpack-from-remote-repository/verify.bsh
index 23f03452..3e4efdfe 100644
--- a/src/it/projects/unpack-from-remote-repository/verify.bsh
+++ b/src/it/projects/unpack-from-remote-repository/verify.bsh
@@ -26,7 +26,6 @@ String[] expectedFiles = {
for ( String expectedFile : expectedFiles )
{
File file = new File( localRepositoryPath, expectedFile );
- System.out.println( "Checking for existence of " + file );
if ( !file.isFile() )
{
throw new Exception( "Missing file " + file );
diff --git a/src/it/projects/unpack/verify.bsh b/src/it/projects/unpack/verify.bsh
index fc16bb2f..4b93d072 100644
--- a/src/it/projects/unpack/verify.bsh
+++ b/src/it/projects/unpack/verify.bsh
@@ -21,21 +21,18 @@ import java.io.*;
File file = new File( basedir, "target/output spaces directory" );
-System.out.println( "Checking for existence of " + file );
if ( !file.isDirectory() )
{
throw new Exception( "Missing " + file );
}
file = new File( file, "qdox-1.5" );
-System.out.println( "Checking for existence of " + file );
if ( !file.isDirectory() )
{
throw new Exception( "Missing " + file );
}
file = new File( file, "build.xml" );
-System.out.println( "Checking for existence of " + file );
if ( !file.isFile() )
{
throw new Exception( "Missing " + file );
@@ -43,7 +40,6 @@ if ( !file.isFile() )
//until MDEP-242 is fixed, the next test will passed
file = new File( file.getParent(), "src" );
-System.out.println( "Checking for existence of " + file );
if ( !file.isDirectory() )
{
throw new Exception( "Missing " + file );