You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Maria Odea Ching (JIRA)" <ji...@codehaus.org> on 2007/08/06 10:44:13 UTC
[jira] Created: (MRM-453) Create missing tests for repository purge
Create missing tests for repository purge
-----------------------------------------
Key: MRM-453
URL: http://jira.codehaus.org/browse/MRM-453
Project: Archiva
Issue Type: Improvement
Affects Versions: 1.0-beta-1
Reporter: Maria Odea Ching
Comments from MRM-294:
A general thought here too, for later: it might be worth reviewing the exceptions that can occur in *Purge and see if we can recover better from each rather than bubbling it
Tests:
* I think you can remove many of the components from the test XML files where the default suffice (just keep the registry and jdo factory)
* the tests have a lot of bolierplate that can probably be turned into methods that generate test data
Missing tests:
* no tests for the consumer or the Released Snapshots purge
* days old test is only testing by file age - it should also test the metadata-driven snapshots
A general thought for Archiva in the long term, too... setting up the database to test this was probably a pain. We should have stub implementations of the indexer and dao's to avoid it.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MRM-453) Create missing tests for repository
purge
Posted by "Maria Odea Ching (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MRM-453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_105721 ]
Maria Odea Ching commented on MRM-453:
--------------------------------------
Initial commit -r569789:
- Added tests for RepositoryConsumer and CleanupReleasedSnapshotsRepositoryPurge
- Added test data for the new tests
- Refactored AbstractRepositoryPurgeTest, DaysOldRepositoryPurgeTest and RetentionCountRepositoryPurgeTest
To follow:
- days old test (metadata-driven snapshots)
> Create missing tests for repository purge
> -----------------------------------------
>
> Key: MRM-453
> URL: http://jira.codehaus.org/browse/MRM-453
> Project: Archiva
> Issue Type: Improvement
> Affects Versions: 1.0-beta-1
> Reporter: Maria Odea Ching
> Assignee: Maria Odea Ching
> Fix For: 1.0-beta-2
>
>
> Comments from MRM-294:
> A general thought here too, for later: it might be worth reviewing the exceptions that can occur in *Purge and see if we can recover better from each rather than bubbling it
> Tests:
> * I think you can remove many of the components from the test XML files where the default suffice (just keep the registry and jdo factory)
> * the tests have a lot of bolierplate that can probably be turned into methods that generate test data
> Missing tests:
> * no tests for the consumer or the Released Snapshots purge
> * days old test is only testing by file age - it should also test the metadata-driven snapshots
> A general thought for Archiva in the long term, too... setting up the database to test this was probably a pain. We should have stub implementations of the indexer and dao's to avoid it.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (MRM-453) Create missing tests for repository purge
Posted by "Maria Odea Ching (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MRM-453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Maria Odea Ching closed MRM-453.
--------------------------------
Resolution: Fixed
Final fix -r570089
Fix for the test cases:
- Added tests for metadata driven snapshots in DaysOldRepositoryPurgeTest
- Added test data
Changes made in DaysOldRepositoryPurge:
- Added functionality to consider the metadata driven snapshots (check the timestamp in the filename first before the last modified date of the
file if it is a unique versioned snapshot)
> Create missing tests for repository purge
> -----------------------------------------
>
> Key: MRM-453
> URL: http://jira.codehaus.org/browse/MRM-453
> Project: Archiva
> Issue Type: Improvement
> Affects Versions: 1.0-beta-1
> Reporter: Maria Odea Ching
> Assignee: Maria Odea Ching
> Fix For: 1.0-beta-2
>
>
> Comments from MRM-294:
> A general thought here too, for later: it might be worth reviewing the exceptions that can occur in *Purge and see if we can recover better from each rather than bubbling it
> Tests:
> * I think you can remove many of the components from the test XML files where the default suffice (just keep the registry and jdo factory)
> * the tests have a lot of bolierplate that can probably be turned into methods that generate test data
> Missing tests:
> * no tests for the consumer or the Released Snapshots purge
> * days old test is only testing by file age - it should also test the metadata-driven snapshots
> A general thought for Archiva in the long term, too... setting up the database to test this was probably a pain. We should have stub implementations of the indexer and dao's to avoid it.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Work started: (MRM-453) Create missing tests for repository
purge
Posted by "Maria Odea Ching (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MRM-453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Work on MRM-453 started by Maria Odea Ching.
> Create missing tests for repository purge
> -----------------------------------------
>
> Key: MRM-453
> URL: http://jira.codehaus.org/browse/MRM-453
> Project: Archiva
> Issue Type: Improvement
> Affects Versions: 1.0-beta-1
> Reporter: Maria Odea Ching
> Assignee: Maria Odea Ching
> Fix For: 1.0-beta-2
>
>
> Comments from MRM-294:
> A general thought here too, for later: it might be worth reviewing the exceptions that can occur in *Purge and see if we can recover better from each rather than bubbling it
> Tests:
> * I think you can remove many of the components from the test XML files where the default suffice (just keep the registry and jdo factory)
> * the tests have a lot of bolierplate that can probably be turned into methods that generate test data
> Missing tests:
> * no tests for the consumer or the Released Snapshots purge
> * days old test is only testing by file age - it should also test the metadata-driven snapshots
> A general thought for Archiva in the long term, too... setting up the database to test this was probably a pain. We should have stub implementations of the indexer and dao's to avoid it.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MRM-453) Create missing tests for repository purge
Posted by "Maria Odea Ching (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MRM-453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Maria Odea Ching updated MRM-453:
---------------------------------
Fix Version/s: 1.0-beta-2
> Create missing tests for repository purge
> -----------------------------------------
>
> Key: MRM-453
> URL: http://jira.codehaus.org/browse/MRM-453
> Project: Archiva
> Issue Type: Improvement
> Affects Versions: 1.0-beta-1
> Reporter: Maria Odea Ching
> Fix For: 1.0-beta-2
>
>
> Comments from MRM-294:
> A general thought here too, for later: it might be worth reviewing the exceptions that can occur in *Purge and see if we can recover better from each rather than bubbling it
> Tests:
> * I think you can remove many of the components from the test XML files where the default suffice (just keep the registry and jdo factory)
> * the tests have a lot of bolierplate that can probably be turned into methods that generate test data
> Missing tests:
> * no tests for the consumer or the Released Snapshots purge
> * days old test is only testing by file age - it should also test the metadata-driven snapshots
> A general thought for Archiva in the long term, too... setting up the database to test this was probably a pain. We should have stub implementations of the indexer and dao's to avoid it.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira