[jira] Updated: (SOLR-2198) Grouping treats null values as equivalent to 0 or an empty string

["Yonik Seeley (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SOLR-2198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Yonik Seeley updated SOLR-2198:
-------------------------------

    Attachment: SOLR-2198.patch

Here's an updated patch based on Harish's patch, with support for additional field types, with some additional changes.
- always set the value, regardless of the value of exists - this simplifies hashCode
- move the comparison of "exists" into subclasses so equalsSameTypecan be directly used by comparators
- add support in compareTo

This is untested - I don't know if it works yet.  There are other issues with random testing and sorting null values that I need to iron out first.

> Grouping treats null values as equivalent to 0 or an empty string
> -----------------------------------------------------------------
>
>                 Key: SOLR-2198
>                 URL: https://issues.apache.org/jira/browse/SOLR-2198
>             Project: Solr
>          Issue Type: Sub-task
>            Reporter: Harish Agarwal
>         Attachments: SOLR-2198.patch, SOLR-2198.patch, SOLR-2198.patch
>
>
> The grouping function does not distinguish between missing values and their null type equivalents (0 for numeric types and an empty string for string types). 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org