You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/03/27 00:50:16 UTC

[GitHub] [spark] HyukjinKwon commented on a change in pull request #35977: [SPARK-38660][PYTHON] PySpark DeprecationWarning: distutils Version classes are deprecated

HyukjinKwon commented on a change in pull request #35977:
URL: https://github.com/apache/spark/pull/35977#discussion_r835829275



##########
File path: python/pyspark/ml/image.py
##########
@@ -28,7 +28,7 @@
 from typing import Any, Dict, List, NoReturn, Optional, cast
 
 import numpy as np
-from distutils.version import LooseVersion
+from packaging.version import Version

Review comment:
       Hm, wait. Is this 3rd party library? Adding a new dep is problematic especially when PySpark is installed via downloading distribution (instead of PyPI) because that doesn't handle dependencies (that's why we have to ship Py4J together at https://github.com/apache/spark/tree/master/python/lib)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org