You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@logging.apache.org by GitBox <gi...@apache.org> on 2021/12/25 16:12:24 UTC

[GitHub] [logging-log4j2] garydgregory commented on a change in pull request #640: LOG4J2-3256: Reduce ignored package scope of KafkaAppender

garydgregory commented on a change in pull request #640:
URL: https://github.com/apache/logging-log4j2/pull/640#discussion_r775151693



##########
File path: log4j-kafka/src/main/java/org/apache/logging/log4j/kafka/appender/KafkaAppender.java
##########
@@ -136,6 +136,18 @@ public B setRetryCount(final String retryCount) {
         return new Builder<B>().asBuilder();
     }
 
+    private static final String[] KAFKA_CLIENT_PACKAGES = new String[] { "org.apache.kafka.common", "org.apache.kafka.clients" };

Review comment:
       If you use a static init block, you can sort the array and then bsearch() it in the  lookup method. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org