You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2016/07/27 21:21:20 UTC

[jira] [Commented] (WICKET-6172) Inconsistent results from getTag[s]ByWicketId

    [ https://issues.apache.org/jira/browse/WICKET-6172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15396396#comment-15396396 ] 

ASF subversion and git services commented on WICKET-6172:
---------------------------------------------------------

Commit 996e17c3c625411c14206c14cf6a6ac4e2296dc7 in wicket's branch refs/heads/wicket-6.x from [~bitstorm]
[ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=996e17c ]

WICKET-6173 WICKET-6172 makes TagTester.createTagsByAttribute stop
working

> Inconsistent results from getTag[s]ByWicketId
> ---------------------------------------------
>
>                 Key: WICKET-6172
>                 URL: https://issues.apache.org/jira/browse/WICKET-6172
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>            Reporter: Boris Goldowsky
>            Assignee: Martin Grigorov
>            Priority: Minor
>             Fix For: 8.0.0-M1, 7.4.0, 6.24.0
>
>         Attachments: tag-tester-quickstart.zip
>
>
> The change in WICKET-5874 alters the behavior for getTagByWicketId but not getTagsByWicketId .  Thus for markup like this:
> <div><img ...></div>
> getTagByWicketId will return the img tag, but getTagsByWicketId will return an empty list, which feels very inconsistent.
> Since HTML5 made the /> syntax optional for void elements like input and img, the XmlPullParser probably needs to be replaced with something that can parse HTML5.  The fix in WICKET-5874 does not seem sufficient.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)