You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Shri Javadekar <no...@github.com> on 2014/04/16 09:15:19 UTC
[jclouds] Create a separate function to delete directories. (#349)
You can merge this Pull Request by running:
git pull https://github.com/maginatics/jclouds deleteallkeys-cleanup
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds/pull/349
-- Commit Summary --
* Create a separate function to delete directories.
-- File Changes --
M blobstore/src/main/java/org/jclouds/blobstore/strategy/internal/DeleteAllKeysInList.java (45)
-- Patch Links --
https://github.com/jclouds/jclouds/pull/349.patch
https://github.com/jclouds/jclouds/pull/349.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/349
Re: [jclouds] Create a separate function to delete directories.
(#349)
Posted by Andrew Phillips <no...@github.com>.
Just to make sure I'm understanding this correctly: it's purely a refactoring commit? Only one minor formatting comment, otherwise looks good to me.
Thanks, @shrinandj!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/349#issuecomment-40781268
Re: [jclouds] Create a separate function to delete directories.
(#349)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds #1041](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1041/) UNSTABLE
Looks like there's a problem with this pull request
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/349#issuecomment-40969875
Re: [jclouds] Create a separate function to delete directories.
(#349)
Posted by Andrew Phillips <no...@github.com>.
Compilation error now:
```
plugin:3.1:compile (default-compile) on project jclouds-blobstore: Compilation failure
/scratch/jenkins/workspace/jclouds-pull-requests/blobstore/src/main/java/org/jclouds/blobstore/strategy/internal/DeleteAllKeysInList.java:[180,57] cannot find symbol
symbol : class ListContianerOptions
location: class org.jclouds.blobstore.strategy.internal.DeleteAllKeysInList
```
Could you kindly have a look, @shrinandj?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/349#issuecomment-40868907
Re: [jclouds] Create a separate function to delete directories.
(#349)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #766](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/766/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/349#issuecomment-40968239
Re: [jclouds] Create a separate function to delete directories.
(#349)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds #1037](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1037/) FAILURE
Looks like there's a problem with this pull request
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/349#issuecomment-40855916
Re: [jclouds] Create a separate function to delete directories.
(#349)
Posted by Shri Javadekar <no...@github.com>.
> @@ -177,6 +177,26 @@ private String getMessage(final String containerName,
> return listing;
> }
>
> + private ListenableFuture<Void> deleteDirectory(
Done.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/349/files#r11788434
Re: [jclouds] Create a separate function to delete directories.
(#349)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #1230](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1230/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/349#issuecomment-40574233
Re: [jclouds] Create a separate function to delete directories.
(#349)
Posted by Andrew Phillips <no...@github.com>.
> jclouds » jclouds #1041 UNSTABLE
Unrelated [test failure](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/org.apache.jclouds$jclouds-core/1041/testReport/junit/org.jclouds.rest.functions/PresentWhenApiVersionLexicographicallyAtOrAfterSinceApiVersionTest/testCacheIsFasterWhenAnnotationPresent/).
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/349#issuecomment-41019432
Re: [jclouds] Create a separate function to delete directories.
(#349)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #1236](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1236/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/349#issuecomment-40968532
Re: [jclouds] Create a separate function to delete directories.
(#349)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds #1033](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1033/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/349#issuecomment-40572807
Re: [jclouds] Create a separate function to delete directories.
(#349)
Posted by Andrew Phillips <no...@github.com>.
> @@ -177,6 +177,26 @@ private String getMessage(final String containerName,
> return listing;
> }
>
> + private ListenableFuture<Void> deleteDirectory(
I don't see the change yet - have you pushed the updated commit?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/349/files#r11789893
Re: [jclouds] Create a separate function to delete directories.
(#349)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #760](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/760/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/349#issuecomment-40573788
Re: [jclouds] Create a separate function to delete directories.
(#349)
Posted by Andrew Phillips <no...@github.com>.
> @@ -177,6 +177,26 @@ private String getMessage(final String containerName,
> return listing;
> }
>
> + private ListenableFuture<Void> deleteDirectory(
[minor] Could you move `final ListContainerOptions options, ` up one row?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/349/files#r11762002
Re: [jclouds] Create a separate function to delete directories.
(#349)
Posted by Shri Javadekar <no...@github.com>.
Your're right. This is a purely refactoring commit.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/349#issuecomment-40847919
Re: [jclouds] Create a separate function to delete directories.
(#349)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #763](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/763/) FAILURE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/349#issuecomment-40854428
Re: [jclouds] Create a separate function to delete directories.
(#349)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #1233](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1233/) FAILURE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/349#issuecomment-40854480
Re: [jclouds] Create a separate function to delete directories.
(#349)
Posted by Andrew Phillips <no...@github.com>.
Committed to [master](https://git-wip-us.apache.org/repos/asf?p=jclouds.git;a=commit;h=c6cb169dee73de8c75c6850b504b6644c12d2ba1). Thanks for cleaning up, @shrinandj!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/349#issuecomment-41019749
Re: [jclouds] Create a separate function to delete directories.
(#349)
Posted by Andrew Phillips <no...@github.com>.
Closed #349.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/349