You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Erik Huelsmann <eh...@gmail.com> on 2005/08/19 23:01:03 UTC
[PATCH] configure-script change to allow compiling against Neon 0.25.2
I'd like configure wizzards to look at this patch.
Log:
[[[
Allow compilation against neon 0.25.x
* configure.in: Allow all neon 0.25 series releases.
* build/ac-macros/neon.m4 (SVN_LIB_NEON): Don't check explicitly for
neon 0.25.0
]]]
Thanks!
bye,
Erik.
Index: configure.in
===================================================================
--- configure.in (revision 15793)
+++ configure.in (working copy)
@@ -227,8 +227,8 @@
# Either a space-separated list of allowable Neon versions, or "any" to
# mean allow anything.
-NEON_ALLOWED_LIST="0.24.7 0.25.0"
-NEON_LATEST_WORKING_VER=0.25.0
+NEON_ALLOWED_LIST="0.24.7 0.25.0 0.25.1 0.25.2"
+NEON_LATEST_WORKING_VER=0.25.2
NEON_URL="http://www.webdav.org/neon/neon-${NEON_LATEST_WORKING_VER}.tar.gz"
dnl You can skip the neon version check only if you know what you are doing
AC_ARG_ENABLE(neon-version-check,
Index: build/ac-macros/neon.m4
===================================================================
--- build/ac-macros/neon.m4 (revision 15793)
+++ build/ac-macros/neon.m4 (working copy)
@@ -50,9 +50,9 @@
NEON_VERSION=`cat $abs_srcdir/neon/.version`
AC_MSG_RESULT([$NEON_VERSION])
- if test $NEON_VERSION = "0.25.0" ; then
+ if -n "`echo \"$NEON_VERSION\" | grep '^0\.25\.`" ; then
AC_DEFINE_UNQUOTED([SVN_NEON_0_25_0], [1],
- [Defined if have Neon 0.25.0 instead of 0.24.7.])
+ [Defined if have Neon 0.25.x instead of 0.24.7.])
fi
for svn_allowed_neon in $NEON_ALLOWED_LIST; do
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] configure-script change to allow compiling against Neon 0.25.2
Posted by kf...@collab.net.
"Max Bowsher" <ma...@ukf.net> writes:
> kfogel@collab.net wrote:
> > "Max Bowsher" <ma...@ukf.net> writes:
> >> OK, to rephrase - is there ever any reason not to allow *later*
> >> versions neon than were current at the time of release of a subversion
> >> package?
> >
> > Neon's APIs are not stable. I'd have to check the website, but I
> > think the deal is: things are stable within a given micro series, but
> > if the major or minor changes, all bets are off.
>
> I know. Earlier context of the thread indicates an implicit "within
> the same micro series".
Just a miscommunication, then, okay.
I was following the thread too, but simply assumed that you had left
out those qualifiers deliberately and were proposing a more radical
change than you actually were.
+1 on allowing 0.25.*, of course.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] configure-script change to allow compiling against Neon 0.25.2
Posted by Max Bowsher <ma...@ukf.net>.
kfogel@collab.net wrote:
> "Max Bowsher" <ma...@ukf.net> writes:
>> OK, to rephrase - is there ever any reason not to allow *later*
>> versions neon than were current at the time of release of a subversion
>> package?
>
> Neon's APIs are not stable. I'd have to check the website, but I
> think the deal is: things are stable within a given micro series, but
> if the major or minor changes, all bets are off.
I know. Earlier context of the thread indicates an implicit "within the same
micro series".
Max.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] configure-script change to allow compiling against Neon 0.25.2
Posted by kf...@collab.net.
"Max Bowsher" <ma...@ukf.net> writes:
> OK, to rephrase - is there ever any reason not to allow *later*
> versions neon than were current at the time of release of a subversion
> package?
Neon's APIs are not stable. I'd have to check the website, but I
think the deal is: things are stable within a given micro series, but
if the major or minor changes, all bets are off.
-Karl
--
www.collab.net <> CollabNet | Distributed Development On Demand
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] configure-script change to allow compiling against Neon 0.25.2
Posted by Max Bowsher <ma...@ukf.net>.
Erik Huelsmann wrote:
> On 8/23/05, Max Bowsher <ma...@ukf.net> wrote:
>> Marcus Rueckert wrote:
>>> On 2005-08-22 15:31:09 -0500, kfogel@collab.net wrote:
>>>> This looks correct to me. If you tested that it can build, say, Neon
>>>> 0.25.0 and 0.25.2, then +1 on committing it. And thanks!
>>>>
>>>> Your log message should mention the symbol names for the changes to
>>>> NEON_ALLOWED_LIST and NEON_LATEST_WORKING_VER (minor nit).
>>>>
>>>> -Karl
>>>
>>> 0.25.3 is released already. maybe test this version to and update the
>>> patch accordingly?
>>
>> Is there any reason not to accept 0.25.<anything> ?
>
> Not at this time. We did need that feature at one time in the 0.24
> series when security holes were discovered....
>
> I thought to work on within that framework.
OK, to rephrase - is there ever any reason not to allow *later* versions
neon than were current at the time of release of a subversion package?
I can understand forbidding versions earlier than a certain number, but I
think having configure refuse to use later versions is not so good.
Max.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] configure-script change to allow compiling against Neon 0.25.2
Posted by Erik Huelsmann <eh...@gmail.com>.
On 8/23/05, Max Bowsher <ma...@ukf.net> wrote:
> Marcus Rueckert wrote:
> > On 2005-08-22 15:31:09 -0500, kfogel@collab.net wrote:
> >> This looks correct to me. If you tested that it can build, say, Neon
> >> 0.25.0 and 0.25.2, then +1 on committing it. And thanks!
> >>
> >> Your log message should mention the symbol names for the changes to
> >> NEON_ALLOWED_LIST and NEON_LATEST_WORKING_VER (minor nit).
> >>
> >> -Karl
> >
> > 0.25.3 is released already. maybe test this version to and update the
> > patch accordingly?
>
> Is there any reason not to accept 0.25.<anything> ?
Not at this time. We did need that feature at one time in the 0.24
series when security holes were discovered....
I thought to work on within that framework.
bye,
Erik.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] configure-script change to allow compiling against Neon 0.25.2
Posted by Max Bowsher <ma...@ukf.net>.
Marcus Rueckert wrote:
> On 2005-08-22 15:31:09 -0500, kfogel@collab.net wrote:
>> This looks correct to me. If you tested that it can build, say, Neon
>> 0.25.0 and 0.25.2, then +1 on committing it. And thanks!
>>
>> Your log message should mention the symbol names for the changes to
>> NEON_ALLOWED_LIST and NEON_LATEST_WORKING_VER (minor nit).
>>
>> -Karl
>
> 0.25.3 is released already. maybe test this version to and update the
> patch accordingly?
Is there any reason not to accept 0.25.<anything> ?
Max.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] configure-script change to allow compiling against Neon 0.25.2
Posted by Marcus Rueckert <da...@web.de>.
On 2005-08-22 15:31:09 -0500, kfogel@collab.net wrote:
> This looks correct to me. If you tested that it can build, say, Neon
> 0.25.0 and 0.25.2, then +1 on committing it. And thanks!
>
> Your log message should mention the symbol names for the changes to
> NEON_ALLOWED_LIST and NEON_LATEST_WORKING_VER (minor nit).
>
> -Karl
0.25.3 is released already. maybe test this version to and update the
patch accordingly?
darix
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] configure-script change to allow compiling against Neon 0.25.2
Posted by kf...@collab.net.
Erik Huelsmann <eh...@gmail.com> writes:
> I'd like configure wizzards to look at this patch.
This looks correct to me. If you tested that it can build, say, Neon
0.25.0 and 0.25.2, then +1 on committing it. And thanks!
Your log message should mention the symbol names for the changes to
NEON_ALLOWED_LIST and NEON_LATEST_WORKING_VER (minor nit).
-Karl
> Log:
> [[[
> Allow compilation against neon 0.25.x
>
> * configure.in: Allow all neon 0.25 series releases.
>
> * build/ac-macros/neon.m4 (SVN_LIB_NEON): Don't check explicitly for
> neon 0.25.0
> ]]]
>
> Thanks!
>
> bye,
>
> Erik.
>
>
> Index: configure.in
> ===================================================================
> --- configure.in (revision 15793)
> +++ configure.in (working copy)
> @@ -227,8 +227,8 @@
>
> # Either a space-separated list of allowable Neon versions, or "any" to
> # mean allow anything.
> -NEON_ALLOWED_LIST="0.24.7 0.25.0"
> -NEON_LATEST_WORKING_VER=0.25.0
> +NEON_ALLOWED_LIST="0.24.7 0.25.0 0.25.1 0.25.2"
> +NEON_LATEST_WORKING_VER=0.25.2
> NEON_URL="http://www.webdav.org/neon/neon-${NEON_LATEST_WORKING_VER}.tar.gz"
> dnl You can skip the neon version check only if you know what you are doing
> AC_ARG_ENABLE(neon-version-check,
> Index: build/ac-macros/neon.m4
> ===================================================================
> --- build/ac-macros/neon.m4 (revision 15793)
> +++ build/ac-macros/neon.m4 (working copy)
> @@ -50,9 +50,9 @@
> NEON_VERSION=`cat $abs_srcdir/neon/.version`
> AC_MSG_RESULT([$NEON_VERSION])
>
> - if test $NEON_VERSION = "0.25.0" ; then
> + if -n "`echo \"$NEON_VERSION\" | grep '^0\.25\.`" ; then
> AC_DEFINE_UNQUOTED([SVN_NEON_0_25_0], [1],
> - [Defined if have Neon 0.25.0 instead of 0.24.7.])
> + [Defined if have Neon 0.25.x instead of 0.24.7.])
> fi
>
> for svn_allowed_neon in $NEON_ALLOWED_LIST; do
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org
>
--
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org