You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@metamodel.apache.org by Kasper Sørensen <i....@gmail.com> on 2015/06/05 14:14:18 UTC

Review Request 35123: METAMODEL-148: Created a HdfsResource

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35123/
-----------------------------------------------------------

Review request for MetaModel.


Bugs: METAMODEL-148
    https://issues.apache.org/jira/browse/METAMODEL-148


Repository: metamodel


Description
-------

This more or less fixes METAMODEL-148.

Items I am not sure about:

 * I am not sure if we can implement the isReadOnly() method in any sensible way?
 * I wanted to have as little client-side configuration as possible, so I create the hadoop Configuration on-the-fly. Maybe it would be good also with an option to load it from a hadoop conf XML file?
 * I updated also hbase to the latest version, but that created a lot of deprecation warnings, so I should probably rather just leave it alone :-P


Diffs
-----

  core/src/main/java/org/apache/metamodel/util/Func.java 684411f 
  core/src/main/java/org/apache/metamodel/util/UncheckedFunc.java PRE-CREATION 
  hadoop/.gitignore PRE-CREATION 
  hadoop/pom.xml PRE-CREATION 
  hadoop/src/main/java/org/apache/metamodel/util/HdfsResource.java PRE-CREATION 
  hadoop/src/test/java/org/apache/metamodel/util/HdfsResourceTest.java PRE-CREATION 
  hbase/pom.xml b3ded40 
  hbase/src/main/java/org/apache/metamodel/hbase/HBaseDataContext.java a501790 
  pom.xml 5cb93f3 

Diff: https://reviews.apache.org/r/35123/diff/


Testing
-------

Only local testing. Needs integration test.


Thanks,

Kasper Sørensen


Re: Review Request 35123: METAMODEL-148: Created a HdfsResource

Posted by Dennis Krøger <De...@humaninference.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35123/#review86790
-----------------------------------------------------------



hadoop/src/main/java/org/apache/metamodel/util/HdfsResource.java
<https://reviews.apache.org/r/35123/#comment138869>

    If we aren't sure how to implement something, let's write that. The auto-TODO comment makes it look like it haven't been considered/looked at.



hadoop/src/main/java/org/apache/metamodel/util/HdfsResource.java
<https://reviews.apache.org/r/35123/#comment138870>

    Wouldn't it be better to use Arrays.hashCode(_filepath, _hostname, _port) instead of reimplementing it?


- Dennis Krøger


On June 5, 2015, 12:14 p.m., Kasper Sørensen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35123/
> -----------------------------------------------------------
> 
> (Updated June 5, 2015, 12:14 p.m.)
> 
> 
> Review request for MetaModel.
> 
> 
> Bugs: METAMODEL-148
>     https://issues.apache.org/jira/browse/METAMODEL-148
> 
> 
> Repository: metamodel
> 
> 
> Description
> -------
> 
> This more or less fixes METAMODEL-148.
> 
> Items I am not sure about:
> 
>  * I am not sure if we can implement the isReadOnly() method in any sensible way?
>  * I wanted to have as little client-side configuration as possible, so I create the hadoop Configuration on-the-fly. Maybe it would be good also with an option to load it from a hadoop conf XML file?
>  * I updated also hbase to the latest version, but that created a lot of deprecation warnings, so I should probably rather just leave it alone :-P
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/metamodel/util/Func.java 684411f 
>   core/src/main/java/org/apache/metamodel/util/UncheckedFunc.java PRE-CREATION 
>   hadoop/.gitignore PRE-CREATION 
>   hadoop/pom.xml PRE-CREATION 
>   hadoop/src/main/java/org/apache/metamodel/util/HdfsResource.java PRE-CREATION 
>   hadoop/src/test/java/org/apache/metamodel/util/HdfsResourceTest.java PRE-CREATION 
>   hbase/pom.xml b3ded40 
>   hbase/src/main/java/org/apache/metamodel/hbase/HBaseDataContext.java a501790 
>   pom.xml 5cb93f3 
> 
> Diff: https://reviews.apache.org/r/35123/diff/
> 
> 
> Testing
> -------
> 
> Only local testing. Needs integration test.
> 
> 
> Thanks,
> 
> Kasper Sørensen
> 
>


Re: Review Request 35123: METAMODEL-148: Created a HdfsResource

Posted by Tomasz Guzialek <to...@guzialek.info>.

> On June 5, 2015, 1:40 p.m., Tomasz Guzialek wrote:
> > hadoop/src/main/java/org/apache/metamodel/util/HdfsResource.java, line 25
> > <https://reviews.apache.org/r/35123/diff/2/?file=979936#file979936line25>
> >
> >     We could think about a default port number.
> 
> Kasper Sørensen wrote:
>     I would like that, but having trouble figuring out what the default actually is. According to this page [1] the default is 8200. But according to the Apache Hadoop documentation [2] it should be set up normally to run on port 9000. So maybe 9000 is a defacto standard while 8200 is the true default. I am not sure, so it's hard for me to judge.
>     
>     [1] http://blog.cloudera.com/blog/2009/08/hadoop-default-ports-quick-reference
>     [2] http://hadoop.apache.org/docs/stable/hadoop-project-dist/hadoop-common/SingleCluster.html

If that's the case, let's leave it as it is and not assume something that might be incorrect. From my side: ship it!


- Tomasz


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35123/#review86793
-----------------------------------------------------------


On June 5, 2015, 1:30 p.m., Kasper Sørensen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35123/
> -----------------------------------------------------------
> 
> (Updated June 5, 2015, 1:30 p.m.)
> 
> 
> Review request for MetaModel.
> 
> 
> Bugs: METAMODEL-148
>     https://issues.apache.org/jira/browse/METAMODEL-148
> 
> 
> Repository: metamodel
> 
> 
> Description
> -------
> 
> This more or less fixes METAMODEL-148.
> 
> Items I am not sure about:
> 
>  * I am not sure if we can implement the isReadOnly() method in any sensible way?
>  * I wanted to have as little client-side configuration as possible, so I create the hadoop Configuration on-the-fly. Maybe it would be good also with an option to load it from a hadoop conf XML file?
>  * I updated also hbase to the latest version, but that created a lot of deprecation warnings, so I should probably rather just leave it alone :-P
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/metamodel/util/Func.java 684411f 
>   core/src/main/java/org/apache/metamodel/util/UncheckedFunc.java PRE-CREATION 
>   hadoop/.gitignore PRE-CREATION 
>   hadoop/pom.xml PRE-CREATION 
>   hadoop/src/main/java/org/apache/metamodel/util/HdfsResource.java PRE-CREATION 
>   hadoop/src/test/java/org/apache/metamodel/util/HdfsResourceTest.java PRE-CREATION 
>   hbase/pom.xml b3ded40 
>   hbase/src/main/java/org/apache/metamodel/hbase/HBaseDataContext.java a501790 
>   pom.xml 5cb93f3 
> 
> Diff: https://reviews.apache.org/r/35123/diff/
> 
> 
> Testing
> -------
> 
> Only local testing. And monkey tested it with my own HDFS setup.
> Probably needs a formal integration test.
> 
> 
> Thanks,
> 
> Kasper Sørensen
> 
>


Re: Review Request 35123: METAMODEL-148: Created a HdfsResource

Posted by Kasper Sørensen <i....@gmail.com>.

> On juni 5, 2015, 1:40 p.m., Tomasz Guzialek wrote:
> > pom.xml, line 67
> > <https://reviews.apache.org/r/35123/diff/2/?file=979940#file979940line67>
> >
> >     Isn't HDFS a better name? Name Hadoop brings also the processing framework to the game.

I was thinking of doing it this way so that other hadoop-client related utilities could be put in here. And then it also makes sense to let e.g. the hbase module depend on this module and have it's dependencies managed from here.


- Kasper


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35123/#review86793
-----------------------------------------------------------


On juni 5, 2015, 1:30 p.m., Kasper Sørensen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35123/
> -----------------------------------------------------------
> 
> (Updated juni 5, 2015, 1:30 p.m.)
> 
> 
> Review request for MetaModel.
> 
> 
> Bugs: METAMODEL-148
>     https://issues.apache.org/jira/browse/METAMODEL-148
> 
> 
> Repository: metamodel
> 
> 
> Description
> -------
> 
> This more or less fixes METAMODEL-148.
> 
> Items I am not sure about:
> 
>  * I am not sure if we can implement the isReadOnly() method in any sensible way?
>  * I wanted to have as little client-side configuration as possible, so I create the hadoop Configuration on-the-fly. Maybe it would be good also with an option to load it from a hadoop conf XML file?
>  * I updated also hbase to the latest version, but that created a lot of deprecation warnings, so I should probably rather just leave it alone :-P
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/metamodel/util/Func.java 684411f 
>   core/src/main/java/org/apache/metamodel/util/UncheckedFunc.java PRE-CREATION 
>   hadoop/.gitignore PRE-CREATION 
>   hadoop/pom.xml PRE-CREATION 
>   hadoop/src/main/java/org/apache/metamodel/util/HdfsResource.java PRE-CREATION 
>   hadoop/src/test/java/org/apache/metamodel/util/HdfsResourceTest.java PRE-CREATION 
>   hbase/pom.xml b3ded40 
>   hbase/src/main/java/org/apache/metamodel/hbase/HBaseDataContext.java a501790 
>   pom.xml 5cb93f3 
> 
> Diff: https://reviews.apache.org/r/35123/diff/
> 
> 
> Testing
> -------
> 
> Only local testing. And monkey tested it with my own HDFS setup.
> Probably needs a formal integration test.
> 
> 
> Thanks,
> 
> Kasper Sørensen
> 
>


Re: Review Request 35123: METAMODEL-148: Created a HdfsResource

Posted by Kasper Sørensen <i....@gmail.com>.

> On juni 5, 2015, 1:40 p.m., Tomasz Guzialek wrote:
> > hadoop/src/main/java/org/apache/metamodel/util/HdfsResource.java, line 25
> > <https://reviews.apache.org/r/35123/diff/2/?file=979936#file979936line25>
> >
> >     We could think about a default port number.

I would like that, but having trouble figuring out what the default actually is. According to this page [1] the default is 8200. But according to the Apache Hadoop documentation [2] it should be set up normally to run on port 9000. So maybe 9000 is a defacto standard while 8200 is the true default. I am not sure, so it's hard for me to judge.

[1] http://blog.cloudera.com/blog/2009/08/hadoop-default-ports-quick-reference
[2] http://hadoop.apache.org/docs/stable/hadoop-project-dist/hadoop-common/SingleCluster.html


- Kasper


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35123/#review86793
-----------------------------------------------------------


On juni 5, 2015, 1:30 p.m., Kasper Sørensen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35123/
> -----------------------------------------------------------
> 
> (Updated juni 5, 2015, 1:30 p.m.)
> 
> 
> Review request for MetaModel.
> 
> 
> Bugs: METAMODEL-148
>     https://issues.apache.org/jira/browse/METAMODEL-148
> 
> 
> Repository: metamodel
> 
> 
> Description
> -------
> 
> This more or less fixes METAMODEL-148.
> 
> Items I am not sure about:
> 
>  * I am not sure if we can implement the isReadOnly() method in any sensible way?
>  * I wanted to have as little client-side configuration as possible, so I create the hadoop Configuration on-the-fly. Maybe it would be good also with an option to load it from a hadoop conf XML file?
>  * I updated also hbase to the latest version, but that created a lot of deprecation warnings, so I should probably rather just leave it alone :-P
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/metamodel/util/Func.java 684411f 
>   core/src/main/java/org/apache/metamodel/util/UncheckedFunc.java PRE-CREATION 
>   hadoop/.gitignore PRE-CREATION 
>   hadoop/pom.xml PRE-CREATION 
>   hadoop/src/main/java/org/apache/metamodel/util/HdfsResource.java PRE-CREATION 
>   hadoop/src/test/java/org/apache/metamodel/util/HdfsResourceTest.java PRE-CREATION 
>   hbase/pom.xml b3ded40 
>   hbase/src/main/java/org/apache/metamodel/hbase/HBaseDataContext.java a501790 
>   pom.xml 5cb93f3 
> 
> Diff: https://reviews.apache.org/r/35123/diff/
> 
> 
> Testing
> -------
> 
> Only local testing. And monkey tested it with my own HDFS setup.
> Probably needs a formal integration test.
> 
> 
> Thanks,
> 
> Kasper Sørensen
> 
>


Re: Review Request 35123: METAMODEL-148: Created a HdfsResource

Posted by Kasper Sørensen <i....@gmail.com>.

> On juni 5, 2015, 1:40 p.m., Tomasz Guzialek wrote:
> > pom.xml, line 67
> > <https://reviews.apache.org/r/35123/diff/2/?file=979940#file979940line67>
> >
> >     Isn't HDFS a better name? Name Hadoop brings also the processing framework to the game.
> 
> Kasper Sørensen wrote:
>     I was thinking of doing it this way so that other hadoop-client related utilities could be put in here. And then it also makes sense to let e.g. the hbase module depend on this module and have it's dependencies managed from here.
> 
> Tomasz Guzialek wrote:
>     I cannot think immediately about a good example of such a utility. HBase is related to Hadoop as well, but it has its own module - I believe future additions to MM in Hadoop universe will also have a separate module. That's a minor naming thing, though - "hadoop" name is fair enough :).

I am also not 100% sure, but maybe some utilities to use the MetaModel CSV module (or any other module that could use HDFS) in combination with MapReduce jobs - implementing the Input interface in Hadoop's M/R API. Just thinking aloud :) Could also be to allow for injecting/providing a MetaModel DataContext as part of a M/R job (for lookups etc. into a MM data source).


- Kasper


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35123/#review86793
-----------------------------------------------------------


On juni 5, 2015, 1:30 p.m., Kasper Sørensen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35123/
> -----------------------------------------------------------
> 
> (Updated juni 5, 2015, 1:30 p.m.)
> 
> 
> Review request for MetaModel.
> 
> 
> Bugs: METAMODEL-148
>     https://issues.apache.org/jira/browse/METAMODEL-148
> 
> 
> Repository: metamodel
> 
> 
> Description
> -------
> 
> This more or less fixes METAMODEL-148.
> 
> Items I am not sure about:
> 
>  * I am not sure if we can implement the isReadOnly() method in any sensible way?
>  * I wanted to have as little client-side configuration as possible, so I create the hadoop Configuration on-the-fly. Maybe it would be good also with an option to load it from a hadoop conf XML file?
>  * I updated also hbase to the latest version, but that created a lot of deprecation warnings, so I should probably rather just leave it alone :-P
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/metamodel/util/Func.java 684411f 
>   core/src/main/java/org/apache/metamodel/util/UncheckedFunc.java PRE-CREATION 
>   hadoop/.gitignore PRE-CREATION 
>   hadoop/pom.xml PRE-CREATION 
>   hadoop/src/main/java/org/apache/metamodel/util/HdfsResource.java PRE-CREATION 
>   hadoop/src/test/java/org/apache/metamodel/util/HdfsResourceTest.java PRE-CREATION 
>   hbase/pom.xml b3ded40 
>   hbase/src/main/java/org/apache/metamodel/hbase/HBaseDataContext.java a501790 
>   pom.xml 5cb93f3 
> 
> Diff: https://reviews.apache.org/r/35123/diff/
> 
> 
> Testing
> -------
> 
> Only local testing. And monkey tested it with my own HDFS setup.
> Probably needs a formal integration test.
> 
> 
> Thanks,
> 
> Kasper Sørensen
> 
>


Re: Review Request 35123: METAMODEL-148: Created a HdfsResource

Posted by Tomasz Guzialek <to...@guzialek.info>.

> On June 5, 2015, 1:40 p.m., Tomasz Guzialek wrote:
> > pom.xml, line 67
> > <https://reviews.apache.org/r/35123/diff/2/?file=979940#file979940line67>
> >
> >     Isn't HDFS a better name? Name Hadoop brings also the processing framework to the game.
> 
> Kasper Sørensen wrote:
>     I was thinking of doing it this way so that other hadoop-client related utilities could be put in here. And then it also makes sense to let e.g. the hbase module depend on this module and have it's dependencies managed from here.

I cannot think immediately about a good example of such a utility. HBase is related to Hadoop as well, but it has its own module - I believe future additions to MM in Hadoop universe will also have a separate module. That's a minor naming thing, though - "hadoop" name is fair enough :).


- Tomasz


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35123/#review86793
-----------------------------------------------------------


On June 5, 2015, 1:30 p.m., Kasper Sørensen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35123/
> -----------------------------------------------------------
> 
> (Updated June 5, 2015, 1:30 p.m.)
> 
> 
> Review request for MetaModel.
> 
> 
> Bugs: METAMODEL-148
>     https://issues.apache.org/jira/browse/METAMODEL-148
> 
> 
> Repository: metamodel
> 
> 
> Description
> -------
> 
> This more or less fixes METAMODEL-148.
> 
> Items I am not sure about:
> 
>  * I am not sure if we can implement the isReadOnly() method in any sensible way?
>  * I wanted to have as little client-side configuration as possible, so I create the hadoop Configuration on-the-fly. Maybe it would be good also with an option to load it from a hadoop conf XML file?
>  * I updated also hbase to the latest version, but that created a lot of deprecation warnings, so I should probably rather just leave it alone :-P
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/metamodel/util/Func.java 684411f 
>   core/src/main/java/org/apache/metamodel/util/UncheckedFunc.java PRE-CREATION 
>   hadoop/.gitignore PRE-CREATION 
>   hadoop/pom.xml PRE-CREATION 
>   hadoop/src/main/java/org/apache/metamodel/util/HdfsResource.java PRE-CREATION 
>   hadoop/src/test/java/org/apache/metamodel/util/HdfsResourceTest.java PRE-CREATION 
>   hbase/pom.xml b3ded40 
>   hbase/src/main/java/org/apache/metamodel/hbase/HBaseDataContext.java a501790 
>   pom.xml 5cb93f3 
> 
> Diff: https://reviews.apache.org/r/35123/diff/
> 
> 
> Testing
> -------
> 
> Only local testing. And monkey tested it with my own HDFS setup.
> Probably needs a formal integration test.
> 
> 
> Thanks,
> 
> Kasper Sørensen
> 
>


Re: Review Request 35123: METAMODEL-148: Created a HdfsResource

Posted by Tomasz Guzialek <to...@guzialek.info>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35123/#review86793
-----------------------------------------------------------



hadoop/src/main/java/org/apache/metamodel/util/HdfsResource.java
<https://reviews.apache.org/r/35123/#comment138879>

    We could think about a default port number.



pom.xml
<https://reviews.apache.org/r/35123/#comment138878>

    Isn't HDFS a better name? Name Hadoop brings also the processing framework to the game.


- Tomasz Guzialek


On June 5, 2015, 1:30 p.m., Kasper Sørensen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35123/
> -----------------------------------------------------------
> 
> (Updated June 5, 2015, 1:30 p.m.)
> 
> 
> Review request for MetaModel.
> 
> 
> Bugs: METAMODEL-148
>     https://issues.apache.org/jira/browse/METAMODEL-148
> 
> 
> Repository: metamodel
> 
> 
> Description
> -------
> 
> This more or less fixes METAMODEL-148.
> 
> Items I am not sure about:
> 
>  * I am not sure if we can implement the isReadOnly() method in any sensible way?
>  * I wanted to have as little client-side configuration as possible, so I create the hadoop Configuration on-the-fly. Maybe it would be good also with an option to load it from a hadoop conf XML file?
>  * I updated also hbase to the latest version, but that created a lot of deprecation warnings, so I should probably rather just leave it alone :-P
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/metamodel/util/Func.java 684411f 
>   core/src/main/java/org/apache/metamodel/util/UncheckedFunc.java PRE-CREATION 
>   hadoop/.gitignore PRE-CREATION 
>   hadoop/pom.xml PRE-CREATION 
>   hadoop/src/main/java/org/apache/metamodel/util/HdfsResource.java PRE-CREATION 
>   hadoop/src/test/java/org/apache/metamodel/util/HdfsResourceTest.java PRE-CREATION 
>   hbase/pom.xml b3ded40 
>   hbase/src/main/java/org/apache/metamodel/hbase/HBaseDataContext.java a501790 
>   pom.xml 5cb93f3 
> 
> Diff: https://reviews.apache.org/r/35123/diff/
> 
> 
> Testing
> -------
> 
> Only local testing. And monkey tested it with my own HDFS setup.
> Probably needs a formal integration test.
> 
> 
> Thanks,
> 
> Kasper Sørensen
> 
>


Re: Review Request 35123: METAMODEL-148: Created a HdfsResource

Posted by Kasper Sørensen <i....@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35123/
-----------------------------------------------------------

(Updated juni 5, 2015, 1:30 p.m.)


Review request for MetaModel.


Bugs: METAMODEL-148
    https://issues.apache.org/jira/browse/METAMODEL-148


Repository: metamodel


Description
-------

This more or less fixes METAMODEL-148.

Items I am not sure about:

 * I am not sure if we can implement the isReadOnly() method in any sensible way?
 * I wanted to have as little client-side configuration as possible, so I create the hadoop Configuration on-the-fly. Maybe it would be good also with an option to load it from a hadoop conf XML file?
 * I updated also hbase to the latest version, but that created a lot of deprecation warnings, so I should probably rather just leave it alone :-P


Diffs
-----

  core/src/main/java/org/apache/metamodel/util/Func.java 684411f 
  core/src/main/java/org/apache/metamodel/util/UncheckedFunc.java PRE-CREATION 
  hadoop/.gitignore PRE-CREATION 
  hadoop/pom.xml PRE-CREATION 
  hadoop/src/main/java/org/apache/metamodel/util/HdfsResource.java PRE-CREATION 
  hadoop/src/test/java/org/apache/metamodel/util/HdfsResourceTest.java PRE-CREATION 
  hbase/pom.xml b3ded40 
  hbase/src/main/java/org/apache/metamodel/hbase/HBaseDataContext.java a501790 
  pom.xml 5cb93f3 

Diff: https://reviews.apache.org/r/35123/diff/


Testing (updated)
-------

Only local testing. And monkey tested it with my own HDFS setup.
Probably needs a formal integration test.


Thanks,

Kasper Sørensen


Re: Review Request 35123: METAMODEL-148: Created a HdfsResource

Posted by Kasper Sørensen <i....@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35123/
-----------------------------------------------------------

(Updated juni 5, 2015, 1:29 p.m.)


Review request for MetaModel.


Bugs: METAMODEL-148
    https://issues.apache.org/jira/browse/METAMODEL-148


Repository: metamodel


Description
-------

This more or less fixes METAMODEL-148.

Items I am not sure about:

 * I am not sure if we can implement the isReadOnly() method in any sensible way?
 * I wanted to have as little client-side configuration as possible, so I create the hadoop Configuration on-the-fly. Maybe it would be good also with an option to load it from a hadoop conf XML file?
 * I updated also hbase to the latest version, but that created a lot of deprecation warnings, so I should probably rather just leave it alone :-P


Diffs (updated)
-----

  core/src/main/java/org/apache/metamodel/util/Func.java 684411f 
  core/src/main/java/org/apache/metamodel/util/UncheckedFunc.java PRE-CREATION 
  hadoop/.gitignore PRE-CREATION 
  hadoop/pom.xml PRE-CREATION 
  hadoop/src/main/java/org/apache/metamodel/util/HdfsResource.java PRE-CREATION 
  hadoop/src/test/java/org/apache/metamodel/util/HdfsResourceTest.java PRE-CREATION 
  hbase/pom.xml b3ded40 
  hbase/src/main/java/org/apache/metamodel/hbase/HBaseDataContext.java a501790 
  pom.xml 5cb93f3 

Diff: https://reviews.apache.org/r/35123/diff/


Testing
-------

Only local testing. Needs integration test.


Thanks,

Kasper Sørensen