[GitHub] [netbeans] lkishalmi commented on pull request #3828: Made GradleCommandLine aware of GradleVersion

[GitBox <gi...@apache.org>]

lkishalmi commented on pull request #3828:
URL: https://github.com/apache/netbeans/pull/3828#issuecomment-1075330631


   A note on why I considered to filter existing command line options late instead of filter them before. I usually think of a Gradle command line as a space separated string stored somewhere. When I pass that command line to the GradleCommandLine, I'd expect the whole command line to be kept there at least in semantics. Then it can be copied, modified and filtered with the provided methods.
   
   However you've got me thinking. As it all started with ```--configuration-cache``` could be globally enabled. That flag is used maybe 3 times in the code and can be checked the GradleVersion on those spots to add that flag or clear that. So for that problem this implementation is an overkill. I've got carried away as the GradleCommandLine has already have a getSupportedCommandLine() method and I thought it would be fun, if that would understand the target GradleVersion as well.
   
   @sdedic @JaroslavTulach do you see value in this PR for the future?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists