You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/07/16 19:57:50 UTC

[GitHub] [superset] jaksmid opened a new issue #15748: Deck GL.Grid height is not correct

jaksmid opened a new issue #15748:
URL: https://github.com/apache/superset/issues/15748

I am using deck gl grid visualization to show the price per square meter in real estates properties. I noticed that sometimes height is calculated incorrectly. E.g. if I want to show the max price per sq. meter and I have filters that limit rows used such as `price_per_sq_m < 40000`, the height that is shown still exceeds this limit.

I managed to reproduce the bug using the sample dataset shipped with superset.

### Expected results

I would expect that height respects both filters and used aggregated function.

### Actual results

Height does not correspond to the filters and aggregate function. See screenshot.
The height where the mouse is hovering is clearly above the filter. Max function used for aggregation does not change the maximum either and should not exceed the set filter.

#### Screenshots

#### How to reproduce the bug

* Open the deck gl dashboard and explore the grid chart.
* Change the height metric to max(occupancy)
* Set the filter to limit occupancy (e.g. 70).
* Observe heigh of certain areas still exceeding 90.

### Environment

(please complete the following information):

- superset version: `Superset 1.2.0`
- python version: `Python 3.9.5`
- node.js version: `v16.3.0`

### Checklist

Make sure to follow these steps before submitting your issue - thank you!

- [X] I have checked the superset logs for python stacktraces and included it here as text if there are any.
- [X] I have reproduced the issue with at least the latest released version of superset.
- [X] I have checked the issue tracker for the same issue and I haven't found one similar.

### Additional context

Observed this problem even before 1.0

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] jaksmid commented on issue #15748: Deck GL.Grid height is not correct

Posted by GitBox <gi...@apache.org>.

jaksmid commented on issue #15748:
URL: https://github.com/apache/superset/issues/15748#issuecomment-884483524


   I checked what is coming from the backend and all values seem to be fine.
   
   I suspect the problem is in the rendering - the deck grid is probably performing aggregation of nearby locations using own metrics - https://deck.gl/docs/api-reference/aggregation-layers/grid-layer, section elevationAggregation.
   
   By default, a sum is used on the frontend aggregation.
   
   It could be non trivial to make sure the backend and frontend aggregations are in sync.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] jaksmid commented on issue #15748: Deck GL.Grid height is not correct

Posted by GitBox <gi...@apache.org>.

jaksmid commented on issue #15748:
URL: https://github.com/apache/superset/issues/15748#issuecomment-884774051


   Could an interim solution be to expose the options for the deck grid in the superset UI? It would be up to the user to select a combination of backend/frontend aggregation that makes sense.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org